[MediaWiki-commits] [Gerrit] Replace some deprecated setClaims with getStatements - change (mediawiki...Wikibase)
Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/174109 Change subject: Replace some deprecated setClaims with getStatements .. Replace some deprecated setClaims with getStatements Change-Id: Ifb57318b61f7a9e9f11176aed56db14fdd2364c4 --- M repo/tests/phpunit/includes/ChangeOp/ChangeOpClaimRemoveTest.php M repo/tests/phpunit/includes/ChangeOp/ChangeOpMainSnakTest.php M repo/tests/phpunit/includes/ChangeOp/ChangeOpQualifierRemoveTest.php M repo/tests/phpunit/includes/ChangeOp/ChangeOpQualifierTest.php M repo/tests/phpunit/includes/ChangeOp/ChangeOpReferenceRemoveTest.php M repo/tests/phpunit/includes/ChangeOp/ChangeOpReferenceTest.php M repo/tests/phpunit/includes/ChangeOp/ChangeOpStatementRankTest.php M repo/tests/phpunit/includes/EntityParserOutputGeneratorTest.php M repo/tests/phpunit/includes/api/ClaimModificationHelperTest.php M repo/tests/phpunit/includes/api/SetClaimTest.php 10 files changed, 58 insertions(+), 61 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase refs/changes/09/174109/1 diff --git a/repo/tests/phpunit/includes/ChangeOp/ChangeOpClaimRemoveTest.php b/repo/tests/phpunit/includes/ChangeOp/ChangeOpClaimRemoveTest.php index 4026582..7fabcc2 100644 --- a/repo/tests/phpunit/includes/ChangeOp/ChangeOpClaimRemoveTest.php +++ b/repo/tests/phpunit/includes/ChangeOp/ChangeOpClaimRemoveTest.php @@ -78,11 +78,12 @@ $item = Item::newEmpty(); $item-setId( new ItemId( $itemIdString ) ); - $claim = $item-newClaim( $snak ); - $claim-setGuid( $item-getId()-getSerialization() . '$D8404CDA-25E4-4334-AG93-A3290BCD9C0P' ); - $claims = new Claims(); - $claims-addClaim( $claim ); - $item-setClaims( $claims ); + $item-getStatements()-addNewStatement( + $snak, + null, + null, + $item-getId()-getSerialization() . '$D8404CDA-25E4-4334-AG93-A3290BCD9C0P' + ); return $item; } diff --git a/repo/tests/phpunit/includes/ChangeOp/ChangeOpMainSnakTest.php b/repo/tests/phpunit/includes/ChangeOp/ChangeOpMainSnakTest.php index e600cbd..f8c0c10 100644 --- a/repo/tests/phpunit/includes/ChangeOp/ChangeOpMainSnakTest.php +++ b/repo/tests/phpunit/includes/ChangeOp/ChangeOpMainSnakTest.php @@ -183,11 +183,12 @@ $item = Item::newEmpty(); $item-setId( new ItemId( $itemIdString ) ); - $claim = $item-newClaim( $snak ); - $claim-setGuid( $this-mockProvider-getGuidGenerator()-newGuid( $item-getId() ) ); - $claims = new Claims(); - $claims-addClaim( $claim ); - $item-setClaims( $claims ); + $item-getStatements()-addNewStatement( + $snak, + null, + null, + $this-mockProvider-getGuidGenerator()-newGuid( $item-getId() ) + ); return $item; } diff --git a/repo/tests/phpunit/includes/ChangeOp/ChangeOpQualifierRemoveTest.php b/repo/tests/phpunit/includes/ChangeOp/ChangeOpQualifierRemoveTest.php index 4f6fd94..15349f1 100644 --- a/repo/tests/phpunit/includes/ChangeOp/ChangeOpQualifierRemoveTest.php +++ b/repo/tests/phpunit/includes/ChangeOp/ChangeOpQualifierRemoveTest.php @@ -81,13 +81,14 @@ $item = Item::newEmpty(); $item-setId( new ItemId( $itemIdString ) ); - $claim = $item-newClaim( $snak ); - $claim-setGuid( $itemIdString . '$D8404CDA-25E4-4334-AG03-A3290BCD9CQP' ); - $claims = new Claims(); - $claims-addClaim( $claim ); - $item-setClaims( $claims ); + $item-getStatements()-addNewStatement( + $snak, + null, + null, + $itemIdString . '$D8404CDA-25E4-4334-AG03-A3290BCD9CQP' + ); return $item; } -} \ No newline at end of file +} diff --git a/repo/tests/phpunit/includes/ChangeOp/ChangeOpQualifierTest.php b/repo/tests/phpunit/includes/ChangeOp/ChangeOpQualifierTest.php index b861e2a..beb309e 100644 --- a/repo/tests/phpunit/includes/ChangeOp/ChangeOpQualifierTest.php +++ b/repo/tests/phpunit/includes/ChangeOp/ChangeOpQualifierTest.php @@ -148,11 +148,12 @@ $item = Item::newEmpty(); $item-setId( 123 ); - $claim = $item-newClaim( $snak ); - $claim-setGuid( $item-getId()-getSerialization() . '$D8404CDA-25E4-4334-AG03-A3290BCD9CQP' ); - $claims = new Claims(); - $claims-addClaim( $claim ); - $item-setClaims( $claims ); +
[MediaWiki-commits] [Gerrit] Replace some deprecated setClaims with getStatements - change (mediawiki...Wikibase)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Replace some deprecated setClaims with getStatements .. Replace some deprecated setClaims with getStatements Change-Id: Ifb57318b61f7a9e9f11176aed56db14fdd2364c4 --- M repo/tests/phpunit/includes/ChangeOp/ChangeOpClaimRemoveTest.php M repo/tests/phpunit/includes/ChangeOp/ChangeOpMainSnakTest.php M repo/tests/phpunit/includes/ChangeOp/ChangeOpQualifierRemoveTest.php M repo/tests/phpunit/includes/ChangeOp/ChangeOpQualifierTest.php M repo/tests/phpunit/includes/ChangeOp/ChangeOpReferenceRemoveTest.php M repo/tests/phpunit/includes/ChangeOp/ChangeOpReferenceTest.php M repo/tests/phpunit/includes/ChangeOp/ChangeOpStatementRankTest.php M repo/tests/phpunit/includes/EntityParserOutputGeneratorTest.php M repo/tests/phpunit/includes/api/ClaimModificationHelperTest.php M repo/tests/phpunit/includes/api/SetClaimTest.php 10 files changed, 58 insertions(+), 61 deletions(-) Approvals: Jeroen De Dauw: Looks good to me, approved diff --git a/repo/tests/phpunit/includes/ChangeOp/ChangeOpClaimRemoveTest.php b/repo/tests/phpunit/includes/ChangeOp/ChangeOpClaimRemoveTest.php index 4026582..7fabcc2 100644 --- a/repo/tests/phpunit/includes/ChangeOp/ChangeOpClaimRemoveTest.php +++ b/repo/tests/phpunit/includes/ChangeOp/ChangeOpClaimRemoveTest.php @@ -78,11 +78,12 @@ $item = Item::newEmpty(); $item-setId( new ItemId( $itemIdString ) ); - $claim = $item-newClaim( $snak ); - $claim-setGuid( $item-getId()-getSerialization() . '$D8404CDA-25E4-4334-AG93-A3290BCD9C0P' ); - $claims = new Claims(); - $claims-addClaim( $claim ); - $item-setClaims( $claims ); + $item-getStatements()-addNewStatement( + $snak, + null, + null, + $item-getId()-getSerialization() . '$D8404CDA-25E4-4334-AG93-A3290BCD9C0P' + ); return $item; } diff --git a/repo/tests/phpunit/includes/ChangeOp/ChangeOpMainSnakTest.php b/repo/tests/phpunit/includes/ChangeOp/ChangeOpMainSnakTest.php index e600cbd..f8c0c10 100644 --- a/repo/tests/phpunit/includes/ChangeOp/ChangeOpMainSnakTest.php +++ b/repo/tests/phpunit/includes/ChangeOp/ChangeOpMainSnakTest.php @@ -183,11 +183,12 @@ $item = Item::newEmpty(); $item-setId( new ItemId( $itemIdString ) ); - $claim = $item-newClaim( $snak ); - $claim-setGuid( $this-mockProvider-getGuidGenerator()-newGuid( $item-getId() ) ); - $claims = new Claims(); - $claims-addClaim( $claim ); - $item-setClaims( $claims ); + $item-getStatements()-addNewStatement( + $snak, + null, + null, + $this-mockProvider-getGuidGenerator()-newGuid( $item-getId() ) + ); return $item; } diff --git a/repo/tests/phpunit/includes/ChangeOp/ChangeOpQualifierRemoveTest.php b/repo/tests/phpunit/includes/ChangeOp/ChangeOpQualifierRemoveTest.php index 4f6fd94..15349f1 100644 --- a/repo/tests/phpunit/includes/ChangeOp/ChangeOpQualifierRemoveTest.php +++ b/repo/tests/phpunit/includes/ChangeOp/ChangeOpQualifierRemoveTest.php @@ -81,13 +81,14 @@ $item = Item::newEmpty(); $item-setId( new ItemId( $itemIdString ) ); - $claim = $item-newClaim( $snak ); - $claim-setGuid( $itemIdString . '$D8404CDA-25E4-4334-AG03-A3290BCD9CQP' ); - $claims = new Claims(); - $claims-addClaim( $claim ); - $item-setClaims( $claims ); + $item-getStatements()-addNewStatement( + $snak, + null, + null, + $itemIdString . '$D8404CDA-25E4-4334-AG03-A3290BCD9CQP' + ); return $item; } -} \ No newline at end of file +} diff --git a/repo/tests/phpunit/includes/ChangeOp/ChangeOpQualifierTest.php b/repo/tests/phpunit/includes/ChangeOp/ChangeOpQualifierTest.php index b861e2a..beb309e 100644 --- a/repo/tests/phpunit/includes/ChangeOp/ChangeOpQualifierTest.php +++ b/repo/tests/phpunit/includes/ChangeOp/ChangeOpQualifierTest.php @@ -148,11 +148,12 @@ $item = Item::newEmpty(); $item-setId( 123 ); - $claim = $item-newClaim( $snak ); - $claim-setGuid( $item-getId()-getSerialization() . '$D8404CDA-25E4-4334-AG03-A3290BCD9CQP' ); - $claims = new Claims(); - $claims-addClaim( $claim ); - $item-setClaims( $claims ); + $item-getStatements()-addNewStatement( + $snak, + null, +
