[MediaWiki-commits] [Gerrit] Return from function after redirect - change (mediawiki...DonationInterface)

2015-11-23 Thread Ejegg (Code Review) 
Ejegg has submitted this change and it was merged.

Change subject: Return from function after redirect
..


Return from function after redirect

Prevents unintended fallthrough to fail page redirect, which was
superceding the intended one.

Bug: T118349
Change-Id: Ib25877badb79c1ab1c097fc4fc085d8f9b40e576
---
M globalcollect_gateway/globalcollect_resultswitcher.body.php
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Ejegg: Verified; Looks good to me, approved
  jenkins-bot: Verified



diff --git a/globalcollect_gateway/globalcollect_resultswitcher.body.php 
b/globalcollect_gateway/globalcollect_resultswitcher.body.php
index c194cb9..d1355e4 100644
--- a/globalcollect_gateway/globalcollect_resultswitcher.body.php
+++ b/globalcollect_gateway/globalcollect_resultswitcher.body.php
@@ -142,6 +142,7 @@
if ( $go ) {
$this->getOutput()->addHTML( 
"Redirecting to page $go" );
$this->getOutput()->redirect( 
$go );
+   return;
} else {
$this->logger->error( 
"Resultswitcher: No redirect defined. Order ID: $oid" );
}

-- 
To view, visit https://gerrit.wikimedia.org/r/254920
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib25877badb79c1ab1c097fc4fc085d8f9b40e576
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/DonationInterface
Gerrit-Branch: deployment
Gerrit-Owner: Ejegg 
Gerrit-Reviewer: AndyRussG 
Gerrit-Reviewer: Awight 
Gerrit-Reviewer: Cdentinger 
Gerrit-Reviewer: Ejegg 
Gerrit-Reviewer: Ssmith 
Gerrit-Reviewer: XenoRyet 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Return from function after redirect - change (mediawiki...DonationInterface)

2015-11-23 Thread Ejegg (Code Review) 
Ejegg has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/254920

Change subject: Return from function after redirect
..

Return from function after redirect

Prevents unintended fallthrough to fail page redirect, which was
superceding the intended one.

Bug: T118349
Change-Id: Ib25877badb79c1ab1c097fc4fc085d8f9b40e576
---
M globalcollect_gateway/globalcollect_resultswitcher.body.php
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/DonationInterface 
refs/changes/20/254920/1

diff --git a/globalcollect_gateway/globalcollect_resultswitcher.body.php 
b/globalcollect_gateway/globalcollect_resultswitcher.body.php
index c194cb9..d1355e4 100644
--- a/globalcollect_gateway/globalcollect_resultswitcher.body.php
+++ b/globalcollect_gateway/globalcollect_resultswitcher.body.php
@@ -142,6 +142,7 @@
if ( $go ) {
$this->getOutput()->addHTML( 
"Redirecting to page $go" );
$this->getOutput()->redirect( 
$go );
+   return;
} else {
$this->logger->error( 
"Resultswitcher: No redirect defined. Order ID: $oid" );
}

-- 
To view, visit https://gerrit.wikimedia.org/r/254920
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib25877badb79c1ab1c097fc4fc085d8f9b40e576
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/DonationInterface
Gerrit-Branch: deployment
Gerrit-Owner: Ejegg 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Return from function after redirect - change (mediawiki...DonationInterface)

2015-11-23 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Return from function after redirect
..


Return from function after redirect

Prevents unintended fallthrough to fail page redirect, which was
superceding the intended one.

Bug: T118349
Change-Id: Ib25877badb79c1ab1c097fc4fc085d8f9b40e576
---
M globalcollect_gateway/globalcollect_resultswitcher.body.php
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Cdentinger: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/globalcollect_gateway/globalcollect_resultswitcher.body.php 
b/globalcollect_gateway/globalcollect_resultswitcher.body.php
index c194cb9..d1355e4 100644
--- a/globalcollect_gateway/globalcollect_resultswitcher.body.php
+++ b/globalcollect_gateway/globalcollect_resultswitcher.body.php
@@ -142,6 +142,7 @@
if ( $go ) {
$this->getOutput()->addHTML( 
"Redirecting to page $go" );
$this->getOutput()->redirect( 
$go );
+   return;
} else {
$this->logger->error( 
"Resultswitcher: No redirect defined. Order ID: $oid" );
}

-- 
To view, visit https://gerrit.wikimedia.org/r/254633
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib25877badb79c1ab1c097fc4fc085d8f9b40e576
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/DonationInterface
Gerrit-Branch: master
Gerrit-Owner: Ejegg 
Gerrit-Reviewer: AndyRussG 
Gerrit-Reviewer: Awight 
Gerrit-Reviewer: Cdentinger 
Gerrit-Reviewer: Ssmith 
Gerrit-Reviewer: XenoRyet 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Return from function after redirect - change (mediawiki...DonationInterface)

2015-11-20 Thread Ejegg (Code Review) 
Ejegg has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/254633

Change subject: Return from function after redirect
..

Return from function after redirect

Prevents unintended fallthrough to fail page redirect, which was
superceding the intended one.

Bug: T118349
Change-Id: Ib25877badb79c1ab1c097fc4fc085d8f9b40e576
---
M globalcollect_gateway/globalcollect_resultswitcher.body.php
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/DonationInterface 
refs/changes/33/254633/1

diff --git a/globalcollect_gateway/globalcollect_resultswitcher.body.php 
b/globalcollect_gateway/globalcollect_resultswitcher.body.php
index c194cb9..d1355e4 100644
--- a/globalcollect_gateway/globalcollect_resultswitcher.body.php
+++ b/globalcollect_gateway/globalcollect_resultswitcher.body.php
@@ -142,6 +142,7 @@
if ( $go ) {
$this->getOutput()->addHTML( 
"Redirecting to page $go" );
$this->getOutput()->redirect( 
$go );
+   return;
} else {
$this->logger->error( 
"Resultswitcher: No redirect defined. Order ID: $oid" );
}

-- 
To view, visit https://gerrit.wikimedia.org/r/254633
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib25877badb79c1ab1c097fc4fc085d8f9b40e576
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/DonationInterface
Gerrit-Branch: master
Gerrit-Owner: Ejegg 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits