[MediaWiki-commits] [Gerrit] Revert Add SVG versions of toolbar icons - change (mediawiki...WikiEditor)

2014-11-04 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged.

Change subject: Revert Add SVG versions of toolbar icons
..


Revert Add SVG versions of toolbar icons

There were issues with shadows, and the sprite creating weird
offsetted buttons on Chrome.
Subsequent attempts have been incomplete at solving these, so
reverting this and hoping that the next person to attempt a conversion
to SVG is more successful.

This reverts commit e027051c58a8e76b1d254fde8ed62421f3740f32.

Bug: 35342
Change-Id: Id296899a2c3746957c17068ab17ca8266f6ff0d3
---
D modules/images/toolbar/button-sprite.svg
D modules/images/toolbar/format-big.svg
D modules/images/toolbar/format-bold-A.svg
D modules/images/toolbar/format-bold-B.svg
D modules/images/toolbar/format-bold-F.svg
D modules/images/toolbar/format-bold-G.svg
D modules/images/toolbar/format-bold-N.svg
D modules/images/toolbar/format-bold-P.svg
D modules/images/toolbar/format-bold-V.svg
D modules/images/toolbar/format-bold.svg
D modules/images/toolbar/format-indent.svg
D modules/images/toolbar/format-italic-A.svg
D modules/images/toolbar/format-italic-C.svg
D modules/images/toolbar/format-italic-K.svg
D modules/images/toolbar/format-italic-i.svg
D modules/images/toolbar/format-italic.svg
D modules/images/toolbar/format-olist.svg
D modules/images/toolbar/format-small.svg
D modules/images/toolbar/format-subscript.svg
D modules/images/toolbar/format-superscript.svg
D modules/images/toolbar/format-ulist.svg
D modules/images/toolbar/insert-file.svg
D modules/images/toolbar/insert-gallery.svg
D modules/images/toolbar/insert-ilink.svg
D modules/images/toolbar/insert-link.svg
D modules/images/toolbar/insert-newline.svg
D modules/images/toolbar/insert-nowiki.svg
D modules/images/toolbar/insert-redirect.svg
D modules/images/toolbar/insert-reference.svg
D modules/images/toolbar/insert-signature.svg
D modules/images/toolbar/insert-table.svg
D modules/images/toolbar/insert-xlink.svg
D modules/images/toolbar/search-replace.svg
M modules/jquery.wikiEditor.toolbar.css
34 files changed, 1 insertion(+), 7,798 deletions(-)

Approvals:
  Jforrester: Looks good to me, approved
  jenkins-bot: Verified

Objections:
  Paladox: There's a problem with this change, please improve




-- 
To view, visit https://gerrit.wikimedia.org/r/168821
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id296899a2c3746957c17068ab17ca8266f6ff0d3
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/WikiEditor
Gerrit-Branch: master
Gerrit-Owner: TheDJ hartman.w...@gmail.com
Gerrit-Reviewer: Bartosz DziewoƄski matma@gmail.com
Gerrit-Reviewer: Brion VIBBER br...@wikimedia.org
Gerrit-Reviewer: Catrope roan.katt...@gmail.com
Gerrit-Reviewer: Jforrester jforres...@wikimedia.org
Gerrit-Reviewer: Krinkle krinklem...@gmail.com
Gerrit-Reviewer: Paladox thomasmulhall...@yahoo.com
Gerrit-Reviewer: Trevor Parscal tpars...@wikimedia.org
Gerrit-Reviewer: jenkins-bot 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Revert Add SVG versions of toolbar icons - change (mediawiki...WikiEditor)

2014-10-26 Thread TheDJ (Code Review)
TheDJ has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/168821

Change subject: Revert Add SVG versions of toolbar icons
..

Revert Add SVG versions of toolbar icons

There were issues with shadows, and the sprite creating weird
offsetted buttons on Chrome.
Subsequent attempts have been incomplete at solving these, so
reverting this and hoping that the next person to attempt a conversion
to SVG is more successful.

This reverts commit e027051c58a8e76b1d254fde8ed62421f3740f32.

Bug: 35342
Change-Id: Id296899a2c3746957c17068ab17ca8266f6ff0d3
---
D modules/images/toolbar/button-sprite.svg
D modules/images/toolbar/format-big.svg
D modules/images/toolbar/format-bold-A.svg
D modules/images/toolbar/format-bold-B.svg
D modules/images/toolbar/format-bold-F.svg
D modules/images/toolbar/format-bold-G.svg
D modules/images/toolbar/format-bold-N.svg
D modules/images/toolbar/format-bold-P.svg
D modules/images/toolbar/format-bold-V.svg
D modules/images/toolbar/format-bold.svg
D modules/images/toolbar/format-indent.svg
D modules/images/toolbar/format-italic-A.svg
D modules/images/toolbar/format-italic-C.svg
D modules/images/toolbar/format-italic-K.svg
D modules/images/toolbar/format-italic-i.svg
D modules/images/toolbar/format-italic.svg
D modules/images/toolbar/format-olist.svg
D modules/images/toolbar/format-small.svg
D modules/images/toolbar/format-subscript.svg
D modules/images/toolbar/format-superscript.svg
D modules/images/toolbar/format-ulist.svg
D modules/images/toolbar/insert-file.svg
D modules/images/toolbar/insert-gallery.svg
D modules/images/toolbar/insert-ilink.svg
D modules/images/toolbar/insert-link.svg
D modules/images/toolbar/insert-newline.svg
D modules/images/toolbar/insert-nowiki.svg
D modules/images/toolbar/insert-redirect.svg
D modules/images/toolbar/insert-reference.svg
D modules/images/toolbar/insert-signature.svg
D modules/images/toolbar/insert-table.svg
D modules/images/toolbar/insert-xlink.svg
D modules/images/toolbar/search-replace.svg
M modules/jquery.wikiEditor.toolbar.css
34 files changed, 1 insertion(+), 7,798 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikiEditor 
refs/changes/21/168821/1


-- 
To view, visit https://gerrit.wikimedia.org/r/168821
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id296899a2c3746957c17068ab17ca8266f6ff0d3
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikiEditor
Gerrit-Branch: master
Gerrit-Owner: TheDJ hartman.w...@gmail.com
Gerrit-Reviewer: jenkins-bot 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits