[MediaWiki-commits] [Gerrit] Revert layout changes - change (mediawiki...MultimediaViewer)
Gilles has uploaded a new change for review.
https://gerrit.wikimedia.org/r/171521
Change subject: Revert layout changes
..
Revert layout changes
This reverts several commits that changed above/below-the-fold
Change-Id: Ic1c9d82ea8b4498004ab3530fd903f632c3d4a1b
---
M MultimediaViewer.php
M i18n/en.json
M i18n/qqq.json
M resources/mmv/mmv.globals.less
M resources/mmv/mmv.lightboxinterface.less
M resources/mmv/model/mmv.model.License.js
A resources/mmv/ui/img/drag-active.svg
A resources/mmv/ui/img/drag.svg
D resources/mmv/ui/img/pd.svg
M resources/mmv/ui/img/time.svg
D resources/mmv/ui/img/uploader-ltr.svg
D resources/mmv/ui/img/uploader-rtl.svg
M resources/mmv/ui/mmv.ui.metadataPanel.js
M resources/mmv/ui/mmv.ui.metadataPanel.less
M resources/mmv/ui/mmv.ui.metadataPanelScroller.js
M resources/mmv/ui/mmv.ui.metadataPanelScroller.less
M resources/mmv/ui/mmv.ui.stripeButtons.less
M tests/browser/features/support/pages/e2e_test_page.rb
M tests/qunit/mmv/mmv.lightboxinterface.test.js
M tests/qunit/mmv/model/mmv.model.License.test.js
M tests/qunit/mmv/ui/mmv.ui.metadataPanel.test.js
M tests/qunit/mmv/ui/mmv.ui.metadataPanelScroller.test.js
22 files changed, 474 insertions(+), 442 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MultimediaViewer
refs/changes/21/171521/1
diff --git a/MultimediaViewer.php b/MultimediaViewer.php
index 5822e44..963005c 100644
--- a/MultimediaViewer.php
+++ b/MultimediaViewer.php
@@ -554,7 +554,6 @@
'multimediaviewer-commons-subtitle',
'multimediaviewer-credit',
- 'multimediaviewer-credit-fallback',
'multimediaviewer-userpage-link',
@@ -591,6 +590,8 @@
'multimediaviewer-credit-popup-text',
'multimediaviewer-title-popup-text-more',
'multimediaviewer-credit-popup-text-more',
+ 'multimediaviewer-panel-open-popup-text',
+ 'multimediaviewer-panel-close-popup-text',
),
),
diff --git a/i18n/en.json b/i18n/en.json
index 3b97c13..3e90779 100644
--- a/i18n/en.json
+++ b/i18n/en.json
@@ -1,8 +1,8 @@
{
@metadata: {
- authors: [
- Mark Holmquist mtrac...@member.fsf.org
- ]
+ authors: [
+ Mark Holmquist mtrac...@member.fsf.org
+ ]
},
multimediaviewer-desc: Expand thumbnails in a larger size in a
fullscreen interface.,
multimediaviewer-desc-nil: No description available.,
@@ -15,7 +15,6 @@
multimediaviewer-datetime-uploaded: Uploaded: $1,
multimediaviewer-userpage-link: {{GENDER:$2|Uploaded}} by $1,
multimediaviewer-credit: $1 - $2,
- multimediaviewer-credit-fallback: View author information,
multimediaviewer-metadata-error: Error: Could not load image data.
$1,
multimediaviewer-thumbnail-error: Error: Could not load thumbnail
data. $1,
multimediaviewer-license-cc-by-1.0: CC BY 1.0,
@@ -109,6 +108,8 @@
multimediaviewer-credit-popup-text: Author and source information,
multimediaviewer-title-popup-text-more: Click to show full file
name,
multimediaviewer-credit-popup-text-more: Click to show full author
and source,
+ multimediaviewer-panel-open-popup-text: More details,
+ multimediaviewer-panel-close-popup-text: Fewer details,
multimediaviewer-download-attribution-cta-header: You need to
attribute the author,
multimediaviewer-download-attribution-cta: Show me how,
multimediaviewer-attr-plain: Plain,
diff --git a/i18n/qqq.json b/i18n/qqq.json
index 5c814f9..7b65151 100644
--- a/i18n/qqq.json
+++ b/i18n/qqq.json
@@ -20,8 +20,7 @@
multimediaviewer-datetime-created: Used in JavaScript code.
Parameters:\n* $1 - time and date\nSee also:\n*
{{msg-mw|Multimediaviewer-datetime-uploaded}}\n\nNote that the date comes from
the description page and can have various forms (e.g. \2000-01-01\, \1st
January 2000\, \1492\, \16th century\...)\n\nAlso, this might refer to the
date when the picture was taken, or the date when the depcited work was made -
the usage is not consistent. You should choose a translation that works in all
cases.\n{{Identical|Created}},
multimediaviewer-datetime-uploaded: Used in JavaScript code.
Parameters:\n* $1 - time and date (formatted)\nSee also:\n*
{{msg-mw|Multimediaviewer-datetime-created}}\n{{Identical|Uploaded}},
multimediaviewer-userpage-link: Link to the user page for the
uploader of the image.\n\nUsed in JavaScript code.\n\nParameters:\n* $1 - the
username of the uploader\n* $2 - their gender,
- multimediaviewer-credit: Credit line for images. Parameters:\n* $1 -
HTML describing the author\n* $2 - HTML describing the source\n\nNeither
parameters are usernames, so
[MediaWiki-commits] [Gerrit] Revert layout changes - change (mediawiki...MultimediaViewer)
jenkins-bot has submitted this change and it was merged.
Change subject: Revert layout changes
..
Revert layout changes
This reverts several commits that changed above/below-the-fold
Change-Id: Ic1c9d82ea8b4498004ab3530fd903f632c3d4a1b
---
M MultimediaViewer.php
M i18n/en.json
M i18n/qqq.json
M resources/mmv/mmv.globals.less
M resources/mmv/mmv.lightboxinterface.less
M resources/mmv/model/mmv.model.License.js
A resources/mmv/ui/img/drag-active.svg
A resources/mmv/ui/img/drag.svg
D resources/mmv/ui/img/pd.svg
M resources/mmv/ui/img/time.svg
D resources/mmv/ui/img/uploader-ltr.svg
D resources/mmv/ui/img/uploader-rtl.svg
M resources/mmv/ui/mmv.ui.metadataPanel.js
M resources/mmv/ui/mmv.ui.metadataPanel.less
M resources/mmv/ui/mmv.ui.metadataPanelScroller.js
M resources/mmv/ui/mmv.ui.metadataPanelScroller.less
M resources/mmv/ui/mmv.ui.stripeButtons.less
M tests/browser/features/support/pages/e2e_test_page.rb
M tests/qunit/mmv/mmv.lightboxinterface.test.js
M tests/qunit/mmv/model/mmv.model.License.test.js
M tests/qunit/mmv/ui/mmv.ui.metadataPanel.test.js
M tests/qunit/mmv/ui/mmv.ui.metadataPanelScroller.test.js
22 files changed, 474 insertions(+), 442 deletions(-)
Approvals:
Gilles: Looks good to me, approved
jenkins-bot: Verified
diff --git a/MultimediaViewer.php b/MultimediaViewer.php
index 5822e44..963005c 100644
--- a/MultimediaViewer.php
+++ b/MultimediaViewer.php
@@ -554,7 +554,6 @@
'multimediaviewer-commons-subtitle',
'multimediaviewer-credit',
- 'multimediaviewer-credit-fallback',
'multimediaviewer-userpage-link',
@@ -591,6 +590,8 @@
'multimediaviewer-credit-popup-text',
'multimediaviewer-title-popup-text-more',
'multimediaviewer-credit-popup-text-more',
+ 'multimediaviewer-panel-open-popup-text',
+ 'multimediaviewer-panel-close-popup-text',
),
),
diff --git a/i18n/en.json b/i18n/en.json
index 3b97c13..3e90779 100644
--- a/i18n/en.json
+++ b/i18n/en.json
@@ -1,8 +1,8 @@
{
@metadata: {
- authors: [
- Mark Holmquist mtrac...@member.fsf.org
- ]
+ authors: [
+ Mark Holmquist mtrac...@member.fsf.org
+ ]
},
multimediaviewer-desc: Expand thumbnails in a larger size in a
fullscreen interface.,
multimediaviewer-desc-nil: No description available.,
@@ -15,7 +15,6 @@
multimediaviewer-datetime-uploaded: Uploaded: $1,
multimediaviewer-userpage-link: {{GENDER:$2|Uploaded}} by $1,
multimediaviewer-credit: $1 - $2,
- multimediaviewer-credit-fallback: View author information,
multimediaviewer-metadata-error: Error: Could not load image data.
$1,
multimediaviewer-thumbnail-error: Error: Could not load thumbnail
data. $1,
multimediaviewer-license-cc-by-1.0: CC BY 1.0,
@@ -109,6 +108,8 @@
multimediaviewer-credit-popup-text: Author and source information,
multimediaviewer-title-popup-text-more: Click to show full file
name,
multimediaviewer-credit-popup-text-more: Click to show full author
and source,
+ multimediaviewer-panel-open-popup-text: More details,
+ multimediaviewer-panel-close-popup-text: Fewer details,
multimediaviewer-download-attribution-cta-header: You need to
attribute the author,
multimediaviewer-download-attribution-cta: Show me how,
multimediaviewer-attr-plain: Plain,
diff --git a/i18n/qqq.json b/i18n/qqq.json
index 5c814f9..7b65151 100644
--- a/i18n/qqq.json
+++ b/i18n/qqq.json
@@ -20,8 +20,7 @@
multimediaviewer-datetime-created: Used in JavaScript code.
Parameters:\n* $1 - time and date\nSee also:\n*
{{msg-mw|Multimediaviewer-datetime-uploaded}}\n\nNote that the date comes from
the description page and can have various forms (e.g. \2000-01-01\, \1st
January 2000\, \1492\, \16th century\...)\n\nAlso, this might refer to the
date when the picture was taken, or the date when the depcited work was made -
the usage is not consistent. You should choose a translation that works in all
cases.\n{{Identical|Created}},
multimediaviewer-datetime-uploaded: Used in JavaScript code.
Parameters:\n* $1 - time and date (formatted)\nSee also:\n*
{{msg-mw|Multimediaviewer-datetime-created}}\n{{Identical|Uploaded}},
multimediaviewer-userpage-link: Link to the user page for the
uploader of the image.\n\nUsed in JavaScript code.\n\nParameters:\n* $1 - the
username of the uploader\n* $2 - their gender,
- multimediaviewer-credit: Credit line for images. Parameters:\n* $1 -
HTML describing the author\n* $2 - HTML describing the source\n\nNeither
parameters are usernames, so GENDER is useless. Both come directly from the
API, the
[MediaWiki-commits] [Gerrit] Revert layout changes - change (mediawiki...MultimediaViewer)
Gilles has uploaded a new change for review.
https://gerrit.wikimedia.org/r/170804
Change subject: Revert layout changes
..
Revert layout changes
This reverts several commits that change the layout of
above-the-fold/below-the-fold
Change-Id: I33a76ba9f9f29f9c45f46bc6c03475e0c51f2d09
---
M MultimediaViewer.php
M i18n/en.json
M i18n/qqq.json
M resources/mmv/mmv.globals.less
M resources/mmv/mmv.lightboxinterface.less
M resources/mmv/model/mmv.model.License.js
A resources/mmv/ui/img/drag-active.svg
A resources/mmv/ui/img/drag.svg
D resources/mmv/ui/img/pd.svg
M resources/mmv/ui/img/time.svg
D resources/mmv/ui/img/uploader-ltr.svg
D resources/mmv/ui/img/uploader-rtl.svg
M resources/mmv/ui/mmv.ui.metadataPanel.js
M resources/mmv/ui/mmv.ui.metadataPanel.less
M resources/mmv/ui/mmv.ui.metadataPanelScroller.js
M resources/mmv/ui/mmv.ui.metadataPanelScroller.less
M resources/mmv/ui/mmv.ui.stripeButtons.less
M tests/browser/features/support/pages/e2e_test_page.rb
M tests/qunit/mmv/mmv.lightboxinterface.test.js
M tests/qunit/mmv/model/mmv.model.License.test.js
M tests/qunit/mmv/ui/mmv.ui.metadataPanel.test.js
M tests/qunit/mmv/ui/mmv.ui.metadataPanelScroller.test.js
22 files changed, 474 insertions(+), 442 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MultimediaViewer
refs/changes/04/170804/1
diff --git a/MultimediaViewer.php b/MultimediaViewer.php
index 5822e44..963005c 100644
--- a/MultimediaViewer.php
+++ b/MultimediaViewer.php
@@ -554,7 +554,6 @@
'multimediaviewer-commons-subtitle',
'multimediaviewer-credit',
- 'multimediaviewer-credit-fallback',
'multimediaviewer-userpage-link',
@@ -591,6 +590,8 @@
'multimediaviewer-credit-popup-text',
'multimediaviewer-title-popup-text-more',
'multimediaviewer-credit-popup-text-more',
+ 'multimediaviewer-panel-open-popup-text',
+ 'multimediaviewer-panel-close-popup-text',
),
),
diff --git a/i18n/en.json b/i18n/en.json
index 3b97c13..3e90779 100644
--- a/i18n/en.json
+++ b/i18n/en.json
@@ -1,8 +1,8 @@
{
@metadata: {
- authors: [
- Mark Holmquist mtrac...@member.fsf.org
- ]
+ authors: [
+ Mark Holmquist mtrac...@member.fsf.org
+ ]
},
multimediaviewer-desc: Expand thumbnails in a larger size in a
fullscreen interface.,
multimediaviewer-desc-nil: No description available.,
@@ -15,7 +15,6 @@
multimediaviewer-datetime-uploaded: Uploaded: $1,
multimediaviewer-userpage-link: {{GENDER:$2|Uploaded}} by $1,
multimediaviewer-credit: $1 - $2,
- multimediaviewer-credit-fallback: View author information,
multimediaviewer-metadata-error: Error: Could not load image data.
$1,
multimediaviewer-thumbnail-error: Error: Could not load thumbnail
data. $1,
multimediaviewer-license-cc-by-1.0: CC BY 1.0,
@@ -109,6 +108,8 @@
multimediaviewer-credit-popup-text: Author and source information,
multimediaviewer-title-popup-text-more: Click to show full file
name,
multimediaviewer-credit-popup-text-more: Click to show full author
and source,
+ multimediaviewer-panel-open-popup-text: More details,
+ multimediaviewer-panel-close-popup-text: Fewer details,
multimediaviewer-download-attribution-cta-header: You need to
attribute the author,
multimediaviewer-download-attribution-cta: Show me how,
multimediaviewer-attr-plain: Plain,
diff --git a/i18n/qqq.json b/i18n/qqq.json
index 5c814f9..7b65151 100644
--- a/i18n/qqq.json
+++ b/i18n/qqq.json
@@ -20,8 +20,7 @@
multimediaviewer-datetime-created: Used in JavaScript code.
Parameters:\n* $1 - time and date\nSee also:\n*
{{msg-mw|Multimediaviewer-datetime-uploaded}}\n\nNote that the date comes from
the description page and can have various forms (e.g. \2000-01-01\, \1st
January 2000\, \1492\, \16th century\...)\n\nAlso, this might refer to the
date when the picture was taken, or the date when the depcited work was made -
the usage is not consistent. You should choose a translation that works in all
cases.\n{{Identical|Created}},
multimediaviewer-datetime-uploaded: Used in JavaScript code.
Parameters:\n* $1 - time and date (formatted)\nSee also:\n*
{{msg-mw|Multimediaviewer-datetime-created}}\n{{Identical|Uploaded}},
multimediaviewer-userpage-link: Link to the user page for the
uploader of the image.\n\nUsed in JavaScript code.\n\nParameters:\n* $1 - the
username of the uploader\n* $2 - their gender,
- multimediaviewer-credit: Credit line for images. Parameters:\n* $1 -
HTML describing the author\n* $2 - HTML describing the source\n\nNeither
[MediaWiki-commits] [Gerrit] Revert layout changes - change (mediawiki...MultimediaViewer)
Gilles has uploaded a new change for review.
https://gerrit.wikimedia.org/r/170809
Change subject: Revert layout changes
..
Revert layout changes
This reverts several commits that changed above/below-the-fold
Change-Id: I1594d84eb38c42f3ae2089c99b217fc83874ce6d
---
M MultimediaViewer.php
M i18n/en.json
M resources/mmv/mmv.globals.less
M resources/mmv/mmv.lightboxinterface.less
M resources/mmv/model/mmv.model.License.js
A resources/mmv/ui/img/drag-active.svg
A resources/mmv/ui/img/drag.svg
D resources/mmv/ui/img/pd.svg
M resources/mmv/ui/img/time.svg
D resources/mmv/ui/img/uploader-ltr.svg
D resources/mmv/ui/img/uploader-rtl.svg
M resources/mmv/ui/mmv.ui.metadataPanel.js
M resources/mmv/ui/mmv.ui.metadataPanel.less
M resources/mmv/ui/mmv.ui.metadataPanelScroller.js
M resources/mmv/ui/mmv.ui.metadataPanelScroller.less
M resources/mmv/ui/mmv.ui.stripeButtons.less
M tests/browser/features/support/pages/e2e_test_page.rb
M tests/qunit/mmv/mmv.lightboxinterface.test.js
M tests/qunit/mmv/model/mmv.model.License.test.js
M tests/qunit/mmv/ui/mmv.ui.metadataPanel.test.js
M tests/qunit/mmv/ui/mmv.ui.metadataPanelScroller.test.js
21 files changed, 433 insertions(+), 392 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MultimediaViewer
refs/changes/09/170809/1
diff --git a/MultimediaViewer.php b/MultimediaViewer.php
index 0d200ac..963005c 100644
--- a/MultimediaViewer.php
+++ b/MultimediaViewer.php
@@ -590,6 +590,8 @@
'multimediaviewer-credit-popup-text',
'multimediaviewer-title-popup-text-more',
'multimediaviewer-credit-popup-text-more',
+ 'multimediaviewer-panel-open-popup-text',
+ 'multimediaviewer-panel-close-popup-text',
),
),
diff --git a/i18n/en.json b/i18n/en.json
index 7343d81..3e90779 100644
--- a/i18n/en.json
+++ b/i18n/en.json
@@ -1,8 +1,8 @@
{
@metadata: {
- authors: [
- Mark Holmquist mtrac...@member.fsf.org
- ]
+ authors: [
+ Mark Holmquist mtrac...@member.fsf.org
+ ]
},
multimediaviewer-desc: Expand thumbnails in a larger size in a
fullscreen interface.,
multimediaviewer-desc-nil: No description available.,
@@ -108,6 +108,8 @@
multimediaviewer-credit-popup-text: Author and source information,
multimediaviewer-title-popup-text-more: Click to show full file
name,
multimediaviewer-credit-popup-text-more: Click to show full author
and source,
+ multimediaviewer-panel-open-popup-text: More details,
+ multimediaviewer-panel-close-popup-text: Fewer details,
multimediaviewer-download-attribution-cta-header: You need to
attribute the author,
multimediaviewer-download-attribution-cta: Show me how,
multimediaviewer-attr-plain: Plain,
diff --git a/resources/mmv/mmv.globals.less b/resources/mmv/mmv.globals.less
index 7eb1def..9da7ffe 100644
--- a/resources/mmv/mmv.globals.less
+++ b/resources/mmv/mmv.globals.less
@@ -1,12 +1,8 @@
// Height of the area of the metadata bar which is visible without scrolling.
-@metadatabar-above-fold-height: 86px;
+@metadatabar-above-fold-height: 82px;
-// adjust for @metadatabar-below-fold-pushup-height wide bottom padding - that
area will be overlapped
-// by the revealed part of the below-the-fold content
-@metadatabar-above-fold-inner-height: @metadatabar-above-fold-height -
@metadatabar-below-fold-pushup-height;
-
-// Height of the top part of the below-fold content which is actually above
the fold, as a scrolling affordance
-@metadatabar-below-fold-pushup-height: 30px;
+// Height of the same area in fullscreen mode (which can be slightly less
since it has less controls).
+@metadatabar-above-fold-fullscreen-height: 64px;
// Height of the progress bar
@progress-bar-height: 14px;
diff --git a/resources/mmv/mmv.lightboxinterface.less
b/resources/mmv/mmv.lightboxinterface.less
index 15d38ff..40690af 100644
--- a/resources/mmv/mmv.lightboxinterface.less
+++ b/resources/mmv/mmv.lightboxinterface.less
@@ -56,21 +56,25 @@
height: auto;
color: #33;
background-color: #ff;
- min-height: (@metadatabar-above-fold-inner-height + 1);
+ min-height: (@metadatabar-above-fold-height + 1);
z-index: 1005;
}
// above-the-fold part of the metadata panel
.mw-mmv-above-fold {
width: 100%;
- height: @metadatabar-above-fold-inner-height;
+ height: @metadatabar-above-fold-height;
// min-height is used when the height is changed to auto to display
long texts, to make sure the layout
// is not messed up wheen the text is short and does not fill the
available place. It is also used by
// Javascript to get the default height.
- min-height:
[MediaWiki-commits] [Gerrit] Revert layout changes - change (mediawiki...MultimediaViewer)
jenkins-bot has submitted this change and it was merged.
Change subject: Revert layout changes
..
Revert layout changes
This reverts several commits that changed above/below-the-fold
Change-Id: I1594d84eb38c42f3ae2089c99b217fc83874ce6d
---
M MultimediaViewer.php
M i18n/en.json
M resources/mmv/mmv.globals.less
M resources/mmv/mmv.lightboxinterface.less
M resources/mmv/model/mmv.model.License.js
A resources/mmv/ui/img/drag-active.svg
A resources/mmv/ui/img/drag.svg
D resources/mmv/ui/img/pd.svg
M resources/mmv/ui/img/time.svg
D resources/mmv/ui/img/uploader-ltr.svg
D resources/mmv/ui/img/uploader-rtl.svg
M resources/mmv/ui/mmv.ui.metadataPanel.js
M resources/mmv/ui/mmv.ui.metadataPanel.less
M resources/mmv/ui/mmv.ui.metadataPanelScroller.js
M resources/mmv/ui/mmv.ui.metadataPanelScroller.less
M resources/mmv/ui/mmv.ui.stripeButtons.less
M tests/browser/features/support/pages/e2e_test_page.rb
M tests/qunit/mmv/mmv.lightboxinterface.test.js
M tests/qunit/mmv/model/mmv.model.License.test.js
M tests/qunit/mmv/ui/mmv.ui.metadataPanel.test.js
M tests/qunit/mmv/ui/mmv.ui.metadataPanelScroller.test.js
21 files changed, 433 insertions(+), 392 deletions(-)
Approvals:
Gilles: Looks good to me, approved
jenkins-bot: Verified
diff --git a/MultimediaViewer.php b/MultimediaViewer.php
index 0d200ac..963005c 100644
--- a/MultimediaViewer.php
+++ b/MultimediaViewer.php
@@ -590,6 +590,8 @@
'multimediaviewer-credit-popup-text',
'multimediaviewer-title-popup-text-more',
'multimediaviewer-credit-popup-text-more',
+ 'multimediaviewer-panel-open-popup-text',
+ 'multimediaviewer-panel-close-popup-text',
),
),
diff --git a/i18n/en.json b/i18n/en.json
index 7343d81..3e90779 100644
--- a/i18n/en.json
+++ b/i18n/en.json
@@ -1,8 +1,8 @@
{
@metadata: {
- authors: [
- Mark Holmquist mtrac...@member.fsf.org
- ]
+ authors: [
+ Mark Holmquist mtrac...@member.fsf.org
+ ]
},
multimediaviewer-desc: Expand thumbnails in a larger size in a
fullscreen interface.,
multimediaviewer-desc-nil: No description available.,
@@ -108,6 +108,8 @@
multimediaviewer-credit-popup-text: Author and source information,
multimediaviewer-title-popup-text-more: Click to show full file
name,
multimediaviewer-credit-popup-text-more: Click to show full author
and source,
+ multimediaviewer-panel-open-popup-text: More details,
+ multimediaviewer-panel-close-popup-text: Fewer details,
multimediaviewer-download-attribution-cta-header: You need to
attribute the author,
multimediaviewer-download-attribution-cta: Show me how,
multimediaviewer-attr-plain: Plain,
diff --git a/resources/mmv/mmv.globals.less b/resources/mmv/mmv.globals.less
index 7eb1def..9da7ffe 100644
--- a/resources/mmv/mmv.globals.less
+++ b/resources/mmv/mmv.globals.less
@@ -1,12 +1,8 @@
// Height of the area of the metadata bar which is visible without scrolling.
-@metadatabar-above-fold-height: 86px;
+@metadatabar-above-fold-height: 82px;
-// adjust for @metadatabar-below-fold-pushup-height wide bottom padding - that
area will be overlapped
-// by the revealed part of the below-the-fold content
-@metadatabar-above-fold-inner-height: @metadatabar-above-fold-height -
@metadatabar-below-fold-pushup-height;
-
-// Height of the top part of the below-fold content which is actually above
the fold, as a scrolling affordance
-@metadatabar-below-fold-pushup-height: 30px;
+// Height of the same area in fullscreen mode (which can be slightly less
since it has less controls).
+@metadatabar-above-fold-fullscreen-height: 64px;
// Height of the progress bar
@progress-bar-height: 14px;
diff --git a/resources/mmv/mmv.lightboxinterface.less
b/resources/mmv/mmv.lightboxinterface.less
index 15d38ff..40690af 100644
--- a/resources/mmv/mmv.lightboxinterface.less
+++ b/resources/mmv/mmv.lightboxinterface.less
@@ -56,21 +56,25 @@
height: auto;
color: #33;
background-color: #ff;
- min-height: (@metadatabar-above-fold-inner-height + 1);
+ min-height: (@metadatabar-above-fold-height + 1);
z-index: 1005;
}
// above-the-fold part of the metadata panel
.mw-mmv-above-fold {
width: 100%;
- height: @metadatabar-above-fold-inner-height;
+ height: @metadatabar-above-fold-height;
// min-height is used when the height is changed to auto to display
long texts, to make sure the layout
// is not messed up wheen the text is short and does not fill the
available place. It is also used by
// Javascript to get the default height.
- min-height: @metadatabar-above-fold-inner-height;
+ min-height: @metadatabar-above-fold-height;
