[MediaWiki-commits] [Gerrit] Send 404 to rt clients when there aren't any more pages to test - change (mediawiki...parsoid)

2014-03-04 Thread Marcoil (Code Review) 
Marcoil has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/116764

Change subject: Send 404 to rt clients when there aren't any more pages to test
..

Send 404 to rt clients when there aren't any more pages to test

Change-Id: Ie8ccab3fe34ff61a577dde620c84f69a14d055a6
---
M tests/server/server.js
1 file changed, 3 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/services/parsoid 
refs/changes/64/116764/1

diff --git a/tests/server/server.js b/tests/server/server.js
index e1a8e4e..8b5ee33 100755
--- a/tests/server/server.js
+++ b/tests/server/server.js
@@ -598,7 +598,9 @@
fetchedPages = fetchedPages.concat( newPages );
}
if ( fetchedPages.length === 0 ) {
-   res.send( 'No available titles that fit the 
constraints.', 200 );
+   // Send 404 to indicate no pages available now, clients 
depend on
+   // this.
+   res.send( 'No available titles that fit the 
constraints.', 404 );
} else {
var page = fetchedPages.pop();
 

-- 
To view, visit https://gerrit.wikimedia.org/r/116764
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie8ccab3fe34ff61a577dde620c84f69a14d055a6
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/parsoid
Gerrit-Branch: master
Gerrit-Owner: Marcoil 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Send 404 to rt clients when there aren't any more pages to test - change (mediawiki...parsoid)

2014-03-04 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Send 404 to rt clients when there aren't any more pages to test
..


Send 404 to rt clients when there aren't any more pages to test

Change-Id: Ie8ccab3fe34ff61a577dde620c84f69a14d055a6
---
M tests/server/server.js
1 file changed, 3 insertions(+), 1 deletion(-)

Approvals:
  Subramanya Sastry: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/tests/server/server.js b/tests/server/server.js
index e1a8e4e..8b5ee33 100755
--- a/tests/server/server.js
+++ b/tests/server/server.js
@@ -598,7 +598,9 @@
fetchedPages = fetchedPages.concat( newPages );
}
if ( fetchedPages.length === 0 ) {
-   res.send( 'No available titles that fit the 
constraints.', 200 );
+   // Send 404 to indicate no pages available now, clients 
depend on
+   // this.
+   res.send( 'No available titles that fit the 
constraints.', 404 );
} else {
var page = fetchedPages.pop();
 

-- 
To view, visit https://gerrit.wikimedia.org/r/116764
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie8ccab3fe34ff61a577dde620c84f69a14d055a6
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/parsoid
Gerrit-Branch: master
Gerrit-Owner: Marcoil 
Gerrit-Reviewer: GWicke 
Gerrit-Reviewer: Subramanya Sastry 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits