[MediaWiki-commits] [Gerrit] Separate message for Summary field with 4 tildes - change (mediawiki...LiquidThreads)
jenkins-bot has submitted this change and it was merged.
Change subject: Separate message for Summary field with 4 tildes
..
Separate message for Summary field with 4 tildes
Bug: T45496
Change-Id: I23adc3112be6a086d012b38cb3d6fb2a984958bc
---
M LiquidThreads.php
M i18n/en.json
M i18n/qqq.json
M lqt.js
4 files changed, 12 insertions(+), 3 deletions(-)
Approvals:
Nikerabbit: Looks good to me, approved
jenkins-bot: Verified
diff --git a/LiquidThreads.php b/LiquidThreads.php
index ac3aeea..594d1e4 100644
--- a/LiquidThreads.php
+++ b/LiquidThreads.php
@@ -36,6 +36,7 @@
'lqt-thread-link-title',
'lqt-thread-link-copy',
'lqt-sign-not-necessary',
+ 'lqt-summary-sign-not-necessary',
'lqt-marked-as-read-placeholder',
'lqt-email-undo',
'lqt-change-subject',
diff --git a/i18n/en.json b/i18n/en.json
index 5d9a00e..29dbeb4 100644
--- a/i18n/en.json
+++ b/i18n/en.json
@@ -185,7 +185,8 @@
"lqt-thread-link-url": "Link URL:",
"lqt-thread-link-title": "Wikitext link:",
"lqt-thread-link-copy": "Copy to clipboard",
- "lqt-sign-not-necessary": "It is not necessary to sign your post with
four tildes.\nThe signature is shown automatically.",
+ "lqt-sign-not-necessary": "{{int:lqt-summary-sign-not-necessary}}\nThe
signature is shown automatically.",
+ "lqt-summary-sign-not-necessary": "It is not necessary to sign your
post with four tildes.",
"lqt-marked-as-read-placeholder": "The thread $1 was marked as read.",
"lqt-change-subject": "Change subject",
"lqt-save-subject": "Save",
diff --git a/i18n/qqq.json b/i18n/qqq.json
index c59b281..7dfc93b 100644
--- a/i18n/qqq.json
+++ b/i18n/qqq.json
@@ -211,6 +211,7 @@
"lqt-edit-bump": "See {{msg-mw|Lqt-edit-bump-tooltip}} for the
explanation of this feature.",
"lqt-reply-subpage": "Part of the page title when a LiquidThread answer
is given. Should probably be translated as a noun and not as a
verb.\n\n{{Identical|Reply}}",
"lqt-pagechange-editformopen": "Shown as a JavaScript confirmation
dialog to the user when they try to leave the page while an LQT editing form is
open.",
+ "lqt-summary-sign-not-necessary": "Message shown when the Summary field
has 4 tildes.",
"nstab-thread": "Used as tab title of the Thread
namespace.\n{{Identical|Thread}}",
"nstab-summary": "Used as tab title for the Summary
namespace.\n{{Identical|Summary}}",
"echo-pref-email-lqt-new-topic": "Used by the Echo extension in the
Preferences -> Notifications tab as a label to enable email notification for
the lqt-new-topic event.",
diff --git a/lqt.js b/lqt.js
index f5114c1..f1d9176 100644
--- a/lqt.js
+++ b/lqt.js
@@ -1110,8 +1110,14 @@
}
// Show the warning
- var elem = $( '' ).attr( { 'id':
'lqt-sign-warning', 'class': 'error' } ).text( mw.msg( 'lqt-sign-not-necessary'
) ),
- $weTop = $( this ).closest( '.lqt-edit-form'
).find( '.wikiEditor-ui-top' );
+ var $weLqtSummaryTop = $( this ).closest(
'.lqt-summarize-form' ), elem, msg, $weTop;
+ if ( $weLqtSummaryTop.length ) {
+ msg = mw.msg( 'lqt-summary-sign-not-necessary'
);
+ } else {
+ msg = mw.msg( 'lqt-sign-not-necessary' );
+ }
+ elem = $( '' ).attr( { 'id': 'lqt-sign-warning',
'class': 'error' } ).text( msg );
+ $weTop = $( this ).closest( '.lqt-edit-form' ).find(
'.wikiEditor-ui-top' );
if ( $weTop.length ) {
$weTop.before( elem );
--
To view, visit https://gerrit.wikimedia.org/r/182757
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I23adc3112be6a086d012b38cb3d6fb2a984958bc
Gerrit-PatchSet: 5
Gerrit-Project: mediawiki/extensions/LiquidThreads
Gerrit-Branch: master
Gerrit-Owner: Phoenix303
Gerrit-Reviewer: Alex Monk
Gerrit-Reviewer: Nemo bis
Gerrit-Reviewer: Nikerabbit
Gerrit-Reviewer: Siebrand
Gerrit-Reviewer: jenkins-bot <>
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Separate message for Summary field with 4 tildes - change (mediawiki...LiquidThreads)
Phoenix303 has uploaded a new change for review.
https://gerrit.wikimedia.org/r/182761
Change subject: Separate message for Summary field with 4 tildes
..
Separate message for Summary field with 4 tildes
Bug: T45496
Change-Id: I8e044d35f3dcdcd4d49dc8755f34d2bae44f030f
---
M LiquidThreads.php
M i18n/en.json
M i18n/qqq.json
M lqt.js
4 files changed, 10 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/LiquidThreads
refs/changes/61/182761/1
diff --git a/LiquidThreads.php b/LiquidThreads.php
index 076472a..f61e553 100644
--- a/LiquidThreads.php
+++ b/LiquidThreads.php
@@ -38,6 +38,7 @@
'lqt-thread-link-title',
'lqt-thread-link-copy',
'lqt-sign-not-necessary',
+ 'lqt-summary-sign-not-necessary',
'lqt-marked-as-read-placeholder',
'lqt-email-undo',
'lqt-change-subject',
diff --git a/i18n/en.json b/i18n/en.json
index 5d9a00e..804b01b 100644
--- a/i18n/en.json
+++ b/i18n/en.json
@@ -186,6 +186,7 @@
"lqt-thread-link-title": "Wikitext link:",
"lqt-thread-link-copy": "Copy to clipboard",
"lqt-sign-not-necessary": "It is not necessary to sign your post with
four tildes.\nThe signature is shown automatically.",
+ "lqt-summary-sign-not-necessary": "It is not necessary to sign your
post with four tildes.",
"lqt-marked-as-read-placeholder": "The thread $1 was marked as read.",
"lqt-change-subject": "Change subject",
"lqt-save-subject": "Save",
diff --git a/i18n/qqq.json b/i18n/qqq.json
index 8d11a89..a67e5d0 100644
--- a/i18n/qqq.json
+++ b/i18n/qqq.json
@@ -210,6 +210,7 @@
"lqt-edit-bump": "See {{msg-mw|Lqt-edit-bump-tooltip}} for the
explanation of this feature.",
"lqt-reply-subpage": "Part of the page title when a LiquidThread answer
is given. Should probably be translated as a noun and not as a
verb.\n\n{{Identical|Reply}}",
"lqt-pagechange-editformopen": "Shown as a JavaScript confirmation
dialog to the user when they try to leave the page while an LQT editing form is
open.",
+ "lqt-summary-sign-not-necessary": "Message shown when Summary field has
4 tildes.",
"nstab-thread": "Used as tab title of the Thread
namespace.\n{{Identical|Thread}}",
"nstab-summary": "Used as tab title for the Summary
namespace.\n{{Identical|Summary}}",
"echo-pref-email-lqt-new-topic": "Used by the Echo extension in the
Preferences -> Notifications tab as a label to enable email notification for
the lqt-new-topic event.",
diff --git a/lqt.js b/lqt.js
index f5114c1..2a0a693 100644
--- a/lqt.js
+++ b/lqt.js
@@ -1110,8 +1110,13 @@
}
// Show the warning
- var elem = $( '' ).attr( { 'id':
'lqt-sign-warning', 'class': 'error' } ).text( mw.msg( 'lqt-sign-not-necessary'
) ),
- $weTop = $( this ).closest( '.lqt-edit-form'
).find( '.wikiEditor-ui-top' );
+ var $weLqtSummaryTop = $( this ).closest(
'.lqt-summarize-form' );
+ if ( $weLqtSummaryTop.length ) {
+var elem = $( '' ).attr( { 'id':
'lqt-sign-warning', 'class': 'error' } ).text( mw.msg(
'lqt-summary-sign-not-necessary' ) );
+ } else {
+var elem = $( '' ).attr( { 'id':
'lqt-sign-warning', 'class': 'error' } ).text( mw.msg( 'lqt-sign-not-necessary'
) );
+ }
+ var $weTop = $( this ).closest( '.lqt-edit-form'
).find( '.wikiEditor-ui-top' );
if ( $weTop.length ) {
$weTop.before( elem );
--
To view, visit https://gerrit.wikimedia.org/r/182761
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8e044d35f3dcdcd4d49dc8755f34d2bae44f030f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/LiquidThreads
Gerrit-Branch: master
Gerrit-Owner: Phoenix303
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Separate message for Summary field with 4 tildes - change (mediawiki...LiquidThreads)
Phoenix303 has uploaded a new change for review.
https://gerrit.wikimedia.org/r/182758
Change subject: Separate message for Summary field with 4 tildes
..
Separate message for Summary field with 4 tildes
Bug: T45496
Change-Id: I4681e1fa99bbd79f1bcd51c60415252973e7b038
---
M i18n/qqq.json
M lqt.js
2 files changed, 3 insertions(+), 4 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/LiquidThreads
refs/changes/58/182758/1
diff --git a/i18n/qqq.json b/i18n/qqq.json
index 8d11a89..a67e5d0 100644
--- a/i18n/qqq.json
+++ b/i18n/qqq.json
@@ -210,6 +210,7 @@
"lqt-edit-bump": "See {{msg-mw|Lqt-edit-bump-tooltip}} for the
explanation of this feature.",
"lqt-reply-subpage": "Part of the page title when a LiquidThread answer
is given. Should probably be translated as a noun and not as a
verb.\n\n{{Identical|Reply}}",
"lqt-pagechange-editformopen": "Shown as a JavaScript confirmation
dialog to the user when they try to leave the page while an LQT editing form is
open.",
+ "lqt-summary-sign-not-necessary": "Message shown when Summary field has
4 tildes.",
"nstab-thread": "Used as tab title of the Thread
namespace.\n{{Identical|Thread}}",
"nstab-summary": "Used as tab title for the Summary
namespace.\n{{Identical|Summary}}",
"echo-pref-email-lqt-new-topic": "Used by the Echo extension in the
Preferences -> Notifications tab as a label to enable email notification for
the lqt-new-topic event.",
diff --git a/lqt.js b/lqt.js
index 385baca..430106f 100644
--- a/lqt.js
+++ b/lqt.js
@@ -1110,15 +1110,13 @@
}
// Show the warning
- $weLqtSummaryTop = $( this ).closest(
'.lqt-summarize-form' );
-
+ var $weLqtSummaryTop = $( this ).closest(
'.lqt-summarize-form' );
if ( $weLqtSummaryTop.length ) {
var elem = $( '' ).attr( { 'id':
'lqt-sign-warning', 'class': 'error' } ).text( mw.msg(
'lqt-summary-sign-not-necessary' ) );
} else {
var elem = $( '' ).attr( { 'id':
'lqt-sign-warning', 'class': 'error' } ).text( mw.msg( 'lqt-sign-not-necessary'
) );
}
-
- $weTop = $( this ).closest( '.lqt-edit-form'
).find( '.wikiEditor-ui-top' );
+ var $weTop = $( this ).closest( '.lqt-edit-form'
).find( '.wikiEditor-ui-top' );
if ( $weTop.length ) {
$weTop.before( elem );
--
To view, visit https://gerrit.wikimedia.org/r/182758
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4681e1fa99bbd79f1bcd51c60415252973e7b038
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/LiquidThreads
Gerrit-Branch: master
Gerrit-Owner: Phoenix303
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Separate message for Summary field with 4 tildes - change (mediawiki...LiquidThreads)
Phoenix303 has uploaded a new change for review.
https://gerrit.wikimedia.org/r/182757
Change subject: Separate message for Summary field with 4 tildes
..
Separate message for Summary field with 4 tildes
Bug: T45496
Change-Id: I23adc3112be6a086d012b38cb3d6fb2a984958bc
---
M LiquidThreads.php
M i18n/en.json
M lqt.js
3 files changed, 10 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/LiquidThreads
refs/changes/57/182757/1
diff --git a/LiquidThreads.php b/LiquidThreads.php
index 076472a..f61e553 100644
--- a/LiquidThreads.php
+++ b/LiquidThreads.php
@@ -38,6 +38,7 @@
'lqt-thread-link-title',
'lqt-thread-link-copy',
'lqt-sign-not-necessary',
+ 'lqt-summary-sign-not-necessary',
'lqt-marked-as-read-placeholder',
'lqt-email-undo',
'lqt-change-subject',
diff --git a/i18n/en.json b/i18n/en.json
index 5d9a00e..804b01b 100644
--- a/i18n/en.json
+++ b/i18n/en.json
@@ -186,6 +186,7 @@
"lqt-thread-link-title": "Wikitext link:",
"lqt-thread-link-copy": "Copy to clipboard",
"lqt-sign-not-necessary": "It is not necessary to sign your post with
four tildes.\nThe signature is shown automatically.",
+ "lqt-summary-sign-not-necessary": "It is not necessary to sign your
post with four tildes.",
"lqt-marked-as-read-placeholder": "The thread $1 was marked as read.",
"lqt-change-subject": "Change subject",
"lqt-save-subject": "Save",
diff --git a/lqt.js b/lqt.js
index f5114c1..385baca 100644
--- a/lqt.js
+++ b/lqt.js
@@ -1110,7 +1110,14 @@
}
// Show the warning
- var elem = $( '' ).attr( { 'id':
'lqt-sign-warning', 'class': 'error' } ).text( mw.msg( 'lqt-sign-not-necessary'
) ),
+ $weLqtSummaryTop = $( this ).closest(
'.lqt-summarize-form' );
+
+if ( $weLqtSummaryTop.length ) {
+var elem = $( '' ).attr( { 'id':
'lqt-sign-warning', 'class': 'error' } ).text( mw.msg(
'lqt-summary-sign-not-necessary' ) );
+ } else {
+var elem = $( '' ).attr( { 'id':
'lqt-sign-warning', 'class': 'error' } ).text( mw.msg( 'lqt-sign-not-necessary'
) );
+ }
+
$weTop = $( this ).closest( '.lqt-edit-form'
).find( '.wikiEditor-ui-top' );
if ( $weTop.length ) {
--
To view, visit https://gerrit.wikimedia.org/r/182757
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I23adc3112be6a086d012b38cb3d6fb2a984958bc
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/LiquidThreads
Gerrit-Branch: master
Gerrit-Owner: Phoenix303
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
