[MediaWiki-commits] [Gerrit] Set panels after everything is initialized in media dialog - change (mediawiki...VisualEditor)

2014-12-01 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Set panels after everything is initialized in media dialog
..


Set panels after everything is initialized in media dialog

Only change the panels (and focus the caption surface) after the
surface is actually appended and initialized.

Bug: T76074
Change-Id: I3d514f38b5fd9f794c4ff8c44a64f5f3475a84bd
---
M modules/ve-mw/ui/dialogs/ve.ui.MWMediaDialog.js
1 file changed, 1 insertion(+), 2 deletions(-)

Approvals:
  Catrope: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/modules/ve-mw/ui/dialogs/ve.ui.MWMediaDialog.js 
b/modules/ve-mw/ui/dialogs/ve.ui.MWMediaDialog.js
index e6f9f46..f36ca9b 100644
--- a/modules/ve-mw/ui/dialogs/ve.ui.MWMediaDialog.js
+++ b/modules/ve-mw/ui/dialogs/ve.ui.MWMediaDialog.js
@@ -632,14 +632,13 @@
 
this.resetCaption();
 
-   this.switchPanels( this.selectedNode ? 'edit' : 
'search' );
-
this.actions.setAbilities( { insert: false, apply: 
false } );
 
// Initialization
this.captionFieldset.$element.append( 
this.captionSurface.$element );
this.captionSurface.initialize();
 
+   this.switchPanels( this.selectedNode ? 'edit' : 
'search' );
}, this );
 };
 

-- 
To view, visit https://gerrit.wikimedia.org/r/176197
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3d514f38b5fd9f794c4ff8c44a64f5f3475a84bd
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Mooeypoo mor...@gmail.com
Gerrit-Reviewer: Catrope roan.katt...@gmail.com
Gerrit-Reviewer: Jforrester jforres...@wikimedia.org
Gerrit-Reviewer: jenkins-bot 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Set panels after everything is initialized in media dialog - change (mediawiki...VisualEditor)

2014-12-01 Thread Jforrester (Code Review) 
Jforrester has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/176704

Change subject: Set panels after everything is initialized in media dialog
..

Set panels after everything is initialized in media dialog

Only change the panels (and focus the caption surface) after the
surface is actually appended and initialized.

Bug: T76074
Change-Id: I3d514f38b5fd9f794c4ff8c44a64f5f3475a84bd
(cherry picked from commit 78b86cd72da1b16994edb86096dc58a332da3b5e)
---
M modules/ve-mw/ui/dialogs/ve.ui.MWMediaDialog.js
1 file changed, 1 insertion(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor 
refs/changes/04/176704/1

diff --git a/modules/ve-mw/ui/dialogs/ve.ui.MWMediaDialog.js 
b/modules/ve-mw/ui/dialogs/ve.ui.MWMediaDialog.js
index e6f9f46..f36ca9b 100644
--- a/modules/ve-mw/ui/dialogs/ve.ui.MWMediaDialog.js
+++ b/modules/ve-mw/ui/dialogs/ve.ui.MWMediaDialog.js
@@ -632,14 +632,13 @@
 
this.resetCaption();
 
-   this.switchPanels( this.selectedNode ? 'edit' : 
'search' );
-
this.actions.setAbilities( { insert: false, apply: 
false } );
 
// Initialization
this.captionFieldset.$element.append( 
this.captionSurface.$element );
this.captionSurface.initialize();
 
+   this.switchPanels( this.selectedNode ? 'edit' : 
'search' );
}, this );
 };
 

-- 
To view, visit https://gerrit.wikimedia.org/r/176704
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3d514f38b5fd9f794c4ff8c44a64f5f3475a84bd
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: wmf/1.25wmf10
Gerrit-Owner: Jforrester jforres...@wikimedia.org
Gerrit-Reviewer: Mooeypoo mor...@gmail.com

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Set panels after everything is initialized in media dialog - change (mediawiki...VisualEditor)

2014-12-01 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Set panels after everything is initialized in media dialog
..


Set panels after everything is initialized in media dialog

Only change the panels (and focus the caption surface) after the
surface is actually appended and initialized.

Bug: T76074
Change-Id: I3d514f38b5fd9f794c4ff8c44a64f5f3475a84bd
(cherry picked from commit 78b86cd72da1b16994edb86096dc58a332da3b5e)
---
M modules/ve-mw/ui/dialogs/ve.ui.MWMediaDialog.js
1 file changed, 1 insertion(+), 2 deletions(-)

Approvals:
  Catrope: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/modules/ve-mw/ui/dialogs/ve.ui.MWMediaDialog.js 
b/modules/ve-mw/ui/dialogs/ve.ui.MWMediaDialog.js
index e6f9f46..f36ca9b 100644
--- a/modules/ve-mw/ui/dialogs/ve.ui.MWMediaDialog.js
+++ b/modules/ve-mw/ui/dialogs/ve.ui.MWMediaDialog.js
@@ -632,14 +632,13 @@
 
this.resetCaption();
 
-   this.switchPanels( this.selectedNode ? 'edit' : 
'search' );
-
this.actions.setAbilities( { insert: false, apply: 
false } );
 
// Initialization
this.captionFieldset.$element.append( 
this.captionSurface.$element );
this.captionSurface.initialize();
 
+   this.switchPanels( this.selectedNode ? 'edit' : 
'search' );
}, this );
 };
 

-- 
To view, visit https://gerrit.wikimedia.org/r/176704
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3d514f38b5fd9f794c4ff8c44a64f5f3475a84bd
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: wmf/1.25wmf10
Gerrit-Owner: Jforrester jforres...@wikimedia.org
Gerrit-Reviewer: Catrope roan.katt...@gmail.com
Gerrit-Reviewer: Mooeypoo mor...@gmail.com
Gerrit-Reviewer: jenkins-bot 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Set panels after everything is initialized in media dialog - change (mediawiki...VisualEditor)

2014-11-26 Thread Mooeypoo (Code Review) 
Mooeypoo has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/176197

Change subject: Set panels after everything is initialized in media dialog
..

Set panels after everything is initialized in media dialog

Only change the panels (and focus the caption surface) after the
surface is actually appended and initialized.

Bug: T76074
Change-Id: I3d514f38b5fd9f794c4ff8c44a64f5f3475a84bd
---
M modules/ve-mw/ui/dialogs/ve.ui.MWMediaDialog.js
1 file changed, 1 insertion(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor 
refs/changes/97/176197/1

diff --git a/modules/ve-mw/ui/dialogs/ve.ui.MWMediaDialog.js 
b/modules/ve-mw/ui/dialogs/ve.ui.MWMediaDialog.js
index e6f9f46..f36ca9b 100644
--- a/modules/ve-mw/ui/dialogs/ve.ui.MWMediaDialog.js
+++ b/modules/ve-mw/ui/dialogs/ve.ui.MWMediaDialog.js
@@ -632,14 +632,13 @@
 
this.resetCaption();
 
-   this.switchPanels( this.selectedNode ? 'edit' : 
'search' );
-
this.actions.setAbilities( { insert: false, apply: 
false } );
 
// Initialization
this.captionFieldset.$element.append( 
this.captionSurface.$element );
this.captionSurface.initialize();
 
+   this.switchPanels( this.selectedNode ? 'edit' : 
'search' );
}, this );
 };
 

-- 
To view, visit https://gerrit.wikimedia.org/r/176197
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3d514f38b5fd9f794c4ff8c44a64f5f3475a84bd
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Mooeypoo mor...@gmail.com

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits