[MediaWiki-commits] [Gerrit] Set req.hash_ignore_busy = true for PURGE requests - change (operations/puppet)

2013-08-16 Thread BBlack (Code Review) 
BBlack has submitted this change and it was merged.

Change subject: Set req.hash_ignore_busy = true for PURGE requests
..


Set req.hash_ignore_busy = true for PURGE requests

PURGE requests should never wait for busy objects to finish a fetch.
I suspect this may be the reason why some PURGE requests take a long
time.

Change-Id: I77d54b5826237228e0d6847743d3d1c0770f29c8
---
M modules/varnish/templates/vcl/wikimedia.vcl.erb
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  BBlack: Verified; Looks good to me, approved
  jenkins-bot: Verified



diff --git a/modules/varnish/templates/vcl/wikimedia.vcl.erb 
b/modules/varnish/templates/vcl/wikimedia.vcl.erb
index b8f77fb..ad4a34b 100644
--- a/modules/varnish/templates/vcl/wikimedia.vcl.erb
+++ b/modules/varnish/templates/vcl/wikimedia.vcl.erb
@@ -180,6 +180,7 @@
if (!client.ip ~ purge) {
error 405 "Denied.";
} elsif (req.http.Host ~ "<%= 
vcl_config.fetch("purge_host_regex", ".*") %>") {
+   set req.hash_ignore_busy = true;
return (lookup);
} else {
error 204 "Domain not cached here.";

-- 
To view, visit https://gerrit.wikimedia.org/r/79322
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I77d54b5826237228e0d6847743d3d1c0770f29c8
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Mark Bergsma 
Gerrit-Reviewer: BBlack 
Gerrit-Reviewer: Faidon 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Set req.hash_ignore_busy = true for PURGE requests - change (operations/puppet)

2013-08-16 Thread Mark Bergsma (Code Review) 
Mark Bergsma has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/79322


Change subject: Set req.hash_ignore_busy = true for PURGE requests
..

Set req.hash_ignore_busy = true for PURGE requests

PURGE requests should never wait for busy objects to finish a fetch.
I suspect this may be the reason why some PURGE requests take a long
time.

Change-Id: I77d54b5826237228e0d6847743d3d1c0770f29c8
---
M modules/varnish/templates/vcl/wikimedia.vcl.erb
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/22/79322/1

diff --git a/modules/varnish/templates/vcl/wikimedia.vcl.erb 
b/modules/varnish/templates/vcl/wikimedia.vcl.erb
index b8f77fb..ad4a34b 100644
--- a/modules/varnish/templates/vcl/wikimedia.vcl.erb
+++ b/modules/varnish/templates/vcl/wikimedia.vcl.erb
@@ -180,6 +180,7 @@
if (!client.ip ~ purge) {
error 405 "Denied.";
} elsif (req.http.Host ~ "<%= 
vcl_config.fetch("purge_host_regex", ".*") %>") {
+   set req.hash_ignore_busy = true;
return (lookup);
} else {
error 204 "Domain not cached here.";

-- 
To view, visit https://gerrit.wikimedia.org/r/79322
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I77d54b5826237228e0d6847743d3d1c0770f29c8
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Mark Bergsma 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits