[MediaWiki-commits] [Gerrit] Several CSS improvements - change (mediawiki...erudite)
jenkins-bot has submitted this change and it was merged.
Change subject: Several CSS improvements
..
Several CSS improvements
- Use thin instead of 1px for border-width
- Ensure site name isn't underlined if hovered
- Use em rather than px even around images
- Hide colon in categories section at the bottom of pages
- Remove unneeded !important entries
Change-Id: Iad9ebed78525e75d4d61bdef0884efdb2c338bcd
---
M assets/erudite.css
1 file changed, 22 insertions(+), 24 deletions(-)
Approvals:
Njw: Looks good to me, approved
jenkins-bot: Verified
diff --git a/assets/erudite.css b/assets/erudite.css
index 9e19a18..aedff6d 100644
--- a/assets/erudite.css
+++ b/assets/erudite.css
@@ -146,6 +146,7 @@
#header a {
color: #ff;
+ text-decoration: none;
}
#siteSubtitle {
@@ -158,7 +159,7 @@
margin: 1.5em 0 -0.625em;
overflow: hidden;
padding: 0.75em 2em 0.75em 3.75em;
- border-top: 1px solid #66;
+ border-top: thin solid #66;
background: #33;
background: rgba(50, 50, 50, 0.7);
}
@@ -206,7 +207,7 @@
}
.footer h3 {
- border-bottom: 1px solid #66;
+ border-bottom: thin solid #66;
margin-bottom: 0.2em;
font-size: 1.25em;
text-transform: uppercase;
@@ -217,7 +218,7 @@
.footer a.new {
color: #ff;
text-decoration: none;
- border-bottom: 1px solid #99;
+ border-bottom: thin solid #99;
}
.footer a:hover,
@@ -253,11 +254,9 @@
hr {
/* @embed */
background: url(images/hr.png) center no-repeat;
- height: 24px;
- margin: 0 0 10px;
+ height: 1.5em;
display: block;
- border-width: 0px;
- border-style: none !important;
+ border: none;
}
.entry-title {
@@ -309,7 +308,7 @@
/* Main Links */
.entry-content a {
- border-bottom: 1px solid #aa;
+ border-bottom: thin solid #aa;
}
.entry-content a:hover {
@@ -323,7 +322,7 @@
padding-left: 1em;
margin-left: 1em;
margin-bottom: 0.625em;
- border-left: 1px solid #aa;
+ border-left: thin solid #aa;
}
.entry-meta span {
@@ -368,8 +367,8 @@
/* Images */
.entry-content img {
- padding: 4px;
- margin-bottom: 6px;
+ padding: 0.25em;
+ margin-bottom: 0.5em;
}
.entry-content .gallery a {
@@ -408,8 +407,8 @@
}
div.thumbinner {
- border: 1px solid #cc;
- padding: 3px !important;
+ border: thin solid #cc;
+ padding: 0.2em;
background-color: #f9f9f9;
font-size: 0.875em;
text-align: center;
@@ -418,8 +417,8 @@
img.thumbimage {
border: none;
- padding: 0px;
- margin: 0px;
+ padding: 0;
+ margin: 0;
}
.thumbinner > a {
@@ -429,20 +428,17 @@
.thumbcaption {
border: none;
text-align: left;
- padding: 0.1875em !important;
+ padding: 0.2em;
}
div.magnify {
float: right;
- border: none !important;
- background: none !important;
}
div.magnify a,
div.magnify img {
display: block;
- border: none !important;
- background: none !important;
+ border: none;
}
div.tright {
@@ -458,7 +454,7 @@
}
img.thumbborder {
- border: 1px solid #aa;
+ border: thin solid #aa;
}
.hiddenStructure {
@@ -471,7 +467,7 @@
table.gallery td {
background-color: #fafafa;
- border: 2px solid #fafafa;
+ border: thin solid #fafafa;
}
/* Category and Special Page lists */
@@ -487,6 +483,8 @@
background: #66;
height: 100%;
overflow: hidden;
+ /* Hide the colon after "Category" */
+ color: #66;
}
#catlinks a {
@@ -498,7 +496,7 @@
}
.catlinks li:first-child {
- border-left: 1px solid #aa;
+ border-left: thin solid #aa;
}
.catlinks li {
@@ -577,7 +575,7 @@
}
#menu li {
- border-right: 1px solid #66;
+ border-right: thin solid #66;
padding: 0em 1em;
margin-bottom: 0.3em;
margin-right: 0em;
--
To view, visit https://gerrit.wikimedia.org/r/71984
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iad9ebed78525e75d4d61bdef0884efdb2c338bcd
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/erudite
Gerrit-Branch: master
Gerrit-Owner: Njw
Gerrit-Reviewer: Njw
Gerrit-Reviewer: jenkins-bot
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Several CSS improvements - change (mediawiki...erudite)
Njw has uploaded a new change for review.
https://gerrit.wikimedia.org/r/71984
Change subject: Several CSS improvements
..
Several CSS improvements
- Use thin instead of 1px for border-width
- Ensure site name isn't underlined if hovered
- Use em rather than px even around images
- Hide colon in categories section at the bottom of pages
- Remove unneeded !important entries
Change-Id: Iad9ebed78525e75d4d61bdef0884efdb2c338bcd
---
M assets/erudite.css
1 file changed, 22 insertions(+), 24 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/erudite
refs/changes/84/71984/1
diff --git a/assets/erudite.css b/assets/erudite.css
index 9e19a18..aedff6d 100644
--- a/assets/erudite.css
+++ b/assets/erudite.css
@@ -146,6 +146,7 @@
#header a {
color: #ff;
+ text-decoration: none;
}
#siteSubtitle {
@@ -158,7 +159,7 @@
margin: 1.5em 0 -0.625em;
overflow: hidden;
padding: 0.75em 2em 0.75em 3.75em;
- border-top: 1px solid #66;
+ border-top: thin solid #66;
background: #33;
background: rgba(50, 50, 50, 0.7);
}
@@ -206,7 +207,7 @@
}
.footer h3 {
- border-bottom: 1px solid #66;
+ border-bottom: thin solid #66;
margin-bottom: 0.2em;
font-size: 1.25em;
text-transform: uppercase;
@@ -217,7 +218,7 @@
.footer a.new {
color: #ff;
text-decoration: none;
- border-bottom: 1px solid #99;
+ border-bottom: thin solid #99;
}
.footer a:hover,
@@ -253,11 +254,9 @@
hr {
/* @embed */
background: url(images/hr.png) center no-repeat;
- height: 24px;
- margin: 0 0 10px;
+ height: 1.5em;
display: block;
- border-width: 0px;
- border-style: none !important;
+ border: none;
}
.entry-title {
@@ -309,7 +308,7 @@
/* Main Links */
.entry-content a {
- border-bottom: 1px solid #aa;
+ border-bottom: thin solid #aa;
}
.entry-content a:hover {
@@ -323,7 +322,7 @@
padding-left: 1em;
margin-left: 1em;
margin-bottom: 0.625em;
- border-left: 1px solid #aa;
+ border-left: thin solid #aa;
}
.entry-meta span {
@@ -368,8 +367,8 @@
/* Images */
.entry-content img {
- padding: 4px;
- margin-bottom: 6px;
+ padding: 0.25em;
+ margin-bottom: 0.5em;
}
.entry-content .gallery a {
@@ -408,8 +407,8 @@
}
div.thumbinner {
- border: 1px solid #cc;
- padding: 3px !important;
+ border: thin solid #cc;
+ padding: 0.2em;
background-color: #f9f9f9;
font-size: 0.875em;
text-align: center;
@@ -418,8 +417,8 @@
img.thumbimage {
border: none;
- padding: 0px;
- margin: 0px;
+ padding: 0;
+ margin: 0;
}
.thumbinner > a {
@@ -429,20 +428,17 @@
.thumbcaption {
border: none;
text-align: left;
- padding: 0.1875em !important;
+ padding: 0.2em;
}
div.magnify {
float: right;
- border: none !important;
- background: none !important;
}
div.magnify a,
div.magnify img {
display: block;
- border: none !important;
- background: none !important;
+ border: none;
}
div.tright {
@@ -458,7 +454,7 @@
}
img.thumbborder {
- border: 1px solid #aa;
+ border: thin solid #aa;
}
.hiddenStructure {
@@ -471,7 +467,7 @@
table.gallery td {
background-color: #fafafa;
- border: 2px solid #fafafa;
+ border: thin solid #fafafa;
}
/* Category and Special Page lists */
@@ -487,6 +483,8 @@
background: #66;
height: 100%;
overflow: hidden;
+ /* Hide the colon after "Category" */
+ color: #66;
}
#catlinks a {
@@ -498,7 +496,7 @@
}
.catlinks li:first-child {
- border-left: 1px solid #aa;
+ border-left: thin solid #aa;
}
.catlinks li {
@@ -577,7 +575,7 @@
}
#menu li {
- border-right: 1px solid #66;
+ border-right: thin solid #66;
padding: 0em 1em;
margin-bottom: 0.3em;
margin-right: 0em;
--
To view, visit https://gerrit.wikimedia.org/r/71984
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iad9ebed78525e75d4d61bdef0884efdb2c338bcd
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/erudite
Gerrit-Branch: master
Gerrit-Owner: Njw
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
