[MediaWiki-commits] [Gerrit] Several image improvements - change (mediawiki...erudite)

[Njw (Code Review)]

Njw has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/66246


Change subject: Several image improvements
..

Several image improvements

- Respect border
- Make thumb neater
- Work properly in IE 8
- Center works

Change-Id: I94ab36a181df2786e91653073d6a7ca097e1a363
---
M assets/erudite.css
1 file changed, 18 insertions(+), 13 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/erudite 
refs/changes/46/66246/1

diff --git a/assets/erudite.css b/assets/erudite.css
index 479fd8e..784de06 100644
--- a/assets/erudite.css
+++ b/assets/erudite.css
@@ -264,7 +264,8 @@
 .entry-content p,
 .entry-content li,
 .entry-content dt,
-.entry-content dd {
+.entry-content dd,
+.entry-content center {
font-size: 1.6em;
margin-bottom: 0.75em;
 }
@@ -308,6 +309,16 @@
 .entry-content li ol,
 .entry-content li ul {
margin: 0.5em 0 0 0.5em;
+}
+
+.center {
+   width: 100%;
+   text-align: center;
+}
+
+.center * {
+   margin-left: auto;
+   margin-right: auto;
 }
 
 /* Main Links */
@@ -382,10 +393,8 @@
 
 /* Images */
 .entry-content img {
-   border: 1px solid #aa;
padding: 4px;
margin-bottom: 6px;
-   max-width: 100%;
 }
 
 .entry-content .gallery a {
@@ -420,17 +429,15 @@
 
 div.thumb {
margin-bottom: 0.5em;
-   border-style: solid;
-   border-color: #fafafa;
width: auto;
-   background-color: transparent;
 }
 
 div.thumbinner {
border: 1px solid #cc;
padding: 3px !important;
background-color: #f9f9f9;
-   font-size: 94%;
+   font-size: 1.4em;
+   line-height: 1.4em;
text-align: center;
overflow: hidden;
 }
@@ -438,6 +445,7 @@
 img.thumbimage {
border: none;
padding: 0px;
+   margin: 0px;
 }
 
 .thumbinnera {
@@ -447,9 +455,7 @@
 .thumbcaption {
border: none;
text-align: left;
-   line-height: 1.4em;
padding: 3px !important;
-   font-size: 94%;
 }
 
 div.magnify {
@@ -468,18 +474,17 @@
 div.tright {
clear: right;
float: right;
-   border-width: 0.5em 0 0.8em 1.4em;
+   margin-left: 1.4em;
 }
 
 div.tleft {
float: left;
clear: left;
-   margin-right: 0.5em;
-   border-width: 0.5em 1.4em 0.8em 0;
+   margin-right: 1.4em;
 }
 
 img.thumbborder {
-   border: 1px solid #dd;
+   border: 1px solid #aa;
 }
 
 .hiddenStructure {

-- 
To view, visit https://gerrit.wikimedia.org/r/66246
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I94ab36a181df2786e91653073d6a7ca097e1a363
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/erudite
Gerrit-Branch: master
Gerrit-Owner: Njw nick.wh...@durham.ac.uk

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Several image improvements - change (mediawiki...erudite)

[Njw (Code Review)]

Njw has submitted this change and it was merged.

Change subject: Several image improvements
..


Several image improvements

- Respect border
- Make thumb neater
- Work properly in IE 8
- Center works

Change-Id: I94ab36a181df2786e91653073d6a7ca097e1a363
---
M assets/erudite.css
1 file changed, 18 insertions(+), 13 deletions(-)

Approvals:
  Njw: Verified; Looks good to me, approved



diff --git a/assets/erudite.css b/assets/erudite.css
index 479fd8e..784de06 100644
--- a/assets/erudite.css
+++ b/assets/erudite.css
@@ -264,7 +264,8 @@
 .entry-content p,
 .entry-content li,
 .entry-content dt,
-.entry-content dd {
+.entry-content dd,
+.entry-content center {
font-size: 1.6em;
margin-bottom: 0.75em;
 }
@@ -308,6 +309,16 @@
 .entry-content li ol,
 .entry-content li ul {
margin: 0.5em 0 0 0.5em;
+}
+
+.center {
+   width: 100%;
+   text-align: center;
+}
+
+.center * {
+   margin-left: auto;
+   margin-right: auto;
 }
 
 /* Main Links */
@@ -382,10 +393,8 @@
 
 /* Images */
 .entry-content img {
-   border: 1px solid #aa;
padding: 4px;
margin-bottom: 6px;
-   max-width: 100%;
 }
 
 .entry-content .gallery a {
@@ -420,17 +429,15 @@
 
 div.thumb {
margin-bottom: 0.5em;
-   border-style: solid;
-   border-color: #fafafa;
width: auto;
-   background-color: transparent;
 }
 
 div.thumbinner {
border: 1px solid #cc;
padding: 3px !important;
background-color: #f9f9f9;
-   font-size: 94%;
+   font-size: 1.4em;
+   line-height: 1.4em;
text-align: center;
overflow: hidden;
 }
@@ -438,6 +445,7 @@
 img.thumbimage {
border: none;
padding: 0px;
+   margin: 0px;
 }
 
 .thumbinnera {
@@ -447,9 +455,7 @@
 .thumbcaption {
border: none;
text-align: left;
-   line-height: 1.4em;
padding: 3px !important;
-   font-size: 94%;
 }
 
 div.magnify {
@@ -468,18 +474,17 @@
 div.tright {
clear: right;
float: right;
-   border-width: 0.5em 0 0.8em 1.4em;
+   margin-left: 1.4em;
 }
 
 div.tleft {
float: left;
clear: left;
-   margin-right: 0.5em;
-   border-width: 0.5em 1.4em 0.8em 0;
+   margin-right: 1.4em;
 }
 
 img.thumbborder {
-   border: 1px solid #dd;
+   border: 1px solid #aa;
 }
 
 .hiddenStructure {

-- 
To view, visit https://gerrit.wikimedia.org/r/66246
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I94ab36a181df2786e91653073d6a7ca097e1a363
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/erudite
Gerrit-Branch: master
Gerrit-Owner: Njw nick.wh...@durham.ac.uk
Gerrit-Reviewer: Njw nick.wh...@durham.ac.uk

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits