[MediaWiki-commits] [Gerrit] Slide up/down animations for BottomDialogs - change (apps...wikipedia)
Dbrant has submitted this change and it was merged. Change subject: Slide up/down animations for BottomDialogs .. Slide up/down animations for BottomDialogs Change-Id: Id496b25b7b412986b9c277c5ff2a3f9391bfb771 --- M wikipedia/res/values/styles.xml M wikipedia/src/main/java/org/wikipedia/page/BottomDialog.java 2 files changed, 13 insertions(+), 1 deletion(-) Approvals: Dbrant: Looks good to me, approved diff --git a/wikipedia/res/values/styles.xml b/wikipedia/res/values/styles.xml index 582a0b4..333a7cd 100644 --- a/wikipedia/res/values/styles.xml +++ b/wikipedia/res/values/styles.xml @@ -38,4 +38,12 @@ @color/page_info_heading + + +- @anim/abc_slide_in_bottom
+- @anim/abc_slide_out_bottom
+ + +- @style/DialogAnimation
+ diff --git a/wikipedia/src/main/java/org/wikipedia/page/BottomDialog.java b/wikipedia/src/main/java/org/wikipedia/page/BottomDialog.java index 6002864..fefcd43 100644 --- a/wikipedia/src/main/java/org/wikipedia/page/BottomDialog.java +++ b/wikipedia/src/main/java/org/wikipedia/page/BottomDialog.java @@ -1,5 +1,6 @@ package org.wikipedia.page; +import org.wikipedia.R; import android.app.Dialog; import android.content.Context; import android.os.Build; @@ -11,12 +12,15 @@ /** * A dialog that appears at the bottom of the page. + * + * It slides up when the dialog is opened, and down when the dialog is closed. + * see R.style.DialogSlideAnim for the animation */ public class BottomDialog extends Dialog { private View dialogLayout; public BottomDialog(Context context, int dialogLayoutResId) { -super(context); +super(context, R.style.DialogSlideAnim); LayoutInflater inflater = (LayoutInflater) context.getSystemService(Context.LAYOUT_INFLATER_SERVICE); dialogLayout = inflater.inflate(dialogLayoutResId, null); -- To view, visit https://gerrit.wikimedia.org/r/171725 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id496b25b7b412986b9c277c5ff2a3f9391bfb771 Gerrit-PatchSet: 5 Gerrit-Project: apps/android/wikipedia Gerrit-Branch: master Gerrit-Owner: BearND Gerrit-Reviewer: Brion VIBBER Gerrit-Reviewer: Dbrant Gerrit-Reviewer: jenkins-bot <> ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Slide up/down animations for BottomDialogs - change (apps...wikipedia)
BearND has uploaded a new change for review. https://gerrit.wikimedia.org/r/171725 Change subject: Slide up/down animations for BottomDialogs .. Slide up/down animations for BottomDialogs Change-Id: Id496b25b7b412986b9c277c5ff2a3f9391bfb771 --- M wikipedia/res/values/styles.xml M wikipedia/src/main/java/org/wikipedia/page/BottomDialog.java 2 files changed, 13 insertions(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia refs/changes/25/171725/1 diff --git a/wikipedia/res/values/styles.xml b/wikipedia/res/values/styles.xml index 582a0b4..333a7cd 100644 --- a/wikipedia/res/values/styles.xml +++ b/wikipedia/res/values/styles.xml @@ -38,4 +38,12 @@ @color/page_info_heading + + +- @anim/abc_slide_in_bottom
+- @anim/abc_slide_out_bottom
+ + +- @style/DialogAnimation
+ diff --git a/wikipedia/src/main/java/org/wikipedia/page/BottomDialog.java b/wikipedia/src/main/java/org/wikipedia/page/BottomDialog.java index 6002864..fefcd43 100644 --- a/wikipedia/src/main/java/org/wikipedia/page/BottomDialog.java +++ b/wikipedia/src/main/java/org/wikipedia/page/BottomDialog.java @@ -1,5 +1,6 @@ package org.wikipedia.page; +import org.wikipedia.R; import android.app.Dialog; import android.content.Context; import android.os.Build; @@ -11,12 +12,15 @@ /** * A dialog that appears at the bottom of the page. + * + * It slides up when the dialog is opened, and down when the dialog is closed. + * see R.style.DialogSlideAnim for the animation */ public class BottomDialog extends Dialog { private View dialogLayout; public BottomDialog(Context context, int dialogLayoutResId) { -super(context); +super(context, R.style.DialogSlideAnim); LayoutInflater inflater = (LayoutInflater) context.getSystemService(Context.LAYOUT_INFLATER_SERVICE); dialogLayout = inflater.inflate(dialogLayoutResId, null); -- To view, visit https://gerrit.wikimedia.org/r/171725 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Id496b25b7b412986b9c277c5ff2a3f9391bfb771 Gerrit-PatchSet: 1 Gerrit-Project: apps/android/wikipedia Gerrit-Branch: master Gerrit-Owner: BearND ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
