[MediaWiki-commits] [Gerrit] Some cleanup on html before saving - change (mediawiki...ContentTranslation)
Santhosh has uploaded a new change for review. https://gerrit.wikimedia.org/r/129658 Change subject: Some cleanup on html before saving .. Some cleanup on html before saving This will eventually moved to server as noted as TODO Change-Id: I0e3e81fd09e6fb3029db1b5dfecf4157b6b34e57 --- M modules/translation/ext.cx.publish.js 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ContentTranslation refs/changes/58/129658/1 diff --git a/modules/translation/ext.cx.publish.js b/modules/translation/ext.cx.publish.js index bb0e08c..c8ae9d2 100644 --- a/modules/translation/ext.cx.publish.js +++ b/modules/translation/ext.cx.publish.js @@ -24,6 +24,8 @@ $translatedContent.find( '.cx-segment' ).replaceWith( function () { return $( this ).html(); } ); + // TODO: This clean up should be done even before segmentation at server. + $translatedContent.find( 'link, title' ).remove(); // Remove placeholder sections that are empty // TODO: This can be better done if all placeholder sections has a semantic -- To view, visit https://gerrit.wikimedia.org/r/129658 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I0e3e81fd09e6fb3029db1b5dfecf4157b6b34e57 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/ContentTranslation Gerrit-Branch: master Gerrit-Owner: Santhosh ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Some cleanup on html before saving - change (mediawiki...ContentTranslation)
jenkins-bot has submitted this change and it was merged. Change subject: Some cleanup on html before saving .. Some cleanup on html before saving This will eventually moved to server as noted as TODO Change-Id: I0e3e81fd09e6fb3029db1b5dfecf4157b6b34e57 --- M modules/translation/ext.cx.publish.js 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Nikerabbit: Looks good to me, approved jenkins-bot: Verified diff --git a/modules/translation/ext.cx.publish.js b/modules/translation/ext.cx.publish.js index bb0e08c..c8ae9d2 100644 --- a/modules/translation/ext.cx.publish.js +++ b/modules/translation/ext.cx.publish.js @@ -24,6 +24,8 @@ $translatedContent.find( '.cx-segment' ).replaceWith( function () { return $( this ).html(); } ); + // TODO: This clean up should be done even before segmentation at server. + $translatedContent.find( 'link, title' ).remove(); // Remove placeholder sections that are empty // TODO: This can be better done if all placeholder sections has a semantic -- To view, visit https://gerrit.wikimedia.org/r/129658 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0e3e81fd09e6fb3029db1b5dfecf4157b6b34e57 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/ContentTranslation Gerrit-Branch: master Gerrit-Owner: Santhosh Gerrit-Reviewer: Nikerabbit Gerrit-Reviewer: jenkins-bot <> ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits