[MediaWiki-commits] [Gerrit] SpecialContributions: Fix whitespace in tagfilter - change (mediawiki/core)

2015-12-06 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: SpecialContributions: Fix whitespace in tagfilter
..


SpecialContributions: Fix whitespace in tagfilter

Removing the first element of an array, and using it as a label, doesn't make
much sense, if the array will be imploded using a whitespace to add a whitespace
between both array parts.

Instead of writing:
Tag filter:

this will result in the expected output:
Tag filter: 

Change-Id: Ifc9de7cc6ab380fcff435fcd0410963e72ef6203
---
M includes/specials/SpecialContributions.php
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Umherirrender: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/specials/SpecialContributions.php 
b/includes/specials/SpecialContributions.php
index 71d2b23..b1908c2 100644
--- a/includes/specials/SpecialContributions.php
+++ b/includes/specials/SpecialContributions.php
@@ -482,7 +482,7 @@
$filterSelection = Html::rawElement(
'td',
array(),
-   array_shift( $tagFilter ) . implode( '', 
$tagFilter )
+   implode( '', $tagFilter )
);
} else {
$filterSelection = Html::rawElement( 'td', array( 
'colspan' => 2 ), '' );

-- 
To view, visit https://gerrit.wikimedia.org/r/257170
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ifc9de7cc6ab380fcff435fcd0410963e72ef6203
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Florianschmidtwelzow 
Gerrit-Reviewer: Umherirrender 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] SpecialContributions: Fix whitespace in tagfilter - change (mediawiki/core)

2015-12-05 Thread Florianschmidtwelzow (Code Review) 
Florianschmidtwelzow has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/257170

Change subject: SpecialContributions: Fix whitespace in tagfilter
..

SpecialContributions: Fix whitespace in tagfilter

Removing the first element of an array, and using it as a label, doesn't make
much sense, if the array will be imploded using a whitespace to add a whitespace
between both array parts.

Instead of writing:
Tag filter:

this will result in the expected output:
Tag filter: 

Change-Id: Ifc9de7cc6ab380fcff435fcd0410963e72ef6203
---
M includes/specials/SpecialContributions.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/70/257170/1

diff --git a/includes/specials/SpecialContributions.php 
b/includes/specials/SpecialContributions.php
index 5f7c587..9a1eb83 100644
--- a/includes/specials/SpecialContributions.php
+++ b/includes/specials/SpecialContributions.php
@@ -481,7 +481,7 @@
$filterSelection = Html::rawElement(
'td',
array(),
-   array_shift( $tagFilter ) . implode( '', 
$tagFilter )
+   implode( '', $tagFilter )
);
} else {
$filterSelection = Html::rawElement( 'td', array( 
'colspan' => 2 ), '' );

-- 
To view, visit https://gerrit.wikimedia.org/r/257170
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifc9de7cc6ab380fcff435fcd0410963e72ef6203
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Florianschmidtwelzow 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits