[MediaWiki-commits] [Gerrit] SpecialNewpages: Add redirect=no only to links to redirects - change (mediawiki/core)

[Gerrit Patch Uploader (Code Review)]

Gerrit Patch Uploader has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/240386

Change subject: SpecialNewpages: Add redirect=no only to links to redirects
..

SpecialNewpages: Add redirect=no only to links to redirects

Since 2748c4091 all title links have redirect=no. This is requested in T16353.
To satisfy T16353 it should be enough to add this only to links to redirects.

Appending redirect=no to all links has the disadvantage of a duplicate link.

This change adds redirect=no only to links to redirects.

Change-Id: I33da0f1eadc5dfbc46820015622ee1a55acbfe21
---
M includes/specials/SpecialNewpages.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/86/240386/1

diff --git a/includes/specials/SpecialNewpages.php 
b/includes/specials/SpecialNewpages.php
index 251a8e0..c8d4aa6 100644
--- a/includes/specials/SpecialNewpages.php
+++ b/includes/specials/SpecialNewpages.php
@@ -315,7 +315,7 @@
array()
);
 
-   $query = array( 'redirect' => 'no' );
+   $query = $title->isRedirect() ? array( 'redirect' => 'no' ) : 
array();
 
// Linker::linkKnown() uses 'known' and 'noclasses' options.
// This breaks the colouration for stubs.

-- 
To view, visit https://gerrit.wikimedia.org/r/240386
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I33da0f1eadc5dfbc46820015622ee1a55acbfe21
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Gerrit Patch Uploader 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] SpecialNewpages: Add redirect=no only to links to redirects - change (mediawiki/core)

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged.

Change subject: SpecialNewpages: Add redirect=no only to links to redirects
..


SpecialNewpages: Add redirect=no only to links to redirects

Since 2748c4091 all title links have redirect=no. This is requested in T16353.
To satisfy T16353 it should be enough to add this only to links to redirects.

Appending redirect=no to all links has the disadvantage of a duplicate link.

This change adds redirect=no only to links to redirects.

Change-Id: I33da0f1eadc5dfbc46820015622ee1a55acbfe21
---
M includes/specials/SpecialNewpages.php
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Daniel Kinzler: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/specials/SpecialNewpages.php 
b/includes/specials/SpecialNewpages.php
index 251a8e0..c8d4aa6 100644
--- a/includes/specials/SpecialNewpages.php
+++ b/includes/specials/SpecialNewpages.php
@@ -315,7 +315,7 @@
array()
);
 
-   $query = array( 'redirect' => 'no' );
+   $query = $title->isRedirect() ? array( 'redirect' => 'no' ) : 
array();
 
// Linker::linkKnown() uses 'known' and 'noclasses' options.
// This breaks the colouration for stubs.

-- 
To view, visit https://gerrit.wikimedia.org/r/240386
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I33da0f1eadc5dfbc46820015622ee1a55acbfe21
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Gerrit Patch Uploader 
Gerrit-Reviewer: Daniel Kinzler 
Gerrit-Reviewer: Gerrit Patch Uploader 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits