[MediaWiki-commits] [Gerrit] Split time and date in running sentence - change (mediawiki...CreditsSource)

2013-04-01 Thread Siebrand (Code Review)
Siebrand has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/56905


Change subject: Split time and date in running sentence
..

Split time and date in running sentence

Spotted by Purodha and reported in
https://translatewiki.net/wiki/Thread:Support/About_MediaWiki:Creditssource-source-work/ksh_%282%29

Change-Id: Ibeac0aa8adb0e0c3490228242832a93ac1787f51
---
M CreditsSource.i18n.php
M CreditsSource_body.php
2 files changed, 11 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CreditsSource 
refs/changes/05/56905/1

diff --git a/CreditsSource.i18n.php b/CreditsSource.i18n.php
index 9ae886d..56c17ea 100644
--- a/CreditsSource.i18n.php
+++ b/CreditsSource.i18n.php
@@ -10,7 +10,7 @@
 
 $messages['en'] = array(
'creditssource-desc'=> 'Display source work credits in the 
page footer',
-   'creditssource-source-work' => 'This page is derived from the page 
$1 on $2 in its revision from $3 (UTC). There, it is published under the CC 
BY-SA 3.0 license. More details and the full list of contributors can be found 
on the associated $5. Wikitravel contributors are marked by the prefix $4.',
+   'creditssource-source-work' => 'This page is derived from the page 
$1 on $2 in its revision from $6 at $7 (UTC). There, it is published under the 
CC BY-SA 3.0 license. More details and the full list of contributors can be 
found on the associated $5. Wikitravel contributors are marked by the prefix 
$4.',
'creditssource-historypage' => 'history page',
'creditssource-creditpage'  => 'Gives credits for sourceworks.',
 );
@@ -22,11 +22,13 @@
 $messages['qqq'] = array(
'creditssource-desc' => '{{desc|name=Credits 
Source|url=http://www.mediawiki.org/wiki/Extension:CreditsSource}}',
'creditssource-source-work' => 'Parameters:
-* $1 - external link to the source. its link text is page title.
-* $2 - external link to the site. its link text is site name.
-* $3 - time and date (localized)
-* $4 - short name of the site Wikitravel
-* $5 - link to History page. its text is 
{{msg-mw|Creditssource-historypage}}.',
+* $1 is an external link to the source. its link text is page title.
+* $2 is an external link to the site. its link text is site name.
+* $3 is unused.
+* $4 is a short name of the site Wikitravel.
+* $5 is a link to the history page. Its text is 
{{msg-mw|Creditssource-historypage}}.
+* $6 is a date.
+* $7 is a time.',
'creditssource-historypage' => 'Used as link anchor text.
 
 The link points to History page of the specified page.',
diff --git a/CreditsSource_body.php b/CreditsSource_body.php
index e26b9a2..89878db 100644
--- a/CreditsSource_body.php
+++ b/CreditsSource_body.php
@@ -62,7 +62,9 @@
$siteLink,
$wgLang->timeanddate( $source->mTs ),
$source->mSiteShortName,
-   $historyLink
+   $historyLink,
+   $wgLang->date( $source->mTs ),
+   $wgLang->time( $source->mTs )
)->text();
}
 

-- 
To view, visit https://gerrit.wikimedia.org/r/56905
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibeac0aa8adb0e0c3490228242832a93ac1787f51
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CreditsSource
Gerrit-Branch: master
Gerrit-Owner: Siebrand 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Split time and date in running sentence - change (mediawiki...CreditsSource)

2013-04-01 Thread Matthias Mullie (Code Review)
Matthias Mullie has submitted this change and it was merged.

Change subject: Split time and date in running sentence
..


Split time and date in running sentence

Spotted by Purodha and reported in
https://translatewiki.net/wiki/Thread:Support/About_MediaWiki:Creditssource-source-work/ksh_%282%29

Change-Id: Ibeac0aa8adb0e0c3490228242832a93ac1787f51
---
M CreditsSource.i18n.php
M CreditsSource_body.php
2 files changed, 11 insertions(+), 7 deletions(-)

Approvals:
  Matthias Mullie: Verified; Looks good to me, approved



diff --git a/CreditsSource.i18n.php b/CreditsSource.i18n.php
index 9ae886d..56c17ea 100644
--- a/CreditsSource.i18n.php
+++ b/CreditsSource.i18n.php
@@ -10,7 +10,7 @@
 
 $messages['en'] = array(
'creditssource-desc'=> 'Display source work credits in the 
page footer',
-   'creditssource-source-work' => 'This page is derived from the page 
$1 on $2 in its revision from $3 (UTC). There, it is published under the CC 
BY-SA 3.0 license. More details and the full list of contributors can be found 
on the associated $5. Wikitravel contributors are marked by the prefix $4.',
+   'creditssource-source-work' => 'This page is derived from the page 
$1 on $2 in its revision from $6 at $7 (UTC). There, it is published under the 
CC BY-SA 3.0 license. More details and the full list of contributors can be 
found on the associated $5. Wikitravel contributors are marked by the prefix 
$4.',
'creditssource-historypage' => 'history page',
'creditssource-creditpage'  => 'Gives credits for sourceworks.',
 );
@@ -22,11 +22,13 @@
 $messages['qqq'] = array(
'creditssource-desc' => '{{desc|name=Credits 
Source|url=http://www.mediawiki.org/wiki/Extension:CreditsSource}}',
'creditssource-source-work' => 'Parameters:
-* $1 - external link to the source. its link text is page title.
-* $2 - external link to the site. its link text is site name.
-* $3 - time and date (localized)
-* $4 - short name of the site Wikitravel
-* $5 - link to History page. its text is 
{{msg-mw|Creditssource-historypage}}.',
+* $1 is an external link to the source. its link text is page title.
+* $2 is an external link to the site. its link text is site name.
+* $3 is unused.
+* $4 is a short name of the site Wikitravel.
+* $5 is a link to the history page. Its text is 
{{msg-mw|Creditssource-historypage}}.
+* $6 is a date.
+* $7 is a time.',
'creditssource-historypage' => 'Used as link anchor text.
 
 The link points to History page of the specified page.',
diff --git a/CreditsSource_body.php b/CreditsSource_body.php
index e26b9a2..89878db 100644
--- a/CreditsSource_body.php
+++ b/CreditsSource_body.php
@@ -62,7 +62,9 @@
$siteLink,
$wgLang->timeanddate( $source->mTs ),
$source->mSiteShortName,
-   $historyLink
+   $historyLink,
+   $wgLang->date( $source->mTs ),
+   $wgLang->time( $source->mTs )
)->text();
}
 

-- 
To view, visit https://gerrit.wikimedia.org/r/56905
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ibeac0aa8adb0e0c3490228242832a93ac1787f51
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CreditsSource
Gerrit-Branch: master
Gerrit-Owner: Siebrand 
Gerrit-Reviewer: Hoo man 
Gerrit-Reviewer: Matthias Mullie 
Gerrit-Reviewer: Raimond Spekking 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits