[MediaWiki-commits] [Gerrit] Stash global only once per test case. - change (mediawiki/core[master])

2012-10-29 Thread Nikerabbit (Code Review) 
Nikerabbit has submitted this change and it was merged.

Change subject: Stash global only once per test case.
..


Stash global only once per test case.

Make sure we only stash a given global only once per test case since we
do not want to override the original value.

This allows the same test to modify the same global multiple times,
while still preserving the original value to be restored after the
test case finished.

Change-Id: I9056d6d6879fb976a192960f661904287f9760a8
---
M tests/phpunit/MediaWikiTestCase.php
1 file changed, 14 insertions(+), 7 deletions(-)

Approvals:
  Aude: Looks good to me, but someone else must approve
  Nikerabbit: Looks good to me, approved
  Daniel Kinzler: Looks good to me, but someone else must approve
  Hashar: Looks good to me, but someone else must approve
  jenkins-bot: Verified


--
To view, visit https://gerrit.wikimedia.org/r/29972
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9056d6d6879fb976a192960f661904287f9760a8
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Daniel Kinzler daniel.kinz...@wikimedia.de
Gerrit-Reviewer: Aaron Schulz asch...@wikimedia.org
Gerrit-Reviewer: Aude aude.w...@gmail.com
Gerrit-Reviewer: Daniel Kinzler daniel.kinz...@wikimedia.de
Gerrit-Reviewer: Hashar has...@free.fr
Gerrit-Reviewer: Nikerabbit niklas.laxst...@gmail.com
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Stash global only once per test case. - change (mediawiki/core[master])

2012-10-25 Thread Daniel Kinzler (Code Review) 
Daniel Kinzler has uploaded a new change for review.

Change subject: Stash global only once per test case.
..

Stash global only once per test case.

Make sure we only stash a given global only once per test case.
This allows the same test to modify the same global multiple times,
while still preserving the original value to be restored after the
test case finished.

Change-Id: I9056d6d6879fb976a192960f661904287f9760a8
---
M tests/phpunit/MediaWikiTestCase.php
1 file changed, 7 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/72/29972/1
--
To view, visit https://gerrit.wikimedia.org/r/29972
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9056d6d6879fb976a192960f661904287f9760a8
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Daniel Kinzler daniel.kinz...@wikimedia.de

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits