[MediaWiki-commits] [Gerrit] Stop registering event handlers twice in referenceview - change (mediawiki...Wikibase)
Adrian Lang has uploaded a new change for review. https://gerrit.wikimedia.org/r/121674 Change subject: Stop registering event handlers twice in referenceview .. Stop registering event handlers twice in referenceview Bug: 63225 Change-Id: Iea36de4d0ecb8f61e67580e7af3cd771f7dd5db4 --- M lib/resources/jquery.wikibase/jquery.wikibase.referenceview.js 1 file changed, 0 insertions(+), 2 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase refs/changes/74/121674/1 diff --git a/lib/resources/jquery.wikibase/jquery.wikibase.referenceview.js b/lib/resources/jquery.wikibase/jquery.wikibase.referenceview.js index 716aee5..29b21c6 100644 --- a/lib/resources/jquery.wikibase/jquery.wikibase.referenceview.js +++ b/lib/resources/jquery.wikibase/jquery.wikibase.referenceview.js @@ -371,8 +371,6 @@ this.element.removeClass( 'wb-edit' ); this._isInEditMode = false; - this._attachEditModeEventHandlers(); - this._trigger( 'afterstopediting', null, [ dropValue ] ); } else { -- To view, visit https://gerrit.wikimedia.org/r/121674 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Iea36de4d0ecb8f61e67580e7af3cd771f7dd5db4 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Adrian Lang ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Stop registering event handlers twice in referenceview - change (mediawiki...Wikibase)
jenkins-bot has submitted this change and it was merged. Change subject: Stop registering event handlers twice in referenceview .. Stop registering event handlers twice in referenceview Bug: 63225 Change-Id: Iea36de4d0ecb8f61e67580e7af3cd771f7dd5db4 --- M lib/resources/jquery.wikibase/jquery.wikibase.referenceview.js 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: WikidataJenkins: Verified Thiemo Mättig (WMDE): Verified; Looks good to me, approved jenkins-bot: Verified diff --git a/lib/resources/jquery.wikibase/jquery.wikibase.referenceview.js b/lib/resources/jquery.wikibase/jquery.wikibase.referenceview.js index 716aee5..29b21c6 100644 --- a/lib/resources/jquery.wikibase/jquery.wikibase.referenceview.js +++ b/lib/resources/jquery.wikibase/jquery.wikibase.referenceview.js @@ -371,8 +371,6 @@ this.element.removeClass( 'wb-edit' ); this._isInEditMode = false; - this._attachEditModeEventHandlers(); - this._trigger( 'afterstopediting', null, [ dropValue ] ); } else { -- To view, visit https://gerrit.wikimedia.org/r/121674 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iea36de4d0ecb8f61e67580e7af3cd771f7dd5db4 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Adrian Lang Gerrit-Reviewer: Adrian Lang Gerrit-Reviewer: Thiemo Mättig (WMDE) Gerrit-Reviewer: Tobias Gritschacher Gerrit-Reviewer: WikidataJenkins Gerrit-Reviewer: jenkins-bot <> ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits