[MediaWiki-commits] [Gerrit] Stop uls-previous-languages cookie varying by path - change (mediawiki...UniversalLanguageSelector)
jenkins-bot has submitted this change and it was merged. Change subject: Stop uls-previous-languages cookie varying by path .. Stop uls-previous-languages cookie varying by path Set path to '/' otherwise you get one cookie for /w and another for /wiki locations. Bug: 49155 Change-Id: I4756fdf06b0580b5b57a41cd771b94723bb5cdbf --- M resources/js/ext.uls.init.js 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Santhosh: Looks good to me, approved jenkins-bot: Verified diff --git a/resources/js/ext.uls.init.js b/resources/js/ext.uls.init.js index f722caa..70a14f9 100644 --- a/resources/js/ext.uls.init.js +++ b/resources/js/ext.uls.init.js @@ -53,7 +53,8 @@ }; mw.uls.setPreviousLanguages = function ( previousLanguages ) { - $.cookie( mw.uls.previousLanguagesCookie, $.toJSON( previousLanguages ) ); + $.cookie( mw.uls.previousLanguagesCookie, $.toJSON( previousLanguages ), + { path: '/' } ); }; mw.uls.getPreviousLanguages = function () { -- To view, visit https://gerrit.wikimedia.org/r/73506 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4756fdf06b0580b5b57a41cd771b94723bb5cdbf Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/UniversalLanguageSelector Gerrit-Branch: master Gerrit-Owner: Spage sp...@wikimedia.org Gerrit-Reviewer: Amire80 amir.ahar...@mail.huji.ac.il Gerrit-Reviewer: Nikerabbit niklas.laxst...@gmail.com Gerrit-Reviewer: Santhosh santhosh.thottin...@gmail.com Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Stop uls-previous-languages cookie varying by path - change (mediawiki...UniversalLanguageSelector)
Spage has uploaded a new change for review. https://gerrit.wikimedia.org/r/73506 Change subject: Stop uls-previous-languages cookie varying by path .. Stop uls-previous-languages cookie varying by path Set path to '/' otherwise you get one cookie for /w and another for /wiki locations. Bug: 49155 Change-Id: I4756fdf06b0580b5b57a41cd771b94723bb5cdbf --- M resources/js/ext.uls.init.js 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/UniversalLanguageSelector refs/changes/06/73506/1 diff --git a/resources/js/ext.uls.init.js b/resources/js/ext.uls.init.js index f722caa..70a14f9 100644 --- a/resources/js/ext.uls.init.js +++ b/resources/js/ext.uls.init.js @@ -53,7 +53,8 @@ }; mw.uls.setPreviousLanguages = function ( previousLanguages ) { - $.cookie( mw.uls.previousLanguagesCookie, $.toJSON( previousLanguages ) ); + $.cookie( mw.uls.previousLanguagesCookie, $.toJSON( previousLanguages ), + { path: '/' } ); }; mw.uls.getPreviousLanguages = function () { -- To view, visit https://gerrit.wikimedia.org/r/73506 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I4756fdf06b0580b5b57a41cd771b94723bb5cdbf Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/UniversalLanguageSelector Gerrit-Branch: master Gerrit-Owner: Spage sp...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits