[MediaWiki-commits] [Gerrit] Stop varnishncsa - change (operations/puppet)

2016-05-27 Thread Ema (Code Review)
Ema has submitted this change and it was merged.

Change subject: Stop varnishncsa
..


Stop varnishncsa

We have noticed a FD leak caused by varnishncsa, similar to the one
described in T135700. Given that we don't use it, make sure varnishncsa
is stopped.

Change-Id: Ie44cedd0061f63c7964b4e68a02bd30cfa914b5d
---
M modules/varnish/manifests/common.pp
1 file changed, 6 insertions(+), 0 deletions(-)

Approvals:
  Ema: Verified; Looks good to me, approved
  BBlack: Looks good to me, but someone else must approve



diff --git a/modules/varnish/manifests/common.pp 
b/modules/varnish/manifests/common.pp
index b438c6b..74aa288 100644
--- a/modules/varnish/manifests/common.pp
+++ b/modules/varnish/manifests/common.pp
@@ -43,6 +43,12 @@
 force   => true,
 }
 
+# We are not using varnishncsa, make sure it's stopped
+service { 'varnishncsa':
+ensure => 'stopped',
+enable => false,
+}
+
 if (hiera('varnish_version4', false)) {
 # varnishlog4.py depends on varnishapi. Install it.
 file { '/usr/local/lib/python2.7/dist-packages/varnishapi.py':

-- 
To view, visit https://gerrit.wikimedia.org/r/291238
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie44cedd0061f63c7964b4e68a02bd30cfa914b5d
Gerrit-PatchSet: 3
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Ema 
Gerrit-Reviewer: BBlack 
Gerrit-Reviewer: Ema 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Stop varnishncsa - change (operations/puppet)

2016-05-27 Thread Ema (Code Review)
Ema has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/291238

Change subject: Stop varnishncsa
..

Stop varnishncsa

We have noticed a FD leak caused by varnishncsa, similar to the one
described in T135700. Given that we don't use it, make sure varnishncsa
is stopped.

Change-Id: Ie44cedd0061f63c7964b4e68a02bd30cfa914b5d
---
M modules/varnish/manifests/common.pp
1 file changed, 5 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/38/291238/1

diff --git a/modules/varnish/manifests/common.pp 
b/modules/varnish/manifests/common.pp
index b438c6b..b454a69 100644
--- a/modules/varnish/manifests/common.pp
+++ b/modules/varnish/manifests/common.pp
@@ -43,6 +43,11 @@
 force   => true,
 }
 
+# We are not using varnishncsa, make sure it's stopped
+service { 'varnishncsa':
+ensure => 'stopped'
+}
+
 if (hiera('varnish_version4', false)) {
 # varnishlog4.py depends on varnishapi. Install it.
 file { '/usr/local/lib/python2.7/dist-packages/varnishapi.py':

-- 
To view, visit https://gerrit.wikimedia.org/r/291238
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie44cedd0061f63c7964b4e68a02bd30cfa914b5d
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Ema 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits