[MediaWiki-commits] [Gerrit] Styling adjustments for notifications - change (mediawiki...Echo)
jenkins-bot has submitted this change and it was merged.
Change subject: Styling adjustments for notifications
..
Styling adjustments for notifications
Bug: T125969
Bug: T128444
Change-Id: I3dba4fcddf5262450cce4ba384abfdc3518b7cb8
---
M modules/ooui/styles/mw.echo.ui.MenuItemWidget.less
M modules/ooui/styles/mw.echo.ui.NotificationGroupItemWidget.less
M modules/ooui/styles/mw.echo.ui.NotificationItemWidget.less
3 files changed, 13 insertions(+), 11 deletions(-)
Approvals:
Sbisson: Looks good to me, approved
Catrope: Looks good to me, but someone else must approve
jenkins-bot: Verified
diff --git a/modules/ooui/styles/mw.echo.ui.MenuItemWidget.less
b/modules/ooui/styles/mw.echo.ui.MenuItemWidget.less
index dbe31c3..52457d7 100644
--- a/modules/ooui/styles/mw.echo.ui.MenuItemWidget.less
+++ b/modules/ooui/styles/mw.echo.ui.MenuItemWidget.less
@@ -30,7 +30,9 @@
}
&-prioritized {
+ .mw-echo-ui-mixin-hover-opacity();
display: inline-block;
+ padding: 0;
}
// Correct for when inside the popup menu
diff --git a/modules/ooui/styles/mw.echo.ui.NotificationGroupItemWidget.less
b/modules/ooui/styles/mw.echo.ui.NotificationGroupItemWidget.less
index 71d65c1..b677da8 100644
--- a/modules/ooui/styles/mw.echo.ui.NotificationGroupItemWidget.less
+++ b/modules/ooui/styles/mw.echo.ui.NotificationGroupItemWidget.less
@@ -13,7 +13,7 @@
}
&-content {
- margin-bottom: 0.5em;
+ margin-bottom: 1em;
padding-right: 0.8em;
padding-left: ~"calc(30px + 1.6em)"; // 30px+0.8em from
ItemWidget, plus 0.8em
}
diff --git a/modules/ooui/styles/mw.echo.ui.NotificationItemWidget.less
b/modules/ooui/styles/mw.echo.ui.NotificationItemWidget.less
index 1a9a070..d9be2c9 100644
--- a/modules/ooui/styles/mw.echo.ui.NotificationItemWidget.less
+++ b/modules/ooui/styles/mw.echo.ui.NotificationItemWidget.less
@@ -6,7 +6,6 @@
background-color: #F1F1F1;
border-bottom: 1px solid #DD;
white-space: normal;
- line-height: 16px;
&:hover > a {
text-decoration: none;
@@ -33,6 +32,7 @@
width: 100%;
&-message {
+ line-height: 16px;
&-header {
color: @notification-text-color;
}
@@ -55,20 +55,18 @@
& > &-buttons.oo-ui-buttonSelectWidget {
display: table-cell;
- vertical-align: top;
- width: 100%;
+ vertical-align: middle;
}
.mw-echo-ui-menuItemWidget {
- &:not(:last-child) {
- margin-right: 1em;
- }
+ margin-right: 1.2em;
}
&-menu {
+ .mw-echo-ui-mixin-hover-opacity();
display: table-cell;
- vertical-align: top;
- padding: 0 0.5em;
+ vertical-align: middle;
+ padding: 0;
.oo-ui-popupWidget-popup {
font-size: 1 / 0.8em;
@@ -78,10 +76,12 @@
&-timestamp {
display: table-cell;
- vertical-align: top;
+ vertical-align: middle;
+ text-align: right;
color: black;
opacity: @opacity-low;
white-space: nowrap;
+ width: 100%;
}
}
@@ -155,7 +155,7 @@
float: right;
font-size: 1em;
margin-top: -0.5em;
- margin-right: -0.5em;
+ margin-right: -0.4em;
padding: 0;
.mw-echo-ui-notificationItemWidget-bundle & {
--
To view, visit https://gerrit.wikimedia.org/r/274804
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3dba4fcddf5262450cce4ba384abfdc3518b7cb8
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Echo
Gerrit-Branch: master
Gerrit-Owner: Mooeypoo
Gerrit-Reviewer: Catrope
Gerrit-Reviewer: Sbisson
Gerrit-Reviewer: jenkins-bot <>
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/l
[MediaWiki-commits] [Gerrit] Styling adjustments for notifications - change (mediawiki...Echo)
Mooeypoo has uploaded a new change for review.
https://gerrit.wikimedia.org/r/274804
Change subject: Styling adjustments for notifications
..
Styling adjustments for notifications
Bug: T125969
Change-Id: I3dba4fcddf5262450cce4ba384abfdc3518b7cb8
---
M modules/ooui/styles/mw.echo.ui.MenuItemWidget.less
M modules/ooui/styles/mw.echo.ui.NotificationGroupItemWidget.less
M modules/ooui/styles/mw.echo.ui.NotificationItemWidget.less
3 files changed, 13 insertions(+), 11 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Echo
refs/changes/04/274804/1
diff --git a/modules/ooui/styles/mw.echo.ui.MenuItemWidget.less
b/modules/ooui/styles/mw.echo.ui.MenuItemWidget.less
index dbe31c3..52457d7 100644
--- a/modules/ooui/styles/mw.echo.ui.MenuItemWidget.less
+++ b/modules/ooui/styles/mw.echo.ui.MenuItemWidget.less
@@ -30,7 +30,9 @@
}
&-prioritized {
+ .mw-echo-ui-mixin-hover-opacity();
display: inline-block;
+ padding: 0;
}
// Correct for when inside the popup menu
diff --git a/modules/ooui/styles/mw.echo.ui.NotificationGroupItemWidget.less
b/modules/ooui/styles/mw.echo.ui.NotificationGroupItemWidget.less
index 71d65c1..b677da8 100644
--- a/modules/ooui/styles/mw.echo.ui.NotificationGroupItemWidget.less
+++ b/modules/ooui/styles/mw.echo.ui.NotificationGroupItemWidget.less
@@ -13,7 +13,7 @@
}
&-content {
- margin-bottom: 0.5em;
+ margin-bottom: 1em;
padding-right: 0.8em;
padding-left: ~"calc(30px + 1.6em)"; // 30px+0.8em from
ItemWidget, plus 0.8em
}
diff --git a/modules/ooui/styles/mw.echo.ui.NotificationItemWidget.less
b/modules/ooui/styles/mw.echo.ui.NotificationItemWidget.less
index 1a9a070..d9be2c9 100644
--- a/modules/ooui/styles/mw.echo.ui.NotificationItemWidget.less
+++ b/modules/ooui/styles/mw.echo.ui.NotificationItemWidget.less
@@ -6,7 +6,6 @@
background-color: #F1F1F1;
border-bottom: 1px solid #DD;
white-space: normal;
- line-height: 16px;
&:hover > a {
text-decoration: none;
@@ -33,6 +32,7 @@
width: 100%;
&-message {
+ line-height: 16px;
&-header {
color: @notification-text-color;
}
@@ -55,20 +55,18 @@
& > &-buttons.oo-ui-buttonSelectWidget {
display: table-cell;
- vertical-align: top;
- width: 100%;
+ vertical-align: middle;
}
.mw-echo-ui-menuItemWidget {
- &:not(:last-child) {
- margin-right: 1em;
- }
+ margin-right: 1.2em;
}
&-menu {
+ .mw-echo-ui-mixin-hover-opacity();
display: table-cell;
- vertical-align: top;
- padding: 0 0.5em;
+ vertical-align: middle;
+ padding: 0;
.oo-ui-popupWidget-popup {
font-size: 1 / 0.8em;
@@ -78,10 +76,12 @@
&-timestamp {
display: table-cell;
- vertical-align: top;
+ vertical-align: middle;
+ text-align: right;
color: black;
opacity: @opacity-low;
white-space: nowrap;
+ width: 100%;
}
}
@@ -155,7 +155,7 @@
float: right;
font-size: 1em;
margin-top: -0.5em;
- margin-right: -0.5em;
+ margin-right: -0.4em;
padding: 0;
.mw-echo-ui-notificationItemWidget-bundle & {
--
To view, visit https://gerrit.wikimedia.org/r/274804
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3dba4fcddf5262450cce4ba384abfdc3518b7cb8
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Echo
Gerrit-Branch: master
Gerrit-Owner: Mooeypoo
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
