jenkins-bot has submitted this change and it was merged. Change subject: TableOfContents uses events map ......................................................................
TableOfContents uses events map Dependency: https://gerrit.wikimedia.org/r/181734 in Mantle extension Change-Id: I6e1c90a6db8be9235ac6cb9ff74375e196498337 --- M javascripts/modules/toc/TableOfContents.js 1 file changed, 17 insertions(+), 11 deletions(-) Approvals: Jdlrobson: Looks good to me, approved jenkins-bot: Verified diff --git a/javascripts/modules/toc/TableOfContents.js b/javascripts/modules/toc/TableOfContents.js index fd7b3c7..ad041a8 100644 --- a/javascripts/modules/toc/TableOfContents.js +++ b/javascripts/modules/toc/TableOfContents.js @@ -2,7 +2,8 @@ var TableOfContents, MobileWebClickTracking = M.require( 'loggingSchemas/MobileWebClickTracking' ), View = M.require( 'View' ), - Icon = M.require( 'Icon' ); + Icon = M.require( 'Icon' ), + log = MobileWebClickTracking.log; /** * View for table of contents @@ -30,17 +31,22 @@ tagName: 'div', className: 'toc-mobile', template: mw.template.get( 'mobile.toc', 'toc.hogan' ), - /** @inheritdoc */ - postRender: function () { - var log = MobileWebClickTracking.log; - View.prototype.postRender.apply( this, arguments ); + events: { // Click tracking for table of contents so we can see if people interact with it - this.$( 'h2' ).on( 'click', function () { - log( 'UI', 'page-toc-toggle' ); - } ); - this.$( 'a' ).on( 'click', function () { - log( 'UI', 'page-toc-link' ); - } ); + 'click h2': 'onTocToggle', + 'click a': 'onLinkClick' + }, + /** + * Log toggling the header + */ + onTocToggle: function () { + log( 'UI', 'page-toc-toggle' ); + }, + /** + * Log clicking a TOC link + */ + onLinkClick: function () { + log( 'UI', 'page-toc-link' ); } } ); -- To view, visit https://gerrit.wikimedia.org/r/180836 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6e1c90a6db8be9235ac6cb9ff74375e196498337 Gerrit-PatchSet: 10 Gerrit-Project: mediawiki/extensions/MobileFrontend Gerrit-Branch: master Gerrit-Owner: Jhernandez <jhernan...@wikimedia.org> Gerrit-Reviewer: Jdlrobson <jrob...@wikimedia.org> Gerrit-Reviewer: Jhernandez <jhernan...@wikimedia.org> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
