[MediaWiki-commits] [Gerrit] Translation list: Replace the elipses text with icon - change (mediawiki...ContentTranslation)
jenkins-bot has submitted this change and it was merged. Change subject: Translation list: Replace the elipses text with icon .. Translation list: Replace the elipses text with icon Change-Id: Id209db00dc9bdaed24a0da51af1592741d160d89 --- M modules/dashboard/ext.cx.translationlist.js A modules/dashboard/images/elipses.png A modules/dashboard/images/elipses.svg M modules/dashboard/styles/ext.cx.translationlist.less 4 files changed, 10 insertions(+), 6 deletions(-) Approvals: Nikerabbit: Checked; Looks good to me, approved jenkins-bot: Verified diff --git a/modules/dashboard/ext.cx.translationlist.js b/modules/dashboard/ext.cx.translationlist.js index 4010ec6..5466aa7 100644 --- a/modules/dashboard/ext.cx.translationlist.js +++ b/modules/dashboard/ext.cx.translationlist.js @@ -321,8 +321,7 @@ .text( mw.msg( 'cx-translation-status-' + translation.status ) ); $actionsTrigger = $( '' ) - .addClass( 'cx-tlitem__actions__trigger' ) - .text( '…' ); + .addClass( 'cx-tlitem__actions__trigger' ); // If the translation is draft, allow deleting it if ( translation.status === 'draft' ) { $deleteTranslation = $( '' ) diff --git a/modules/dashboard/images/elipses.png b/modules/dashboard/images/elipses.png new file mode 100644 index 000..21594ea --- /dev/null +++ b/modules/dashboard/images/elipses.png Binary files differ diff --git a/modules/dashboard/images/elipses.svg b/modules/dashboard/images/elipses.svg new file mode 100644 index 000..98cc53d --- /dev/null +++ b/modules/dashboard/images/elipses.svg @@ -0,0 +1 @@ +http://www.w3.org/2000/svg"; viewBox="0 0 24 24"> diff --git a/modules/dashboard/styles/ext.cx.translationlist.less b/modules/dashboard/styles/ext.cx.translationlist.less index 50c2b21..8437d01 100644 --- a/modules/dashboard/styles/ext.cx.translationlist.less +++ b/modules/dashboard/styles/ext.cx.translationlist.less @@ -17,11 +17,15 @@ z-index: 100; .cx-tlitem__actions__trigger { - font-size: larger; - font-weight: 800; - color: #565656; cursor: pointer; - padding: 0 5px; + padding: 12px; + .background-image-svg('../images/elipses.svg', '../images/elipses.png'); + background-repeat: no-repeat; + background-position: center left; + background-size: 24px; + &:hover { + background-color: #eee; + } } ul { -- To view, visit https://gerrit.wikimedia.org/r/278842 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id209db00dc9bdaed24a0da51af1592741d160d89 Gerrit-PatchSet: 4 Gerrit-Project: mediawiki/extensions/ContentTranslation Gerrit-Branch: master Gerrit-Owner: Santhosh Gerrit-Reviewer: Nikerabbit Gerrit-Reviewer: jenkins-bot <> ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Translation list: Replace the elipses text with icon - change (mediawiki...ContentTranslation)
Santhosh has uploaded a new change for review. https://gerrit.wikimedia.org/r/278842 Change subject: Translation list: Replace the elipses text with icon .. Translation list: Replace the elipses text with icon Change-Id: Id209db00dc9bdaed24a0da51af1592741d160d89 --- M modules/dashboard/ext.cx.translationlist.js A modules/dashboard/images/elipses.png A modules/dashboard/images/elipses.svg M modules/dashboard/styles/ext.cx.translationlist.less 4 files changed, 10 insertions(+), 6 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ContentTranslation refs/changes/42/278842/1 diff --git a/modules/dashboard/ext.cx.translationlist.js b/modules/dashboard/ext.cx.translationlist.js index 9977372..3267c7a 100644 --- a/modules/dashboard/ext.cx.translationlist.js +++ b/modules/dashboard/ext.cx.translationlist.js @@ -318,8 +318,7 @@ // If the translation is draft, allow deleting it if ( translation.status === 'draft' ) { $actionsTrigger = $( '' ) - .addClass( 'cx-tlitem__actions__trigger' ) - .text( '…' ); + .addClass( 'cx-tlitem__actions__trigger' ); $deleteTranslation = $( '' ) .addClass( 'cx-discard-translation' ) .text( mw.msg( 'cx-discard-translation' ) ); diff --git a/modules/dashboard/images/elipses.png b/modules/dashboard/images/elipses.png new file mode 100644 index 000..40d5f98 --- /dev/null +++ b/modules/dashboard/images/elipses.png Binary files differ diff --git a/modules/dashboard/images/elipses.svg b/modules/dashboard/images/elipses.svg new file mode 100644 index 000..98cc53d --- /dev/null +++ b/modules/dashboard/images/elipses.svg @@ -0,0 +1 @@ +http://www.w3.org/2000/svg"; viewBox="0 0 24 24"> diff --git a/modules/dashboard/styles/ext.cx.translationlist.less b/modules/dashboard/styles/ext.cx.translationlist.less index 1af370a..fa37514 100644 --- a/modules/dashboard/styles/ext.cx.translationlist.less +++ b/modules/dashboard/styles/ext.cx.translationlist.less @@ -17,11 +17,15 @@ z-index: 100; .cx-tlitem__actions__trigger { - font-size: larger; - font-weight: 800; - color: #565656; cursor: pointer; - padding: 0 5px; + padding:10px; + .background-image-svg('../images/elipses.svg', '../images/elipses.png'); + background-repeat: no-repeat; + background-position: center left; + background-size: 24px; + &:hover { + background-color: #eee; + } } ul { -- To view, visit https://gerrit.wikimedia.org/r/278842 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Id209db00dc9bdaed24a0da51af1592741d160d89 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/ContentTranslation Gerrit-Branch: master Gerrit-Owner: Santhosh ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits