[MediaWiki-commits] [Gerrit] Unset time limit after loop - change (wikimedia...crm)
XenoRyet has submitted this change and it was merged. Change subject: Unset time limit after loop .. Unset time limit after loop I was wondering if this was gonna act funny... I believe we're causing unit tests to time out. Change-Id: Id6eb3897d240698599b932a5e6c6c56a7667601b --- M sites/all/modules/offline2civicrm/ChecksFile.php 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: XenoRyet: Looks good to me, approved jenkins-bot: Verified diff --git a/sites/all/modules/offline2civicrm/ChecksFile.php b/sites/all/modules/offline2civicrm/ChecksFile.php index c8b098f..c92dbc3 100644 --- a/sites/all/modules/offline2civicrm/ChecksFile.php +++ b/sites/all/modules/offline2civicrm/ChecksFile.php @@ -101,6 +101,9 @@ } } + // Unset time limit. + set_time_limit( 0 ); + $message = t( "Checks import complete. @successful imported, @ignored ignored, not including @duplicates duplicates.", array( '@successful' => $num_successful, '@ignored' => $num_ignored, '@duplicates' => $num_duplicates ) ); ChecksImportLog::record( $message ); watchdog( 'offline2civicrm', $message, array(), WATCHDOG_INFO ); -- To view, visit https://gerrit.wikimedia.org/r/254075 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id6eb3897d240698599b932a5e6c6c56a7667601b Gerrit-PatchSet: 1 Gerrit-Project: wikimedia/fundraising/crm Gerrit-Branch: master Gerrit-Owner: Awight Gerrit-Reviewer: Cdentinger Gerrit-Reviewer: Ejegg Gerrit-Reviewer: XenoRyet Gerrit-Reviewer: jenkins-bot <> ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Unset time limit after loop - change (wikimedia...crm)
Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/254075 Change subject: Unset time limit after loop .. Unset time limit after loop I was wondering if this was gonna act funny... I believe we're causing unit tests to time out. Change-Id: Id6eb3897d240698599b932a5e6c6c56a7667601b --- M sites/all/modules/offline2civicrm/ChecksFile.php 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm refs/changes/75/254075/1 diff --git a/sites/all/modules/offline2civicrm/ChecksFile.php b/sites/all/modules/offline2civicrm/ChecksFile.php index c8b098f..c92dbc3 100644 --- a/sites/all/modules/offline2civicrm/ChecksFile.php +++ b/sites/all/modules/offline2civicrm/ChecksFile.php @@ -101,6 +101,9 @@ } } + // Unset time limit. + set_time_limit( 0 ); + $message = t( "Checks import complete. @successful imported, @ignored ignored, not including @duplicates duplicates.", array( '@successful' => $num_successful, '@ignored' => $num_ignored, '@duplicates' => $num_duplicates ) ); ChecksImportLog::record( $message ); watchdog( 'offline2civicrm', $message, array(), WATCHDOG_INFO ); -- To view, visit https://gerrit.wikimedia.org/r/254075 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Id6eb3897d240698599b932a5e6c6c56a7667601b Gerrit-PatchSet: 1 Gerrit-Project: wikimedia/fundraising/crm Gerrit-Branch: master Gerrit-Owner: Awight ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
