[MediaWiki-commits] [Gerrit] Update documentation for WebInstaller_DBConnect::execute() - change (mediawiki/core)

2013-12-28 Thread MarkAHershberger (Code Review) 
MarkAHershberger has submitted this change and it was merged.

Change subject: Update documentation for WebInstaller_DBConnect::execute()
..


Update documentation for WebInstaller_DBConnect::execute()

Change-Id: I7f700daf8c1dbf0903159a1b750612b09f0e8e25
---
M includes/installer/WebInstallerPage.php
1 file changed, 3 insertions(+), 1 deletion(-)

Approvals:
  MarkAHershberger: Looks good to me, approved



diff --git a/includes/installer/WebInstallerPage.php 
b/includes/installer/WebInstallerPage.php
index 1c95d9a..aa324de 100644
--- a/includes/installer/WebInstallerPage.php
+++ b/includes/installer/WebInstallerPage.php
@@ -454,7 +454,9 @@
 }
 
 class WebInstaller_DBConnect extends WebInstallerPage {
-
+   /**
+* @return string|void When string, skip or continue
+*/
public function execute() {
if ( $this-getVar( '_ExistingDBSettings' ) ) {
return 'skip';

-- 
To view, visit https://gerrit.wikimedia.org/r/104057
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7f700daf8c1dbf0903159a1b750612b09f0e8e25
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Siebrand siebr...@wikimedia.org
Gerrit-Reviewer: Chad ch...@wikimedia.org
Gerrit-Reviewer: MarkAHershberger mhershber...@wikimedia.org
Gerrit-Reviewer: Waldir wal...@email.com
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Update documentation for WebInstaller_DBConnect::execute() - change (mediawiki/core)

2013-12-27 Thread Siebrand (Code Review) 
Siebrand has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/104057


Change subject: Update documentation for WebInstaller_DBConnect::execute()
..

Update documentation for WebInstaller_DBConnect::execute()

Change-Id: I7f700daf8c1dbf0903159a1b750612b09f0e8e25
---
M includes/installer/WebInstallerPage.php
1 file changed, 3 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/57/104057/1

diff --git a/includes/installer/WebInstallerPage.php 
b/includes/installer/WebInstallerPage.php
index 1c95d9a..aa324de 100644
--- a/includes/installer/WebInstallerPage.php
+++ b/includes/installer/WebInstallerPage.php
@@ -454,7 +454,9 @@
 }
 
 class WebInstaller_DBConnect extends WebInstallerPage {
-
+   /**
+* @return string|void When string, skip or continue
+*/
public function execute() {
if ( $this-getVar( '_ExistingDBSettings' ) ) {
return 'skip';

-- 
To view, visit https://gerrit.wikimedia.org/r/104057
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7f700daf8c1dbf0903159a1b750612b09f0e8e25
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Siebrand siebr...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits