[MediaWiki-commits] [Gerrit] Update for newer jQuery - change (mediawiki...ApiSandbox)

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged.

Change subject: Update for newer jQuery
..


Update for newer jQuery

Change-Id: I64567dad87d271c6ba67219a7d5c01082f3c7adc
---
M resources/main.js
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Krinkle: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/resources/main.js b/resources/main.js
index 807428c..ab28cf8 100644
--- a/resources/main.js
+++ b/resources/main.js
@@ -604,7 +604,7 @@
}
} );
 
-   $( '#param-generator' ).live( 'change', updateGenerator );
+   $( document ).on( 'change', '#param-generator', updateGenerator 
);
 
function doHash() {
var hash = window.location.hash.replace( /^#/, '' );

-- 
To view, visit https://gerrit.wikimedia.org/r/133358
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I64567dad87d271c6ba67219a7d5c01082f3c7adc
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/ApiSandbox
Gerrit-Branch: master
Gerrit-Owner: MaxSem 
Gerrit-Reviewer: Bartosz Dziewoński 
Gerrit-Reviewer: Krinkle 
Gerrit-Reviewer: Reedy 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Update for newer jQuery - change (mediawiki...ApiSandbox)

[MaxSem (Code Review)]

MaxSem has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/133358

Change subject: Update for newer jQuery
..

Update for newer jQuery

Change-Id: I64567dad87d271c6ba67219a7d5c01082f3c7adc
---
M resources/main.js
1 file changed, 12 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ApiSandbox 
refs/changes/58/133358/1

diff --git a/resources/main.js b/resources/main.js
index 807428c..75788a8 100644
--- a/resources/main.js
+++ b/resources/main.js
@@ -11,6 +11,17 @@
$output, $postRow, $buttonsContainer, $examplesButton, 
$pageScroll,
UiBuilder = apiSandbox.UiBuilder;
 
+   function QueryUiBuilder( $container, info, prefix ) {
+   UiBuilder.call( this, $container, info, prefix );
+   }
+
+   $.extend( QueryUiBuilder.prototype, UiBuilder.prototype, {
+   createInputs: function() {
+   UiBuilder.prototype.createInputs.call( this );
+   $( '#param-generator' ).on( 'change', updateGenerator );
+   }
+   } );
+
/** Local utility functions **/
 
// get the first element in a list that is "scrollable"
@@ -589,7 +600,7 @@
paramInfo.modules.query.parameters = 
paramInfo.modules.query.parameters.slice( 3 );
$genericContainer = $( 
'#api-sandbox-generic-inputs > div' );
genericRequest = new UiBuilder( 
$genericContainer, { main: paramInfo.mainmodule }, '' );
-   queryRequest = new UiBuilder( $queryContainer, 
{ query: paramInfo.modules.query }, '' );
+   queryRequest = new QueryUiBuilder( 
$queryContainer, { query: paramInfo.modules.query }, '' );
},
function () {
}
@@ -603,8 +614,6 @@
updateUI();
}
} );
-
-   $( '#param-generator' ).live( 'change', updateGenerator );
 
function doHash() {
var hash = window.location.hash.replace( /^#/, '' );

-- 
To view, visit https://gerrit.wikimedia.org/r/133358
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I64567dad87d271c6ba67219a7d5c01082f3c7adc
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ApiSandbox
Gerrit-Branch: master
Gerrit-Owner: MaxSem 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits