[MediaWiki-commits] [Gerrit] Updating scalable default in MediaSizeWidget - change (VisualEditor/VisualEditor)

2014-05-09 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Updating scalable default in MediaSizeWidget
..


Updating scalable default in MediaSizeWidget

Updating defaults when scalable is attached to media size widget.
This makes sure the defaults are loaded initially; they will change
later by the scalable default change event.

h/t Roan for figuring this out.

Change-Id: Ie45419a9f88694484d072dbc28d451fdc0ba06c1
---
M modules/ve/ui/widgets/ve.ui.MediaSizeWidget.js
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Catrope: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/modules/ve/ui/widgets/ve.ui.MediaSizeWidget.js 
b/modules/ve/ui/widgets/ve.ui.MediaSizeWidget.js
index 1075bc8..1fa98b2 100644
--- a/modules/ve/ui/widgets/ve.ui.MediaSizeWidget.js
+++ b/modules/ve/ui/widgets/ve.ui.MediaSizeWidget.js
@@ -279,6 +279,7 @@
this.scalable.connect( this, { 'defaultSizeChange': 
'onScalableDefaultSizeChange' } );
// Reset current dimensions to new scalable object
this.setCurrentDimensions( this.scalable.getCurrentDimensions() );
+   this.updateDefaultDimensions();
 
// If we don't have original dimensions, disable the full size button
if ( !this.scalable.getOriginalDimensions() ) {

-- 
To view, visit https://gerrit.wikimedia.org/r/131617
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie45419a9f88694484d072dbc28d451fdc0ba06c1
Gerrit-PatchSet: 1
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Mooeypoo mor...@gmail.com
Gerrit-Reviewer: Catrope roan.katt...@gmail.com
Gerrit-Reviewer: Esanders esand...@wikimedia.org
Gerrit-Reviewer: jenkins-bot 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Updating scalable default in MediaSizeWidget - change (VisualEditor/VisualEditor)

2014-05-05 Thread Mooeypoo (Code Review) 
Mooeypoo has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/131617

Change subject: Updating scalable default in MediaSizeWidget
..

Updating scalable default in MediaSizeWidget

Updating defaults when scalable is attached to media size widget.
This makes sure the defaults are loaded initially; they will change
later by the scalable default change event.

h/t Roan for figuring this out.

Change-Id: Ie45419a9f88694484d072dbc28d451fdc0ba06c1
---
M modules/ve/ui/widgets/ve.ui.MediaSizeWidget.js
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/VisualEditor/VisualEditor 
refs/changes/17/131617/1

diff --git a/modules/ve/ui/widgets/ve.ui.MediaSizeWidget.js 
b/modules/ve/ui/widgets/ve.ui.MediaSizeWidget.js
index 1075bc8..1fa98b2 100644
--- a/modules/ve/ui/widgets/ve.ui.MediaSizeWidget.js
+++ b/modules/ve/ui/widgets/ve.ui.MediaSizeWidget.js
@@ -279,6 +279,7 @@
this.scalable.connect( this, { 'defaultSizeChange': 
'onScalableDefaultSizeChange' } );
// Reset current dimensions to new scalable object
this.setCurrentDimensions( this.scalable.getCurrentDimensions() );
+   this.updateDefaultDimensions();
 
// If we don't have original dimensions, disable the full size button
if ( !this.scalable.getOriginalDimensions() ) {

-- 
To view, visit https://gerrit.wikimedia.org/r/131617
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie45419a9f88694484d072dbc28d451fdc0ba06c1
Gerrit-PatchSet: 1
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Mooeypoo mor...@gmail.com

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits