[MediaWiki-commits] [Gerrit] UploadWizard doesn't need addModuleStyles - change (mediawiki...UploadWizard)
jenkins-bot has submitted this change and it was merged. Change subject: UploadWizard doesn't need addModuleStyles .. UploadWizard doesn't need addModuleStyles None of these styles seem to be required for the simple form displayed in no JS mode. Bug: T97410 Change-Id: I3bee430ac7ef19530c08391124259f83fd413bba --- M UploadWizardHooks.php M includes/specials/SpecialUploadWizard.php 2 files changed, 0 insertions(+), 2 deletions(-) Approvals: Bartosz Dziewoński: Looks good to me, approved jenkins-bot: Verified diff --git a/UploadWizardHooks.php b/UploadWizardHooks.php index 12a872c..b4c2e97 100644 --- a/UploadWizardHooks.php +++ b/UploadWizardHooks.php @@ -14,7 +14,6 @@ ), 'ext.uploadWizard' = array( - 'position' = 'top', 'dependencies' = array( 'jquery.arrowSteps', 'jquery.checkboxShiftClick', diff --git a/includes/specials/SpecialUploadWizard.php b/includes/specials/SpecialUploadWizard.php index 69b4da1..a0a122c 100644 --- a/includes/specials/SpecialUploadWizard.php +++ b/includes/specials/SpecialUploadWizard.php @@ -115,7 +115,6 @@ $this-addJsVars( $subPage ); // dependencies (css, js) - $out-addModuleStyles( 'ext.uploadWizard' ); $out-addModules( 'ext.uploadWizard.page' ); // where the uploadwizard will go -- To view, visit https://gerrit.wikimedia.org/r/209688 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3bee430ac7ef19530c08391124259f83fd413bba Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/UploadWizard Gerrit-Branch: master Gerrit-Owner: Gilles gdu...@wikimedia.org Gerrit-Reviewer: Bartosz Dziewoński matma@gmail.com Gerrit-Reviewer: MarkTraceur mtrac...@member.fsf.org Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] UploadWizard doesn't need addModuleStyles - change (mediawiki...UploadWizard)
Gilles has uploaded a new change for review. https://gerrit.wikimedia.org/r/209688 Change subject: UploadWizard doesn't need addModuleStyles .. UploadWizard doesn't need addModuleStyles None of these styles seem to be required for the simple form displayed in no JS mode. Bug: T97410 Change-Id: I3bee430ac7ef19530c08391124259f83fd413bba --- M UploadWizardHooks.php M includes/specials/SpecialUploadWizard.php 2 files changed, 0 insertions(+), 2 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/UploadWizard refs/changes/88/209688/1 diff --git a/UploadWizardHooks.php b/UploadWizardHooks.php index 12a872c..b4c2e97 100644 --- a/UploadWizardHooks.php +++ b/UploadWizardHooks.php @@ -14,7 +14,6 @@ ), 'ext.uploadWizard' = array( - 'position' = 'top', 'dependencies' = array( 'jquery.arrowSteps', 'jquery.checkboxShiftClick', diff --git a/includes/specials/SpecialUploadWizard.php b/includes/specials/SpecialUploadWizard.php index 69b4da1..a0a122c 100644 --- a/includes/specials/SpecialUploadWizard.php +++ b/includes/specials/SpecialUploadWizard.php @@ -115,7 +115,6 @@ $this-addJsVars( $subPage ); // dependencies (css, js) - $out-addModuleStyles( 'ext.uploadWizard' ); $out-addModules( 'ext.uploadWizard.page' ); // where the uploadwizard will go -- To view, visit https://gerrit.wikimedia.org/r/209688 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I3bee430ac7ef19530c08391124259f83fd413bba Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/UploadWizard Gerrit-Branch: master Gerrit-Owner: Gilles gdu...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
