[MediaWiki-commits] [Gerrit] Use StatementGuidParser instead of ClaimGuidParser - change (mediawiki...Wikibase)
jenkins-bot has submitted this change and it was merged. Change subject: Use StatementGuidParser instead of ClaimGuidParser .. Use StatementGuidParser instead of ClaimGuidParser Change-Id: Ife431ec7b98de49c0af0c0ccd40c2e606dc0fb9b --- M repo/includes/ChangeOp/ChangeOpFactoryProvider.php M repo/includes/ChangeOp/ChangeOpStatement.php M repo/includes/ChangeOp/ClaimChangeOpFactory.php M repo/includes/WikibaseRepo.php M repo/includes/api/GetClaims.php M repo/includes/api/ModifyClaim.php M repo/tests/phpunit/includes/ChangeOp/ChangeOpStatementTest.php M repo/tests/phpunit/includes/ChangeOp/ChangeOpTestMockProvider.php M repo/tests/phpunit/includes/WikibaseRepoTest.php 9 files changed, 30 insertions(+), 30 deletions(-) Approvals: Bene: Looks good to me, approved jenkins-bot: Verified diff --git a/repo/includes/ChangeOp/ChangeOpFactoryProvider.php b/repo/includes/ChangeOp/ChangeOpFactoryProvider.php index 2148f01..631c8be 100644 --- a/repo/includes/ChangeOp/ChangeOpFactoryProvider.php +++ b/repo/includes/ChangeOp/ChangeOpFactoryProvider.php @@ -3,7 +3,7 @@ namespace Wikibase\ChangeOp; use SiteLookup; -use Wikibase\DataModel\Claim\ClaimGuidParser; +use Wikibase\DataModel\Statement\StatementGuidParser; use Wikibase\Lib\ClaimGuidGenerator; use Wikibase\Lib\ClaimGuidValidator; use Wikibase\Validators\EntityConstraintProvider; @@ -36,7 +36,7 @@ private $guidValidator; /** -* @var ClaimGuidParser +* @var StatementGuidParser */ private $guidParser; @@ -59,7 +59,7 @@ * @param EntityConstraintProvider $constraintProvider * @param ClaimGuidGenerator $guidGenerator * @param ClaimGuidValidator $guidValidator -* @param ClaimGuidParser $guidParser +* @param StatementGuidParser $guidParser * @param SnakValidator $snakValidator * @param TermValidatorFactory $termValidatorFactory * @param SiteLookup $siteLookup @@ -68,7 +68,7 @@ EntityConstraintProvider $constraintProvider, ClaimGuidGenerator $guidGenerator, ClaimGuidValidator $guidValidator, - ClaimGuidParser $guidParser, + StatementGuidParser $guidParser, SnakValidator $snakValidator, TermValidatorFactory $termValidatorFactory, SiteLookup $siteLookup diff --git a/repo/includes/ChangeOp/ChangeOpStatement.php b/repo/includes/ChangeOp/ChangeOpStatement.php index 6adb591..8c12480 100644 --- a/repo/includes/ChangeOp/ChangeOpStatement.php +++ b/repo/includes/ChangeOp/ChangeOpStatement.php @@ -6,11 +6,11 @@ use OutOfBoundsException; use ValueValidators\Result; use Wikibase\DataModel\ByPropertyIdArray; -use Wikibase\DataModel\Claim\ClaimGuidParser; use Wikibase\DataModel\Entity\Entity; use Wikibase\DataModel\Entity\Item; use Wikibase\DataModel\Entity\Property; use Wikibase\DataModel\Statement\Statement; +use Wikibase\DataModel\Statement\StatementGuidParser; use Wikibase\DataModel\Statement\StatementList; use Wikibase\DataModel\Statement\StatementListProvider; use Wikibase\Lib\ClaimGuidGenerator; @@ -46,7 +46,7 @@ private $guidValidator; /** -* @var ClaimGuidParser +* @var StatementGuidParser */ private $guidParser; @@ -64,7 +64,7 @@ * @param Statement $statement * @param ClaimGuidGenerator $guidGenerator * @param ClaimGuidValidator $guidValidator -* @param ClaimGuidParser $guidParser +* @param StatementGuidParser $guidParser * @param SnakValidator $snakValidator * @param int|null $index Where the claim should be placed among the other claims. * @@ -74,7 +74,7 @@ Statement $statement, ClaimGuidGenerator $guidGenerator, ClaimGuidValidator $guidValidator, - ClaimGuidParser $guidParser, + StatementGuidParser $guidParser, SnakValidator $snakValidator, $index = null ) { diff --git a/repo/includes/ChangeOp/ClaimChangeOpFactory.php b/repo/includes/ChangeOp/ClaimChangeOpFactory.php index 845a56f..da5eb07 100644 --- a/repo/includes/ChangeOp/ClaimChangeOpFactory.php +++ b/repo/includes/ChangeOp/ClaimChangeOpFactory.php @@ -4,7 +4,7 @@ use InvalidArgumentException; use Wikibase\DataModel\Claim\Claim; -use Wikibase\DataModel\Claim\ClaimGuidParser; +use Wikibase\DataModel\Statement\StatementGuidParser; use Wikibase\DataModel\Snak\Snak; use Wikibase\DataModel\Statement\Statement; use Wikibase\Lib\ClaimGuidGenerator; @@ -30,7 +30,7 @@ private $guidValidator; /** -* @var ClaimGuidParser +* @var StatementGuidParser */ private $guidParser; @@ -42,13 +42,13 @@ /** * @param ClaimGuidGenerator $guidGenerator * @param ClaimGuidValidator
[MediaWiki-commits] [Gerrit] Use StatementGuidParser instead of ClaimGuidParser - change (mediawiki...Wikibase)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/220389 Change subject: Use StatementGuidParser instead of ClaimGuidParser .. Use StatementGuidParser instead of ClaimGuidParser Change-Id: Ife431ec7b98de49c0af0c0ccd40c2e606dc0fb9b --- M repo/includes/ChangeOp/ChangeOpClaim.php M repo/includes/ChangeOp/ChangeOpFactoryProvider.php M repo/includes/ChangeOp/ClaimChangeOpFactory.php M repo/includes/WikibaseRepo.php M repo/includes/api/GetClaims.php M repo/includes/api/ModifyClaim.php M repo/tests/phpunit/includes/ChangeOp/ChangeOpClaimTest.php M repo/tests/phpunit/includes/ChangeOp/ChangeOpTestMockProvider.php M repo/tests/phpunit/includes/WikibaseRepoTest.php 9 files changed, 30 insertions(+), 30 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase refs/changes/89/220389/1 diff --git a/repo/includes/ChangeOp/ChangeOpClaim.php b/repo/includes/ChangeOp/ChangeOpClaim.php index 415ad66..e5f7c2f 100644 --- a/repo/includes/ChangeOp/ChangeOpClaim.php +++ b/repo/includes/ChangeOp/ChangeOpClaim.php @@ -7,7 +7,7 @@ use ValueValidators\Result; use Wikibase\DataModel\ByPropertyIdArray; use Wikibase\DataModel\Claim\Claim; -use Wikibase\DataModel\Claim\ClaimGuidParser; +use Wikibase\DataModel\Statement\StatementGuidParser; use Wikibase\DataModel\Entity\Entity; use Wikibase\DataModel\Entity\Item; use Wikibase\DataModel\Entity\Property; @@ -46,7 +46,7 @@ private $guidValidator; /** -* @var ClaimGuidParser +* @var StatementGuidParser */ private $guidParser; @@ -64,7 +64,7 @@ * @param Claim $claim * @param ClaimGuidGenerator $guidGenerator * @param ClaimGuidValidator $guidValidator -* @param ClaimGuidParser $guidParser +* @param StatementGuidParser $guidParser * @param SnakValidator $snakValidator * @param int|null $index Where the claim should be placed among the other claims. * @@ -74,7 +74,7 @@ Claim $claim, ClaimGuidGenerator $guidGenerator, ClaimGuidValidator $guidValidator, - ClaimGuidParser $guidParser, + StatementGuidParser $guidParser, SnakValidator $snakValidator, $index = null ) { diff --git a/repo/includes/ChangeOp/ChangeOpFactoryProvider.php b/repo/includes/ChangeOp/ChangeOpFactoryProvider.php index 2148f01..631c8be 100644 --- a/repo/includes/ChangeOp/ChangeOpFactoryProvider.php +++ b/repo/includes/ChangeOp/ChangeOpFactoryProvider.php @@ -3,7 +3,7 @@ namespace Wikibase\ChangeOp; use SiteLookup; -use Wikibase\DataModel\Claim\ClaimGuidParser; +use Wikibase\DataModel\Statement\StatementGuidParser; use Wikibase\Lib\ClaimGuidGenerator; use Wikibase\Lib\ClaimGuidValidator; use Wikibase\Validators\EntityConstraintProvider; @@ -36,7 +36,7 @@ private $guidValidator; /** -* @var ClaimGuidParser +* @var StatementGuidParser */ private $guidParser; @@ -59,7 +59,7 @@ * @param EntityConstraintProvider $constraintProvider * @param ClaimGuidGenerator $guidGenerator * @param ClaimGuidValidator $guidValidator -* @param ClaimGuidParser $guidParser +* @param StatementGuidParser $guidParser * @param SnakValidator $snakValidator * @param TermValidatorFactory $termValidatorFactory * @param SiteLookup $siteLookup @@ -68,7 +68,7 @@ EntityConstraintProvider $constraintProvider, ClaimGuidGenerator $guidGenerator, ClaimGuidValidator $guidValidator, - ClaimGuidParser $guidParser, + StatementGuidParser $guidParser, SnakValidator $snakValidator, TermValidatorFactory $termValidatorFactory, SiteLookup $siteLookup diff --git a/repo/includes/ChangeOp/ClaimChangeOpFactory.php b/repo/includes/ChangeOp/ClaimChangeOpFactory.php index 332ccd6..8188c82 100644 --- a/repo/includes/ChangeOp/ClaimChangeOpFactory.php +++ b/repo/includes/ChangeOp/ClaimChangeOpFactory.php @@ -4,7 +4,7 @@ use InvalidArgumentException; use Wikibase\DataModel\Claim\Claim; -use Wikibase\DataModel\Claim\ClaimGuidParser; +use Wikibase\DataModel\Statement\StatementGuidParser; use Wikibase\DataModel\Snak\Snak; use Wikibase\DataModel\Statement\Statement; use Wikibase\Lib\ClaimGuidGenerator; @@ -30,7 +30,7 @@ private $guidValidator; /** -* @var ClaimGuidParser +* @var StatementGuidParser */ private $guidParser; @@ -42,13 +42,13 @@ /** * @param ClaimGuidGenerator $guidGenerator * @param ClaimGuidValidator $guidValidator -* @param ClaimGuidParser $guidParser +* @param StatementGuidParser $guidParser * @param SnakValidator $snakValidator