[MediaWiki-commits] [Gerrit] Use User::equals() - change (mediawiki...Gather)
jenkins-bot has submitted this change and it was merged. Change subject: Use User::equals() .. Use User::equals() Change-Id: I7fe3c1c9a7e798d6f063d4c10a1f05444682aacc --- M includes/specials/SpecialGather.php 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jdlrobson: Looks good to me, approved jenkins-bot: Verified diff --git a/includes/specials/SpecialGather.php b/includes/specials/SpecialGather.php index 917110d..3368353 100644 --- a/includes/specials/SpecialGather.php +++ b/includes/specials/SpecialGather.php @@ -164,7 +164,7 @@ * @return boolean */ private function isOwner( User $user ) { - return $this-getUser()-getName() == $user-getName(); + return $this-getUser()-equals( $user ); } // FIXME: Re-evaluate when UI supports editing image of collection. -- To view, visit https://gerrit.wikimedia.org/r/200109 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7fe3c1c9a7e798d6f063d4c10a1f05444682aacc Gerrit-PatchSet: 3 Gerrit-Project: mediawiki/extensions/Gather Gerrit-Branch: master Gerrit-Owner: Legoktm legoktm.wikipe...@gmail.com Gerrit-Reviewer: Jdlrobson jrob...@wikimedia.org Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Use User::equals() - change (mediawiki...Gather)
Legoktm has uploaded a new change for review. https://gerrit.wikimedia.org/r/200109 Change subject: Use User::equals() .. Use User::equals() Change-Id: I7fe3c1c9a7e798d6f063d4c10a1f05444682aacc --- M includes/specials/SpecialGather.php 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Gather refs/changes/09/200109/1 diff --git a/includes/specials/SpecialGather.php b/includes/specials/SpecialGather.php index ce216c6..f635e41 100644 --- a/includes/specials/SpecialGather.php +++ b/includes/specials/SpecialGather.php @@ -162,7 +162,7 @@ * @return boolean */ private function isOwner( User $user ) { - return $this-getUser()-getName() == $user-getName(); + return $this-getUser()-equals( $user ); } // FIXME: Re-evaluate when UI supports editing image of collection. -- To view, visit https://gerrit.wikimedia.org/r/200109 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I7fe3c1c9a7e798d6f063d4c10a1f05444682aacc Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Gather Gerrit-Branch: master Gerrit-Owner: Legoktm legoktm.wikipe...@gmail.com ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits