[MediaWiki-commits] [Gerrit] Use consistently window.location.href instead of location.href - change (mediawiki...Wikibase)

2014-08-16 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Use consistently window.location.href instead of location.href
..


Use consistently window.location.href instead of location.href

Change-Id: I43279c6219c58234046dbb8872ffe9ccd4f686cb
---
M repo/resources/wikibase.ui.entitysearch.js
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  WikidataJenkins: Verified
  Thiemo Mättig (WMDE): Looks good to me, approved
  jenkins-bot: Verified



diff --git a/repo/resources/wikibase.ui.entitysearch.js 
b/repo/resources/wikibase.ui.entitysearch.js
index 63cbb55..0950ef6 100644
--- a/repo/resources/wikibase.ui.entitysearch.js
+++ b/repo/resources/wikibase.ui.entitysearch.js
@@ -44,7 +44,7 @@
 /^key/.test( 
event.originalEvent.type )
 !( item instanceof 
$.ui.ooMenu.CustomItem )
) {
-   location.href = 
item.getEntityStub().url;
+   window.location.href = 
item.getEntityStub().url;
}
} );
 

-- 
To view, visit https://gerrit.wikimedia.org/r/154305
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I43279c6219c58234046dbb8872ffe9ccd4f686cb
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Gerrit Patch Uploader gerritpatchuploa...@gmail.com
Gerrit-Reviewer: Gerrit Patch Uploader gerritpatchuploa...@gmail.com
Gerrit-Reviewer: Thiemo Mättig (WMDE) thiemo.maet...@wikimedia.de
Gerrit-Reviewer: WikidataJenkins wikidata-servi...@wikimedia.de
Gerrit-Reviewer: jenkins-bot 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Use consistently window.location.href instead of location.href - change (mediawiki...Wikibase)

2014-08-15 Thread Gerrit Patch Uploader (Code Review) 
Gerrit Patch Uploader has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/154305

Change subject: Use consistently window.location.href instead of location.href
..

Use consistently window.location.href instead of location.href

Change-Id: I43279c6219c58234046dbb8872ffe9ccd4f686cb
---
M repo/resources/wikibase.ui.entitysearch.js
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase 
refs/changes/05/154305/1

diff --git a/repo/resources/wikibase.ui.entitysearch.js 
b/repo/resources/wikibase.ui.entitysearch.js
index 63cbb55..0950ef6 100644
--- a/repo/resources/wikibase.ui.entitysearch.js
+++ b/repo/resources/wikibase.ui.entitysearch.js
@@ -44,7 +44,7 @@
 /^key/.test( 
event.originalEvent.type )
 !( item instanceof 
$.ui.ooMenu.CustomItem )
) {
-   location.href = 
item.getEntityStub().url;
+   window.location.href = 
item.getEntityStub().url;
}
} );
 

-- 
To view, visit https://gerrit.wikimedia.org/r/154305
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I43279c6219c58234046dbb8872ffe9ccd4f686cb
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Gerrit Patch Uploader gerritpatchuploa...@gmail.com

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits