[MediaWiki-commits] [Gerrit] Use existing steps instead of execute_script - change (mediawiki...UniversalLanguageSelector)
Nikerabbit has uploaded a new change for review. https://gerrit.wikimedia.org/r/96977 Change subject: Use existing steps instead of execute_script .. Use existing steps instead of execute_script Change-Id: Ifb54a9162ac8b4b9c68aea1508081999ea7e7f6c --- M tests/browser/features/step_definitions/persistent_settings_steps.rb 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/UniversalLanguageSelector refs/changes/77/96977/1 diff --git a/tests/browser/features/step_definitions/persistent_settings_steps.rb b/tests/browser/features/step_definitions/persistent_settings_steps.rb index 104cd83..1d9a5a6 100644 --- a/tests/browser/features/step_definitions/persistent_settings_steps.rb +++ b/tests/browser/features/step_definitions/persistent_settings_steps.rb @@ -6,9 +6,9 @@ end Then(/^the selected input method for Malayalam is ml-inscript2$/) do - @browser.execute_script( - return $.parseJSON( mw.user.options.values['uls-preferences'] ).ime.imes.ml - ).should == 'ml-inscript2' + step 'I click on an input box' + step 'I should see the input method indicator' + step 'in it there must be an element with Malayalam text' end When(/^I select the ml-inscript2 input method in the panel$/) do -- To view, visit https://gerrit.wikimedia.org/r/96977 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ifb54a9162ac8b4b9c68aea1508081999ea7e7f6c Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/UniversalLanguageSelector Gerrit-Branch: master Gerrit-Owner: Nikerabbit niklas.laxst...@gmail.com ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Use existing steps instead of execute_script - change (mediawiki...UniversalLanguageSelector)
jenkins-bot has submitted this change and it was merged. Change subject: Use existing steps instead of execute_script .. Use existing steps instead of execute_script Change-Id: Ifb54a9162ac8b4b9c68aea1508081999ea7e7f6c --- M tests/browser/features/step_definitions/persistent_settings_steps.rb 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: KartikMistry: Looks good to me, approved jenkins-bot: Verified diff --git a/tests/browser/features/step_definitions/persistent_settings_steps.rb b/tests/browser/features/step_definitions/persistent_settings_steps.rb index 104cd83..1d9a5a6 100644 --- a/tests/browser/features/step_definitions/persistent_settings_steps.rb +++ b/tests/browser/features/step_definitions/persistent_settings_steps.rb @@ -6,9 +6,9 @@ end Then(/^the selected input method for Malayalam is ml-inscript2$/) do - @browser.execute_script( - return $.parseJSON( mw.user.options.values['uls-preferences'] ).ime.imes.ml - ).should == 'ml-inscript2' + step 'I click on an input box' + step 'I should see the input method indicator' + step 'in it there must be an element with Malayalam text' end When(/^I select the ml-inscript2 input method in the panel$/) do -- To view, visit https://gerrit.wikimedia.org/r/96977 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifb54a9162ac8b4b9c68aea1508081999ea7e7f6c Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/UniversalLanguageSelector Gerrit-Branch: master Gerrit-Owner: Nikerabbit niklas.laxst...@gmail.com Gerrit-Reviewer: KartikMistry kartik.mis...@gmail.com Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
