[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Remove comment about jscs binary space rule
jenkins-bot has submitted this change and it was merged. Change subject: Remove comment about jscs binary space rule .. Remove comment about jscs binary space rule This is correctly enforced in eslint. Change-Id: Ic2e77173fb2c0f6103096fcf2b17f9c69365b0e6 --- M tests/ve.test.js 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: Jforrester: Looks good to me, approved jenkins-bot: Verified diff --git a/tests/ve.test.js b/tests/ve.test.js index f62534e..366017a 100644 --- a/tests/ve.test.js +++ b/tests/ve.test.js @@ -297,7 +297,6 @@ } tests = [ /* jshint elision:true (awaiting eslint replacement; T149262) */ - // jscs:disable disallowSpaceBeforeBinaryOperators (awaiting eslint replacement; T149263) // arr, offset, remove, data, expectedReturn, expectedArray, msg [ [], 0, 0, [ , 3 ], [], [ , 3 ], 'insert empty, leading hole' ], [ [], 0, 0, [ 1, , 3 ], [], [ 1, , 3 ], 'insert empty, middle hole' ], @@ -318,7 +317,6 @@ [ [ 4, , 5, , 6 ], 0, 3, [ 1, , 3 ], [ 4, , 5 ], [ 1, , 3, , 6 ], 'diff=0 start' ], [ [ 4, , 5, , 6 ], 1, 3, [ 1, , 3 ], [ , 5, , ], [ 4, 1, , 3, 6 ], 'diff=0 mid' ], [ [ 4, , 5, , 6 ], 2, 3, [ 1, , 3 ], [ 5, , 6 ], [ 4, , 1, , 3 ], 'diff=0 end' ] - // jscs:enable disallowSpaceBeforeBinaryOperators /* jshint elision:false */ ]; QUnit.expect( 2 * tests.length + 1 ); -- To view, visit https://gerrit.wikimedia.org/r/318482 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic2e77173fb2c0f6103096fcf2b17f9c69365b0e6 Gerrit-PatchSet: 1 Gerrit-Project: VisualEditor/VisualEditor Gerrit-Branch: master Gerrit-Owner: Esanders Gerrit-Reviewer: Jforrester Gerrit-Reviewer: jenkins-bot <> ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Remove comment about jscs binary space rule
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/318482 Change subject: Remove comment about jscs binary space rule .. Remove comment about jscs binary space rule This is correctly enforced in eslint. Change-Id: Ic2e77173fb2c0f6103096fcf2b17f9c69365b0e6 --- M tests/ve.test.js 1 file changed, 0 insertions(+), 2 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/VisualEditor/VisualEditor refs/changes/82/318482/1 diff --git a/tests/ve.test.js b/tests/ve.test.js index f62534e..366017a 100644 --- a/tests/ve.test.js +++ b/tests/ve.test.js @@ -297,7 +297,6 @@ } tests = [ /* jshint elision:true (awaiting eslint replacement; T149262) */ - // jscs:disable disallowSpaceBeforeBinaryOperators (awaiting eslint replacement; T149263) // arr, offset, remove, data, expectedReturn, expectedArray, msg [ [], 0, 0, [ , 3 ], [], [ , 3 ], 'insert empty, leading hole' ], [ [], 0, 0, [ 1, , 3 ], [], [ 1, , 3 ], 'insert empty, middle hole' ], @@ -318,7 +317,6 @@ [ [ 4, , 5, , 6 ], 0, 3, [ 1, , 3 ], [ 4, , 5 ], [ 1, , 3, , 6 ], 'diff=0 start' ], [ [ 4, , 5, , 6 ], 1, 3, [ 1, , 3 ], [ , 5, , ], [ 4, 1, , 3, 6 ], 'diff=0 mid' ], [ [ 4, , 5, , 6 ], 2, 3, [ 1, , 3 ], [ 5, , 6 ], [ 4, , 1, , 3 ], 'diff=0 end' ] - // jscs:enable disallowSpaceBeforeBinaryOperators /* jshint elision:false */ ]; QUnit.expect( 2 * tests.length + 1 ); -- To view, visit https://gerrit.wikimedia.org/r/318482 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ic2e77173fb2c0f6103096fcf2b17f9c69365b0e6 Gerrit-PatchSet: 1 Gerrit-Project: VisualEditor/VisualEditor Gerrit-Branch: master Gerrit-Owner: Esanders ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
