[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Remove server-only scripts from visualEditor.rebase

2017-09-13 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/377768 )

Change subject: Remove server-only scripts from visualEditor.rebase
..


Remove server-only scripts from visualEditor.rebase

visualEditor.rebase is a client module. The server module
is rebaser.build, which already contains these scripts.

Adds rebaser.build to the test suite, but we should probably
remove ES6 code from client tests and test server code
separately.

Bug: T175828
Change-Id: I8fc55fa1ab437262240d00a30ab09765fc0ca240
---
M build/modules.json
M tests/index.html
2 files changed, 15 insertions(+), 7 deletions(-)

Approvals:
  DLynch: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/build/modules.json b/build/modules.json
index ee8f3bc..08ca219 100644
--- a/build/modules.json
+++ b/build/modules.json
@@ -641,9 +641,6 @@
},
"visualEditor.rebase": {
"scripts": [
-   "src/ve.utils-es6.js",
-   "src/dm/ve.dm.RebaseDocState.js",
-   "src/dm/ve.dm.RebaseServer.js",
"src/dm/ve.dm.RebaseClient.js",
"src/dm/ve.dm.SurfaceSynchronizer.js",
"src/ui/widgets/ve.ui.AuthorItemWidget.js",
@@ -779,7 +776,8 @@
"jsdifflib",
"qunit",
"visualEditor.desktop.standalone",
-   "visualEditor.rebase"
+   "visualEditor.rebase",
+   "rebaser.build"
]
},
"visualEditor.theme.apex": {
diff --git a/tests/index.html b/tests/index.html
index a62d4f0..55eede0 100644
--- a/tests/index.html
+++ b/tests/index.html
@@ -440,14 +440,24 @@

 

-   
-   
-   




 
+   
+   
+   
+   
+   
+   
+   
+   
+   
+   
+   
+   
+




-- 
To view, visit https://gerrit.wikimedia.org/r/377768
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8fc55fa1ab437262240d00a30ab09765fc0ca240
Gerrit-PatchSet: 3
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders 
Gerrit-Reviewer: DLynch 
Gerrit-Reviewer: Divec 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Remove server-only scripts from visualEditor.rebase

2017-09-13 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/377768 )

Change subject: Remove server-only scripts from visualEditor.rebase
..

Remove server-only scripts from visualEditor.rebase

visualEditor.rebase is a client module. The server module
is rebaser.build, which already contains these scripts.

Bug: T175828
Change-Id: I8fc55fa1ab437262240d00a30ab09765fc0ca240
---
M build/modules.json
M tests/index.html
2 files changed, 0 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/VisualEditor/VisualEditor 
refs/changes/68/377768/1

diff --git a/build/modules.json b/build/modules.json
index ee8f3bc..9076416 100644
--- a/build/modules.json
+++ b/build/modules.json
@@ -641,9 +641,6 @@
},
"visualEditor.rebase": {
"scripts": [
-   "src/ve.utils-es6.js",
-   "src/dm/ve.dm.RebaseDocState.js",
-   "src/dm/ve.dm.RebaseServer.js",
"src/dm/ve.dm.RebaseClient.js",
"src/dm/ve.dm.SurfaceSynchronizer.js",
"src/ui/widgets/ve.ui.AuthorItemWidget.js",
diff --git a/tests/index.html b/tests/index.html
index a62d4f0..fc5f5ae 100644
--- a/tests/index.html
+++ b/tests/index.html
@@ -440,9 +440,6 @@

 

-   
-   
-   




-- 
To view, visit https://gerrit.wikimedia.org/r/377768
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8fc55fa1ab437262240d00a30ab09765fc0ca240
Gerrit-PatchSet: 1
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits