[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Remove unit test hack, no longer needed.

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/329690 )

Change subject: Remove unit test hack, no longer needed.
..


Remove unit test hack, no longer needed.

Change-Id: Iff757ba0eac1efb76ce343f334470e8f733f649f
---
M src/dm/ve.dm.SurfaceSynchronizer.js
1 file changed, 1 insertion(+), 8 deletions(-)

Approvals:
  Bartosz Dziewoński: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/src/dm/ve.dm.SurfaceSynchronizer.js 
b/src/dm/ve.dm.SurfaceSynchronizer.js
index ed6fac7..ddacf20 100644
--- a/src/dm/ve.dm.SurfaceSynchronizer.js
+++ b/src/dm/ve.dm.SurfaceSynchronizer.js
@@ -35,11 +35,6 @@
// Whether we are currently synchronizing the model
this.applying = false;
 
-   // HACK: Disable in unit tests
-   if ( window.QUnit ) {
-   return;
-   }
-
// HACK
this.socket = io( ( config.server || '' ) + '/' + this.documentId );
this.socket.on( 'registered', this.onRegistered.bind( this ) );
@@ -197,9 +192,7 @@
this.setAuthor( author );
this.surface.setAuthor( this.author );
// HACK
-   if ( !window.QUnit ) {
-   $( '.ve-demo-editor' ).prepend( $( '' ).text( this.author ) );
-   }
+   $( '.ve-demo-editor' ).prepend( $( '' ).text( this.author ) );
 };
 
 /**

-- 
To view, visit https://gerrit.wikimedia.org/r/329690
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iff757ba0eac1efb76ce343f334470e8f733f649f
Gerrit-PatchSet: 2
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders 
Gerrit-Reviewer: Bartosz Dziewoński 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Remove unit test hack, no longer needed.

[Esanders (Code Review)]

Esanders has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/329690 )

Change subject: Remove unit test hack, no longer needed.
..

Remove unit test hack, no longer needed.

Change-Id: Iff757ba0eac1efb76ce343f334470e8f733f649f
---
M src/dm/ve.dm.SurfaceSynchronizer.js
1 file changed, 0 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/VisualEditor/VisualEditor 
refs/changes/90/329690/1

diff --git a/src/dm/ve.dm.SurfaceSynchronizer.js 
b/src/dm/ve.dm.SurfaceSynchronizer.js
index ed6fac7..c391a5d 100644
--- a/src/dm/ve.dm.SurfaceSynchronizer.js
+++ b/src/dm/ve.dm.SurfaceSynchronizer.js
@@ -35,11 +35,6 @@
// Whether we are currently synchronizing the model
this.applying = false;
 
-   // HACK: Disable in unit tests
-   if ( window.QUnit ) {
-   return;
-   }
-
// HACK
this.socket = io( ( config.server || '' ) + '/' + this.documentId );
this.socket.on( 'registered', this.onRegistered.bind( this ) );

-- 
To view, visit https://gerrit.wikimedia.org/r/329690
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iff757ba0eac1efb76ce343f334470e8f733f649f
Gerrit-PatchSet: 1
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits