[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Remove unused eslint exceptions and old jshint comments

2016-11-02 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Remove unused eslint exceptions and old jshint comments
..


Remove unused eslint exceptions and old jshint comments

Change-Id: I5140c7b1f949b9660b469d8add08c4235d32c460
---
M src/ui/actions/ve.ui.TableAction.js
M src/ui/dialogs/ve.ui.ProgressDialog.js
M src/ui/ve.ui.DebugBar.js
M tests/ui/dialogs/ve.ui.FindAndReplaceDialog.test.js
4 files changed, 0 insertions(+), 4 deletions(-)

Approvals:
  Jforrester: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/src/ui/actions/ve.ui.TableAction.js 
b/src/ui/actions/ve.ui.TableAction.js
index 68b711f..b764a4c 100644
--- a/src/ui/actions/ve.ui.TableAction.js
+++ b/src/ui/actions/ve.ui.TableAction.js
@@ -855,7 +855,6 @@
rowData.splice( 1, rowData.length - 2 );
removedMatrix[ row - minIndex ] = {
row: rowData,
-   // eslint-disable-next-line no-loop-func
cells: cells.map( function ( cell ) {
if ( cell && !cell.isPlaceholder() ) {
cell.data = 
documentModel.getData( cell.node.getOuterRange(), true );
diff --git a/src/ui/dialogs/ve.ui.ProgressDialog.js 
b/src/ui/dialogs/ve.ui.ProgressDialog.js
index 467a812..ba5cc7b 100644
--- a/src/ui/dialogs/ve.ui.ProgressDialog.js
+++ b/src/ui/dialogs/ve.ui.ProgressDialog.js
@@ -94,7 +94,6 @@
 
this.text.$element.append( $row );
progresses[ i ].progressBarDeferred.resolve( 
progressBar, cancelDeferred.promise() );
-   /* jshint loopfunc:true (awaiting eslint 
replacement; T149264) */
progresses[ i ].progressCompletePromise.then(
this.progressComplete.bind( this, $row, 
false ),
this.progressComplete.bind( this, $row, 
true )
diff --git a/src/ui/ve.ui.DebugBar.js b/src/ui/ve.ui.DebugBar.js
index 12c391f..743772f 100644
--- a/src/ui/ve.ui.DebugBar.js
+++ b/src/ui/ve.ui.DebugBar.js
@@ -211,7 +211,6 @@
$label.html( ( text.match( /\S/ ) ? text : ' ' ) + 
' ' );
if ( annotations ) {
$label.append(
-   // eslint-disable-next-line no-loop-func
$( '' ).text(
'[' + 
this.getSurface().getModel().getDocument().getStore().values( annotations 
).map( function ( ann ) {
return JSON.stringify( 
ann.getComparableObject() );
diff --git a/tests/ui/dialogs/ve.ui.FindAndReplaceDialog.test.js 
b/tests/ui/dialogs/ve.ui.FindAndReplaceDialog.test.js
index 9ad77ca..ed3f372 100644
--- a/tests/ui/dialogs/ve.ui.FindAndReplaceDialog.test.js
+++ b/tests/ui/dialogs/ve.ui.FindAndReplaceDialog.test.js
@@ -86,7 +86,6 @@
dialog.matchCaseToggle.setValue( !!cases[ i 
].matchCase );
dialog.regexToggle.setValue( !!cases[ i ].regex 
);
dialog.findText.setValue( cases[ i ].find );
-   /* jshint loopfunc:true */
ranges = dialog.fragments.map( function ( 
fragment ) {
return 
fragment.getSelection().getRange();
} );

-- 
To view, visit https://gerrit.wikimedia.org/r/319312
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5140c7b1f949b9660b469d8add08c4235d32c460
Gerrit-PatchSet: 1
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders 
Gerrit-Reviewer: Jforrester 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Remove unused eslint exceptions and old jshint comments

2016-11-02 Thread Esanders (Code Review) 
Esanders has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/319312

Change subject: Remove unused eslint exceptions and old jshint comments
..

Remove unused eslint exceptions and old jshint comments

Change-Id: I5140c7b1f949b9660b469d8add08c4235d32c460
---
M src/ui/actions/ve.ui.TableAction.js
M src/ui/dialogs/ve.ui.ProgressDialog.js
M src/ui/ve.ui.DebugBar.js
M tests/ui/dialogs/ve.ui.FindAndReplaceDialog.test.js
4 files changed, 0 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/VisualEditor/VisualEditor 
refs/changes/12/319312/1

diff --git a/src/ui/actions/ve.ui.TableAction.js 
b/src/ui/actions/ve.ui.TableAction.js
index 68b711f..b764a4c 100644
--- a/src/ui/actions/ve.ui.TableAction.js
+++ b/src/ui/actions/ve.ui.TableAction.js
@@ -855,7 +855,6 @@
rowData.splice( 1, rowData.length - 2 );
removedMatrix[ row - minIndex ] = {
row: rowData,
-   // eslint-disable-next-line no-loop-func
cells: cells.map( function ( cell ) {
if ( cell && !cell.isPlaceholder() ) {
cell.data = 
documentModel.getData( cell.node.getOuterRange(), true );
diff --git a/src/ui/dialogs/ve.ui.ProgressDialog.js 
b/src/ui/dialogs/ve.ui.ProgressDialog.js
index 467a812..ba5cc7b 100644
--- a/src/ui/dialogs/ve.ui.ProgressDialog.js
+++ b/src/ui/dialogs/ve.ui.ProgressDialog.js
@@ -94,7 +94,6 @@
 
this.text.$element.append( $row );
progresses[ i ].progressBarDeferred.resolve( 
progressBar, cancelDeferred.promise() );
-   /* jshint loopfunc:true (awaiting eslint 
replacement; T149264) */
progresses[ i ].progressCompletePromise.then(
this.progressComplete.bind( this, $row, 
false ),
this.progressComplete.bind( this, $row, 
true )
diff --git a/src/ui/ve.ui.DebugBar.js b/src/ui/ve.ui.DebugBar.js
index 12c391f..743772f 100644
--- a/src/ui/ve.ui.DebugBar.js
+++ b/src/ui/ve.ui.DebugBar.js
@@ -211,7 +211,6 @@
$label.html( ( text.match( /\S/ ) ? text : ' ' ) + 
' ' );
if ( annotations ) {
$label.append(
-   // eslint-disable-next-line no-loop-func
$( '' ).text(
'[' + 
this.getSurface().getModel().getDocument().getStore().values( annotations 
).map( function ( ann ) {
return JSON.stringify( 
ann.getComparableObject() );
diff --git a/tests/ui/dialogs/ve.ui.FindAndReplaceDialog.test.js 
b/tests/ui/dialogs/ve.ui.FindAndReplaceDialog.test.js
index 9ad77ca..ed3f372 100644
--- a/tests/ui/dialogs/ve.ui.FindAndReplaceDialog.test.js
+++ b/tests/ui/dialogs/ve.ui.FindAndReplaceDialog.test.js
@@ -86,7 +86,6 @@
dialog.matchCaseToggle.setValue( !!cases[ i 
].matchCase );
dialog.regexToggle.setValue( !!cases[ i ].regex 
);
dialog.findText.setValue( cases[ i ].find );
-   /* jshint loopfunc:true */
ranges = dialog.fragments.map( function ( 
fragment ) {
return 
fragment.getSelection().getRange();
} );

-- 
To view, visit https://gerrit.wikimedia.org/r/319312
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5140c7b1f949b9660b469d8add08c4235d32c460
Gerrit-PatchSet: 1
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits