Kaartic has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/398647 )
Change subject: Revert "Add tab and shift+tab to blocked triggers list" ...................................................................... Revert "Add tab and shift+tab to blocked triggers list" It seems that blocking tab and shift+tab does makes it hard to post comments /create posts using StructuredDiscussions when the user does that in "visual editing" mode[1]. As there doesn't seem to be much value in blocking 'Tab' don't block it. In case the user accidentally hit 'Tab' he could always get back using a 'Shift+Tab'. This reverts commit b89ea541f9579d30210a478231d8449812a6eb2c. [1]: cf. https://www.mediawiki.org/wiki/Topic:Tzmpo1gjj2gv2ugy Change-Id: I12ea52c6c3116c678293cc19b838681e4cc6d665 --- M src/ce/ve.ce.Surface.js 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/VisualEditor/VisualEditor refs/changes/47/398647/1 diff --git a/src/ce/ve.ce.Surface.js b/src/ce/ve.ce.Surface.js index ae35351..9b281a0 100644 --- a/src/ce/ve.ce.Surface.js +++ b/src/ce/ve.ce.Surface.js @@ -1221,8 +1221,8 @@ ve.ce.Surface.prototype.isBlockedTrigger = function ( trigger ) { var platformKey = ve.getSystemPlatform() === 'mac' ? 'mac' : 'pc', blocked = { - mac: [ 'meta+b', 'meta+i', 'meta+u', 'meta+z', 'meta+y', 'meta+shift+z', 'tab', 'shift+tab', 'meta+[', 'meta+]' ], - pc: [ 'ctrl+b', 'ctrl+i', 'ctrl+u', 'ctrl+z', 'ctrl+y', 'ctrl+shift+z', 'tab', 'shift+tab' ] + mac: [ 'meta+b', 'meta+i', 'meta+u', 'meta+z', 'meta+y', 'meta+shift+z', 'meta+[', 'meta+]'], + pc: [ 'ctrl+b', 'ctrl+i', 'ctrl+u', 'ctrl+z', 'ctrl+y', 'ctrl+shift+z' ] }; return blocked[ platformKey ].indexOf( trigger.toString() ) !== -1; -- To view, visit https://gerrit.wikimedia.org/r/398647 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I12ea52c6c3116c678293cc19b838681e4cc6d665 Gerrit-PatchSet: 1 Gerrit-Project: VisualEditor/VisualEditor Gerrit-Branch: master Gerrit-Owner: Kaartic <kaarticsivaraam91...@gmail.com> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
