[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: build: Upgrade grunt-eslint from 19.0.0 to 20.0.0

2017-07-18 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/362378 )

Change subject: build: Upgrade grunt-eslint from 19.0.0 to 20.0.0
..


build: Upgrade grunt-eslint from 19.0.0 to 20.0.0

Lots of indent fixes (some of them a little dubious), plus a few
unnecessary regex and quote character escapes.

Change-Id: I18e13186f34756ca9c75a6e64d7e78baa819c629
---
M package.json
M src/ce/keydownhandlers/ve.ce.LinearArrowKeyDownHandler.js
M src/ce/keydownhandlers/ve.ce.LinearDeleteKeyDownHandler.js
M src/ce/nodes/ve.ce.TableNode.js
M src/ce/ve.ce.ResizableNode.js
M src/ce/ve.ce.Surface.js
M src/ce/ve.ce.TextState.js
M src/dm/lineardata/ve.dm.ElementLinearData.js
M src/dm/ve.dm.Converter.js
M src/dm/ve.dm.IndexValueStore.js
M src/dm/ve.dm.MetaList.js
M src/dm/ve.dm.Scalable.js
M src/dm/ve.dm.TransactionBuilder.js
M src/dm/ve.dm.TransactionProcessor.js
M src/dm/ve.dm.VisualDiff.js
M src/init/sa/ve.init.sa.Platform.js
M src/ui/actions/ve.ui.LinkAction.js
M src/ui/contextitems/ve.ui.MergeCellsContextItem.js
M src/ui/ve.ui.Surface.js
M src/ui/widgets/ve.ui.LinkAnnotationWidget.js
M src/ui/widgets/ve.ui.MediaSizeWidget.js
M src/ve.Filibuster.js
M tests/ce/ve.ce.Surface.test.js
M tests/dm/ve.dm.RebaseServer.test.js
M tests/dm/ve.dm.SurfaceFragment.test.js
M tests/init/ve.init.sa.Platform.test.js
M tests/ui/ve.ui.DiffElement.test.js
M tests/ve.test.js
M tests/ve.test.utils.js
29 files changed, 392 insertions(+), 377 deletions(-)

Approvals:
  Esanders: Looks good to me, approved
  jenkins-bot: Verified
  Jforrester: Looks good to me, but someone else must approve



diff --git a/package.json b/package.json
index 9ac2929..6f26448 100644
--- a/package.json
+++ b/package.json
@@ -30,7 +30,7 @@
 "grunt-contrib-watch": "1.0.0",
 "grunt-css-url-embed": "1.10.0",
 "grunt-cssjanus": "0.4.0",
-"grunt-eslint": "19.0.0",
+"grunt-eslint": "20.0.0",
 "grunt-jsonlint": "1.1.0",
 "grunt-karma": "2.0.0",
 "grunt-stylelint": "0.8.0",
diff --git a/src/ce/keydownhandlers/ve.ce.LinearArrowKeyDownHandler.js 
b/src/ce/keydownhandlers/ve.ce.LinearArrowKeyDownHandler.js
index df3e3c0..26dd80a 100644
--- a/src/ce/keydownhandlers/ve.ce.LinearArrowKeyDownHandler.js
+++ b/src/ce/keydownhandlers/ve.ce.LinearArrowKeyDownHandler.js
@@ -186,8 +186,8 @@
}
newRange = (
afterDirection > 0 ?
-   viewNode.getOuterRange() :
-   viewNode.getOuterRange().flip()
+   viewNode.getOuterRange() :
+   viewNode.getOuterRange().flip()
);
} else {
// Check where the range has moved to
diff --git a/src/ce/keydownhandlers/ve.ce.LinearDeleteKeyDownHandler.js 
b/src/ce/keydownhandlers/ve.ce.LinearDeleteKeyDownHandler.js
index 71c9778..6a6d082 100644
--- a/src/ce/keydownhandlers/ve.ce.LinearDeleteKeyDownHandler.js
+++ b/src/ce/keydownhandlers/ve.ce.LinearDeleteKeyDownHandler.js
@@ -82,8 +82,8 @@
// then preventDefault
if (
direction > 0 ?
-   skipNode.classList.contains( 've-ce-nail-pre-open' ) :
-   skipNode.classList.contains( 've-ce-nail-post-close' )
+   skipNode.classList.contains( 
've-ce-nail-pre-open' ) :
+   skipNode.classList.contains( 
've-ce-nail-post-close' )
) {
position = ve.adjacentDomPosition(
position,
@@ -104,19 +104,19 @@
skipNode.classList &&
skipNode.classList.contains(
direction > 0 ?
-   've-ce-nail-pre-close' :
-   've-ce-nail-post-open'
+   've-ce-nail-pre-close' :
+   've-ce-nail-post-open'
) &&
( pairNode = (
direction > 0 ?
-   skipNode.previousSibling :
-   skipNode.nextSibling
+   skipNode.previousSibling :
+   skipNode.nextSibling
) ) &&
pairNode.classList &&
pairNode.classList.contains(
direction > 0 ?
-   've-ce-nail-post-open' :
-   've-ce-nail-pre-close'
+   've-ce-nail-post-open' :
+   've-ce-nail-pre-close'
)
) {
linkNode

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: build: Upgrade grunt-eslint from 19.0.0 to 20.0.0

2017-06-30 Thread Jforrester (Code Review) 
Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/362378 )

Change subject: build: Upgrade grunt-eslint from 19.0.0 to 20.0.0
..

build: Upgrade grunt-eslint from 19.0.0 to 20.0.0

Lots of indent fixes (some of them a little dubious), plus a few
unnecessary regex and quote character escapes.

Change-Id: I18e13186f34756ca9c75a6e64d7e78baa819c629
---
M package.json
M src/ce/keydownhandlers/ve.ce.LinearArrowKeyDownHandler.js
M src/ce/keydownhandlers/ve.ce.LinearDeleteKeyDownHandler.js
M src/ce/nodes/ve.ce.TableNode.js
M src/ce/ve.ce.ResizableNode.js
M src/ce/ve.ce.Surface.js
M src/ce/ve.ce.TextState.js
M src/dm/lineardata/ve.dm.ElementLinearData.js
M src/dm/ve.dm.Converter.js
M src/dm/ve.dm.IndexValueStore.js
M src/dm/ve.dm.MetaList.js
M src/dm/ve.dm.Scalable.js
M src/dm/ve.dm.TransactionBuilder.js
M src/dm/ve.dm.TransactionProcessor.js
M src/dm/ve.dm.VisualDiff.js
M src/init/sa/ve.init.sa.Platform.js
M src/ui/actions/ve.ui.LinkAction.js
M src/ui/contextitems/ve.ui.MergeCellsContextItem.js
M src/ui/ve.ui.Surface.js
M src/ui/widgets/ve.ui.LinkAnnotationWidget.js
M src/ui/widgets/ve.ui.MediaSizeWidget.js
M src/ve.Filibuster.js
M tests/ce/ve.ce.Surface.test.js
M tests/dm/ve.dm.RebaseServer.test.js
M tests/dm/ve.dm.SurfaceFragment.test.js
M tests/init/ve.init.sa.Platform.test.js
M tests/ui/ve.ui.DiffElement.test.js
M tests/ve.test.js
M tests/ve.test.utils.js
29 files changed, 155 insertions(+), 142 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/VisualEditor/VisualEditor 
refs/changes/78/362378/1

diff --git a/package.json b/package.json
index 2f7edd3..cdd4d2f 100644
--- a/package.json
+++ b/package.json
@@ -30,7 +30,7 @@
 "grunt-contrib-watch": "1.0.0",
 "grunt-css-url-embed": "1.10.0",
 "grunt-cssjanus": "0.4.0",
-"grunt-eslint": "19.0.0",
+"grunt-eslint": "20.0.0",
 "grunt-jsonlint": "1.1.0",
 "grunt-karma": "2.0.0",
 "grunt-stylelint": "0.7.0",
diff --git a/src/ce/keydownhandlers/ve.ce.LinearArrowKeyDownHandler.js 
b/src/ce/keydownhandlers/ve.ce.LinearArrowKeyDownHandler.js
index df3e3c0..26dd80a 100644
--- a/src/ce/keydownhandlers/ve.ce.LinearArrowKeyDownHandler.js
+++ b/src/ce/keydownhandlers/ve.ce.LinearArrowKeyDownHandler.js
@@ -186,8 +186,8 @@
}
newRange = (
afterDirection > 0 ?
-   viewNode.getOuterRange() :
-   viewNode.getOuterRange().flip()
+   viewNode.getOuterRange() :
+   viewNode.getOuterRange().flip()
);
} else {
// Check where the range has moved to
diff --git a/src/ce/keydownhandlers/ve.ce.LinearDeleteKeyDownHandler.js 
b/src/ce/keydownhandlers/ve.ce.LinearDeleteKeyDownHandler.js
index 71c9778..6a6d082 100644
--- a/src/ce/keydownhandlers/ve.ce.LinearDeleteKeyDownHandler.js
+++ b/src/ce/keydownhandlers/ve.ce.LinearDeleteKeyDownHandler.js
@@ -82,8 +82,8 @@
// then preventDefault
if (
direction > 0 ?
-   skipNode.classList.contains( 've-ce-nail-pre-open' ) :
-   skipNode.classList.contains( 've-ce-nail-post-close' )
+   skipNode.classList.contains( 
've-ce-nail-pre-open' ) :
+   skipNode.classList.contains( 
've-ce-nail-post-close' )
) {
position = ve.adjacentDomPosition(
position,
@@ -104,19 +104,19 @@
skipNode.classList &&
skipNode.classList.contains(
direction > 0 ?
-   've-ce-nail-pre-close' :
-   've-ce-nail-post-open'
+   've-ce-nail-pre-close' :
+   've-ce-nail-post-open'
) &&
( pairNode = (
direction > 0 ?
-   skipNode.previousSibling :
-   skipNode.nextSibling
+   skipNode.previousSibling :
+   skipNode.nextSibling
) ) &&
pairNode.classList &&
pairNode.classList.contains(
direction > 0 ?
-   've-ce-nail-post-open' :
-   've-ce-nail-pre-close'
+   've-ce-nail-post-open' :
+   've-ce-nail-pre-close'
)
) {
linkNode = skipNode.parentNode;
@@ -142,8 +142,8 @@