[MediaWiki-commits] [Gerrit] Wait some more for the close button to appear - change (mediawiki...MultimediaViewer)
Gilles has uploaded a new change for review. https://gerrit.wikimedia.org/r/133685 Change subject: Wait some more for the close button to appear .. Wait some more for the close button to appear During the warmup steps Media Viewer might take some time to open, which might be why the close button won't appear in less than 5 seconds Change-Id: I3b17d46c3343f2b1ff33aaaf55faa4adb71cb218 Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/618 --- M tests/browser/features/step_definitions/basic_mmv_navigation_steps.rb 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MultimediaViewer refs/changes/85/133685/1 diff --git a/tests/browser/features/step_definitions/basic_mmv_navigation_steps.rb b/tests/browser/features/step_definitions/basic_mmv_navigation_steps.rb index 2c56f94..5ce 100644 --- a/tests/browser/features/step_definitions/basic_mmv_navigation_steps.rb +++ b/tests/browser/features/step_definitions/basic_mmv_navigation_steps.rb @@ -28,7 +28,7 @@ end When(/^I close MMV$/) do - on(E2ETestPage).mmv_close_button_element.when_present.click + on(E2ETestPage).mmv_close_button_element.when_present(30).click end When(/^I press the browser back button$/) do -- To view, visit https://gerrit.wikimedia.org/r/133685 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I3b17d46c3343f2b1ff33aaaf55faa4adb71cb218 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/MultimediaViewer Gerrit-Branch: master Gerrit-Owner: Gilles gdu...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Wait some more for the close button to appear - change (mediawiki...MultimediaViewer)
jenkins-bot has submitted this change and it was merged. Change subject: Wait some more for the close button to appear .. Wait some more for the close button to appear During the warmup steps Media Viewer might take some time to open, which might be why the close button won't appear in less than 5 seconds Change-Id: I3b17d46c3343f2b1ff33aaaf55faa4adb71cb218 Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/618 --- M tests/browser/features/step_definitions/basic_mmv_navigation_steps.rb 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Gergő Tisza: Looks good to me, approved jenkins-bot: Verified diff --git a/tests/browser/features/step_definitions/basic_mmv_navigation_steps.rb b/tests/browser/features/step_definitions/basic_mmv_navigation_steps.rb index 2c56f94..5ce 100644 --- a/tests/browser/features/step_definitions/basic_mmv_navigation_steps.rb +++ b/tests/browser/features/step_definitions/basic_mmv_navigation_steps.rb @@ -28,7 +28,7 @@ end When(/^I close MMV$/) do - on(E2ETestPage).mmv_close_button_element.when_present.click + on(E2ETestPage).mmv_close_button_element.when_present(30).click end When(/^I press the browser back button$/) do -- To view, visit https://gerrit.wikimedia.org/r/133685 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3b17d46c3343f2b1ff33aaaf55faa4adb71cb218 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/MultimediaViewer Gerrit-Branch: master Gerrit-Owner: Gilles gdu...@wikimedia.org Gerrit-Reviewer: Gergő Tisza gti...@wikimedia.org Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
