[MediaWiki-commits] [Gerrit] Wikitech -- use "Header set" instead of "Header append" - change (operations/puppet)

2014-07-28 Thread Dzahn (Code Review)
Dzahn has submitted this change and it was merged.

Change subject: Wikitech -- use "Header set" instead of "Header append"
..


Wikitech -- use "Header set" instead of "Header append"

Per I3f317856 and I3b28b725, the consensus is to use
"Header set Strict-Transport-Security" instead of
"Header append Strict-Transport-Security".

Change-Id: Ic122c688cfa52d3a4c4ca94b64f3820c3ae832ad
---
M templates/apache/sites/wikitech.wikimedia.org.erb
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  jenkins-bot: Verified
  Dzahn: Looks good to me, approved



diff --git a/templates/apache/sites/wikitech.wikimedia.org.erb 
b/templates/apache/sites/wikitech.wikimedia.org.erb
index aae5eff..508b77c 100644
--- a/templates/apache/sites/wikitech.wikimedia.org.erb
+++ b/templates/apache/sites/wikitech.wikimedia.org.erb
@@ -47,7 +47,7 @@
 SSLCertificateKeyFile /etc/ssl/private/<%= @certificate %>.key
 SSLCACertificatePath /etc/ssl/certs/
 
-Header append Strict-Transport-Security "max-age=31536000"
+Header set Strict-Transport-Security "max-age=31536000"
 
 RedirectMatch ^/$ https://<%= @webserver_hostname %>/wiki/
 

-- 
To view, visit https://gerrit.wikimedia.org/r/149626
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic122c688cfa52d3a4c4ca94b64f3820c3ae832ad
Gerrit-PatchSet: 2
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Chmarkine 
Gerrit-Reviewer: Dzahn 
Gerrit-Reviewer: JanZerebecki 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Wikitech -- use "Header set" instead of "Header append" - change (operations/puppet)

2014-07-27 Thread Chmarkine (Code Review)
Chmarkine has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/149626

Change subject: Wikitech -- use "Header set" instead of "Header append"
..

Wikitech -- use "Header set" instead of "Header append"

Per I3f317856 and I3b28b725, the consensus is to use
"Header set Strict-Transport-Security" instead of
"Header append Strict-Transport-Security".

Change-Id: Ic122c688cfa52d3a4c4ca94b64f3820c3ae832ad
---
M templates/apache/sites/wikitech.wikimedia.org.erb
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/26/149626/1

diff --git a/templates/apache/sites/wikitech.wikimedia.org.erb 
b/templates/apache/sites/wikitech.wikimedia.org.erb
index 0a82573..cca9597 100644
--- a/templates/apache/sites/wikitech.wikimedia.org.erb
+++ b/templates/apache/sites/wikitech.wikimedia.org.erb
@@ -47,7 +47,7 @@
 SSLCertificateKeyFile /etc/ssl/private/<%= @certificate %>.key
 SSLCACertificatePath /etc/ssl/certs/
 
-Header append Strict-Transport-Security "max-age=31536000"
+Header set Strict-Transport-Security "max-age=31536000"
 
 RedirectMatch ^/$ https://<%= @webserver_hostname %>/wiki/
 

-- 
To view, visit https://gerrit.wikimedia.org/r/149626
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic122c688cfa52d3a4c4ca94b64f3820c3ae832ad
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Chmarkine 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits