[MediaWiki-commits] [Gerrit] Workaround for "Unable to determine IP" bug - change (mediawiki/vagrant)

2013-08-27 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged.

Change subject: Workaround for "Unable to determine IP" bug
..


Workaround for "Unable to determine IP" bug

A recent change to MediaWiki causes phpsh invocations to fail with an "Unable
to determine IP" error. This patch provides a temporary workaround.

Change-Id: Ib579708c2e17717e21911185be22ce9031ff6668
---
M LocalSettings.php
1 file changed, 8 insertions(+), 0 deletions(-)

Approvals:
  Ori.livneh: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/LocalSettings.php b/LocalSettings.php
index 60c4ae0..1e92935 100644
--- a/LocalSettings.php
+++ b/LocalSettings.php
@@ -67,3 +67,11 @@
glob( __DIR__ . '/settings.d/*.php' ) ) as $conffile ) {
include_once $conffile;
 }
+
+// XXX: Is this a bug in core? (ori-l, 27-Aug-2013)
+$wgHooks['GetIP'][] = function ( &$ip ) {
+   if ( PHP_SAPI === 'cli' ) {
+   $ip = '127.0.0.1';
+   }
+   return true;
+};

-- 
To view, visit https://gerrit.wikimedia.org/r/81200
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib579708c2e17717e21911185be22ce9031ff6668
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/vagrant
Gerrit-Branch: master
Gerrit-Owner: Ori.livneh 
Gerrit-Reviewer: Ori.livneh 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Workaround for "Unable to determine IP" bug - change (mediawiki/vagrant)

2013-08-27 Thread Ori.livneh (Code Review)
Ori.livneh has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/81200


Change subject: Workaround for "Unable to determine IP" bug
..

Workaround for "Unable to determine IP" bug

A recent change to MediaWiki causes phpsh invocations to fail with an "Unable
to determine IP" error. This patch provides a temporary workaround.

Change-Id: Ib579708c2e17717e21911185be22ce9031ff6668
---
M LocalSettings.php
1 file changed, 8 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/vagrant 
refs/changes/00/81200/1

diff --git a/LocalSettings.php b/LocalSettings.php
index 60c4ae0..1e92935 100644
--- a/LocalSettings.php
+++ b/LocalSettings.php
@@ -67,3 +67,11 @@
glob( __DIR__ . '/settings.d/*.php' ) ) as $conffile ) {
include_once $conffile;
 }
+
+// XXX: Is this a bug in core? (ori-l, 27-Aug-2013)
+$wgHooks['GetIP'][] = function ( &$ip ) {
+   if ( PHP_SAPI === 'cli' ) {
+   $ip = '127.0.0.1';
+   }
+   return true;
+};

-- 
To view, visit https://gerrit.wikimedia.org/r/81200
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib579708c2e17717e21911185be22ce9031ff6668
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/vagrant
Gerrit-Branch: master
Gerrit-Owner: Ori.livneh 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits