[MediaWiki-commits] [Gerrit] add bundle info utils and fix About page - change (apps...wikipedia)

2015-05-01 Thread Fjalapeno (Code Review) 
Fjalapeno has submitted this change and it was merged.

Change subject: add bundle info utils and fix About page
..


add bundle info utils and fix About page

The About page was only showing the build number, not the entire
version. So, I wrote some categories to show either the release
version (e.g. 4.1.3) for release builds and debug version (4.1.3.96)
for debug builds.

Screenshots:
- debug: 
https://www.dropbox.com/s/154vw45gkt78dn0/debug%20build%20about.png?dl=0
- release: 
https://www.dropbox.com/s/vzgd9sj7rvp6mki/release%20build%20about.png?dl=0

Bug: T97810
Change-Id: I1fa0277214e671520d555a6a3c7816edeee1c93d
---
M Wikipedia.xcodeproj/project.pbxproj
A Wikipedia/Categories/NSBundle+WMFInfoUtils.h
A Wikipedia/Categories/NSBundle+WMFInfoUtils.m
M Wikipedia/View Controllers/About/AboutViewController.m
M Wikipedia/mw-utils/WikipediaAppUtils.m
5 files changed, 86 insertions(+), 7 deletions(-)

Approvals:
  Fjalapeno: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/Wikipedia.xcodeproj/project.pbxproj 
b/Wikipedia.xcodeproj/project.pbxproj
index df0f578..ee16ed9 100644
--- a/Wikipedia.xcodeproj/project.pbxproj
+++ b/Wikipedia.xcodeproj/project.pbxproj
@@ -241,6 +241,7 @@
BCA9575D1ABE473800B62AE8 /* OldDataSchemaMigratorTests.m in 
Sources */ = {isa = PBXBuildFile; fileRef = BCA9575C1ABE473800B62AE8 /* 
OldDataSchemaMigratorTests.m */; };
BCA96E731AAA354D009A61FA /* WMFGradientView.m in Sources */ = 
{isa = PBXBuildFile; fileRef = BCA96E721AAA354D009A61FA /* WMFGradientView.m 
*/; };
BCA96E771AAA35EE009A61FA /* UIView+WMFDefaultNib.m in Sources 
*/ = {isa = PBXBuildFile; fileRef = BCA96E761AAA35EE009A61FA /* 
UIView+WMFDefaultNib.m */; };
+   BCAC50C11AF3F7460015936C /* NSBundle+WMFInfoUtils.m in Sources 
*/ = {isa = PBXBuildFile; fileRef = BCAC50C01AF3F7460015936C /* 
NSBundle+WMFInfoUtils.m */; };
BCB3AE861AC11320004AD205 /* 
NSPersistentStoreCoordinator+WMFTempCoordinator.m in Sources */ = {isa = 
PBXBuildFile; fileRef = BCB3AE851AC11320004AD205 /* 
NSPersistentStoreCoordinator+WMFTempCoordinator.m */; };
BCB3AE8A1AC11458004AD205 /* 
NSManagedObjectContext+WMFTempContext.m in Sources */ = {isa = PBXBuildFile; 
fileRef = BCB3AE891AC11458004AD205 /* NSManagedObjectContext+WMFTempContext.m 
*/; };
BCB3AEA71AC1DDE4004AD205 /* OldDataSchemaMigrator.m in Sources 
*/ = {isa = PBXBuildFile; fileRef = BCB3AEA61AC1DDE4004AD205 /* 
OldDataSchemaMigrator.m */; };
@@ -785,6 +786,8 @@
BCA96E721AAA354D009A61FA /* WMFGradientView.m */ = {isa = 
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path 
= WMFGradientView.m; sourceTree = group; };
BCA96E751AAA35EE009A61FA /* UIView+WMFDefaultNib.h */ = {isa = 
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = 
UIView+WMFDefaultNib.h; sourceTree = group; };
BCA96E761AAA35EE009A61FA /* UIView+WMFDefaultNib.m */ = {isa = 
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path 
= UIView+WMFDefaultNib.m; sourceTree = group; };
+   BCAC50BF1AF3F7460015936C /* NSBundle+WMFInfoUtils.h */ = {isa = 
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = 
NSBundle+WMFInfoUtils.h; sourceTree = group; };
+   BCAC50C01AF3F7460015936C /* NSBundle+WMFInfoUtils.m */ = {isa = 
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path 
= NSBundle+WMFInfoUtils.m; sourceTree = group; };
BCB3AE841AC11320004AD205 /* 
NSPersistentStoreCoordinator+WMFTempCoordinator.h */ = {isa = PBXFileReference; 
fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = 
NSPersistentStoreCoordinator+WMFTempCoordinator.h; sourceTree = group; };
BCB3AE851AC11320004AD205 /* 
NSPersistentStoreCoordinator+WMFTempCoordinator.m */ = {isa = PBXFileReference; 
fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = 
NSPersistentStoreCoordinator+WMFTempCoordinator.m; sourceTree = group; };
BCB3AE881AC11458004AD205 /* 
NSManagedObjectContext+WMFTempContext.h */ = {isa = PBXFileReference; 
fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = 
NSManagedObjectContext+WMFTempContext.h; sourceTree = group; };
@@ -1879,6 +1882,8 @@
0EBC567E1AD442CC00E82CDD /* 
BITHockeyManager+WMFExtensions.m */,
04B0E3E81AE8252800379AE0 /* NSURL+WMFRest.h */,
04B0E3E91AE8252800379AE0 /* NSURL+WMFRest.m */,
+   BCAC50BF1AF3F7460015936C /* 
NSBundle+WMFInfoUtils.h */,
+   BCAC50C01AF3F7460015936C /* 
NSBundle+WMFInfoUtils.m */,
);
path = Categories;
sourceTree = group;
@@

[MediaWiki-commits] [Gerrit] add bundle info utils and fix About page - change (apps...wikipedia)

2015-05-01 Thread Bgerstle (Code Review) 
Bgerstle has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/208165

Change subject: add bundle info utils and fix About page
..

add bundle info utils and fix About page

The About page was only showing the build number, not the entire
version. So, I wrote some categories to show either the release
version (e.g. 4.1.3) for release builds and debug version (4.1.3.96)
for debug builds.

Screenshots:
- debug: 
https://www.dropbox.com/s/154vw45gkt78dn0/debug%20build%20about.png?dl=0
- release: 
https://www.dropbox.com/s/vzgd9sj7rvp6mki/release%20build%20about.png?dl=0

Bug: T97810
Change-Id: I1fa0277214e671520d555a6a3c7816edeee1c93d
---
M Wikipedia.xcodeproj/project.pbxproj
A Wikipedia/Categories/NSBundle+WMFInfoUtils.h
A Wikipedia/Categories/NSBundle+WMFInfoUtils.m
M Wikipedia/View Controllers/About/AboutViewController.m
M Wikipedia/mw-utils/WikipediaAppUtils.m
5 files changed, 86 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/apps/ios/wikipedia 
refs/changes/65/208165/1

diff --git a/Wikipedia.xcodeproj/project.pbxproj 
b/Wikipedia.xcodeproj/project.pbxproj
index df0f578..ee16ed9 100644
--- a/Wikipedia.xcodeproj/project.pbxproj
+++ b/Wikipedia.xcodeproj/project.pbxproj
@@ -241,6 +241,7 @@
BCA9575D1ABE473800B62AE8 /* OldDataSchemaMigratorTests.m in 
Sources */ = {isa = PBXBuildFile; fileRef = BCA9575C1ABE473800B62AE8 /* 
OldDataSchemaMigratorTests.m */; };
BCA96E731AAA354D009A61FA /* WMFGradientView.m in Sources */ = 
{isa = PBXBuildFile; fileRef = BCA96E721AAA354D009A61FA /* WMFGradientView.m 
*/; };
BCA96E771AAA35EE009A61FA /* UIView+WMFDefaultNib.m in Sources 
*/ = {isa = PBXBuildFile; fileRef = BCA96E761AAA35EE009A61FA /* 
UIView+WMFDefaultNib.m */; };
+   BCAC50C11AF3F7460015936C /* NSBundle+WMFInfoUtils.m in Sources 
*/ = {isa = PBXBuildFile; fileRef = BCAC50C01AF3F7460015936C /* 
NSBundle+WMFInfoUtils.m */; };
BCB3AE861AC11320004AD205 /* 
NSPersistentStoreCoordinator+WMFTempCoordinator.m in Sources */ = {isa = 
PBXBuildFile; fileRef = BCB3AE851AC11320004AD205 /* 
NSPersistentStoreCoordinator+WMFTempCoordinator.m */; };
BCB3AE8A1AC11458004AD205 /* 
NSManagedObjectContext+WMFTempContext.m in Sources */ = {isa = PBXBuildFile; 
fileRef = BCB3AE891AC11458004AD205 /* NSManagedObjectContext+WMFTempContext.m 
*/; };
BCB3AEA71AC1DDE4004AD205 /* OldDataSchemaMigrator.m in Sources 
*/ = {isa = PBXBuildFile; fileRef = BCB3AEA61AC1DDE4004AD205 /* 
OldDataSchemaMigrator.m */; };
@@ -785,6 +786,8 @@
BCA96E721AAA354D009A61FA /* WMFGradientView.m */ = {isa = 
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path 
= WMFGradientView.m; sourceTree = group; };
BCA96E751AAA35EE009A61FA /* UIView+WMFDefaultNib.h */ = {isa = 
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = 
UIView+WMFDefaultNib.h; sourceTree = group; };
BCA96E761AAA35EE009A61FA /* UIView+WMFDefaultNib.m */ = {isa = 
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path 
= UIView+WMFDefaultNib.m; sourceTree = group; };
+   BCAC50BF1AF3F7460015936C /* NSBundle+WMFInfoUtils.h */ = {isa = 
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = 
NSBundle+WMFInfoUtils.h; sourceTree = group; };
+   BCAC50C01AF3F7460015936C /* NSBundle+WMFInfoUtils.m */ = {isa = 
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path 
= NSBundle+WMFInfoUtils.m; sourceTree = group; };
BCB3AE841AC11320004AD205 /* 
NSPersistentStoreCoordinator+WMFTempCoordinator.h */ = {isa = PBXFileReference; 
fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = 
NSPersistentStoreCoordinator+WMFTempCoordinator.h; sourceTree = group; };
BCB3AE851AC11320004AD205 /* 
NSPersistentStoreCoordinator+WMFTempCoordinator.m */ = {isa = PBXFileReference; 
fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = 
NSPersistentStoreCoordinator+WMFTempCoordinator.m; sourceTree = group; };
BCB3AE881AC11458004AD205 /* 
NSManagedObjectContext+WMFTempContext.h */ = {isa = PBXFileReference; 
fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = 
NSManagedObjectContext+WMFTempContext.h; sourceTree = group; };
@@ -1879,6 +1882,8 @@
0EBC567E1AD442CC00E82CDD /* 
BITHockeyManager+WMFExtensions.m */,
04B0E3E81AE8252800379AE0 /* NSURL+WMFRest.h */,
04B0E3E91AE8252800379AE0 /* NSURL+WMFRest.m */,
+   BCAC50BF1AF3F7460015936C /* 
NSBundle+WMFInfoUtils.h */,
+   BCAC50C01AF3F7460015936C /* 
NSBundle+WMFInfoUtils.m */,
);
path = Categories;