[MediaWiki-commits] [Gerrit] adds Phobject to extend classes - change (phabricator...Sprint)

[Christopher Johnson (WMDE) (Code Review)]

Christopher Johnson (WMDE) has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/224763

Change subject: adds Phobject to extend classes
..

adds Phobject to extend classes

Change-Id: I7a1f4e05ed9a5b92d2e3af4c7d482171b2af6347
---
M src/util/BurndownDataDate.php
M src/util/SprintBoardCardToken.php
M src/util/SprintPoints.php
M src/util/SprintValidator.php
M src/view/SprintBoardTaskCard.php
M src/view/SprintListTableView.php
M src/view/burndown/BoardDataPieView.php
M src/view/burndown/BoardDataTableView.php
M src/view/burndown/BurndownChartView.php
M src/view/burndown/EventTableView.php
M src/view/burndown/TasksTableView.php
11 files changed, 14 insertions(+), 14 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/phabricator/extensions/Sprint 
refs/changes/63/224763/1

diff --git a/src/util/BurndownDataDate.php b/src/util/BurndownDataDate.php
index 6c736d6..2d6eb7c 100644
--- a/src/util/BurndownDataDate.php
+++ b/src/util/BurndownDataDate.php
@@ -5,7 +5,7 @@
  * @license GPL version 3
  */
 
-final class BurndownDataDate {
+final class BurndownDataDate extends Phobject {
 
   private $date;
   private $tasks_added_today;
diff --git a/src/util/SprintBoardCardToken.php 
b/src/util/SprintBoardCardToken.php
index 0e8a886..ea3e677 100644
--- a/src/util/SprintBoardCardToken.php
+++ b/src/util/SprintBoardCardToken.php
@@ -1,6 +1,6 @@
 ?php
 
-final class SprintBoardCardToken {
+final class SprintBoardCardToken extends Phobject {
   private $viewer;
 
   public function setViewer ($viewer) {
diff --git a/src/util/SprintPoints.php b/src/util/SprintPoints.php
index 6c4f8f2..ea3c7a3 100644
--- a/src/util/SprintPoints.php
+++ b/src/util/SprintPoints.php
@@ -1,6 +1,6 @@
 ?php
 
-final class SprintPoints {
+final class SprintPoints extends Phobject {
 
 private $taskpoints;
 private $task_open_status_sum;
diff --git a/src/util/SprintValidator.php b/src/util/SprintValidator.php
index 863a671..c8fd8ef 100644
--- a/src/util/SprintValidator.php
+++ b/src/util/SprintValidator.php
@@ -1,6 +1,6 @@
 ?php
 
-final class SprintValidator {
+final class SprintValidator extends Phobject {
 
   public function checkForSprint($showfields, $project_phid) {
 $show = $showfields($project_phid);
diff --git a/src/view/SprintBoardTaskCard.php b/src/view/SprintBoardTaskCard.php
index b971dd6..a3614c5 100644
--- a/src/view/SprintBoardTaskCard.php
+++ b/src/view/SprintBoardTaskCard.php
@@ -1,6 +1,6 @@
 ?php
 
-final class SprintBoardTaskCard {
+final class SprintBoardTaskCard extends Phobject {
 
   private $project;
   private $viewer;
diff --git a/src/view/SprintListTableView.php b/src/view/SprintListTableView.php
index 95553cc..b3e250b 100644
--- a/src/view/SprintListTableView.php
+++ b/src/view/SprintListTableView.php
@@ -1,6 +1,6 @@
 ?php
 
-final class SprintListTableView {
+final class SprintListTableView extends Phobject {
 
   private $tableData;
 
diff --git a/src/view/burndown/BoardDataPieView.php 
b/src/view/burndown/BoardDataPieView.php
index a2b5d85..757a4ef 100644
--- a/src/view/burndown/BoardDataPieView.php
+++ b/src/view/burndown/BoardDataPieView.php
@@ -1,6 +1,6 @@
 ?php
 
-final class BoardDataPieView {
+final class BoardDataPieView extends Phobject{
 
   private $boardData;
 
diff --git a/src/view/burndown/BoardDataTableView.php 
b/src/view/burndown/BoardDataTableView.php
index 50f046d..b185f2c 100644
--- a/src/view/burndown/BoardDataTableView.php
+++ b/src/view/burndown/BoardDataTableView.php
@@ -1,6 +1,6 @@
 ?php
 
-final class BoardDataTableView {
+final class BoardDataTableView extends Phobject{
 
   private $boardData;
 
@@ -21,7 +21,7 @@
 
 $box = id(new PHUIObjectBoxView())
 -setHeaderText(pht('Board Column List'))
--appendChild($table);
+-setTable($table);
 return $box;
   }
 }
diff --git a/src/view/burndown/BurndownChartView.php 
b/src/view/burndown/BurndownChartView.php
index eae5047..9d4583e 100644
--- a/src/view/burndown/BurndownChartView.php
+++ b/src/view/burndown/BurndownChartView.php
@@ -1,6 +1,6 @@
 ?php
 
-final class BurndownChartView {
+final class BurndownChartView extends Phobject{
   private $data;
 
   public function setChartData($chart_data) {
diff --git a/src/view/burndown/EventTableView.php 
b/src/view/burndown/EventTableView.php
index d8cabdd..2c036c0 100644
--- a/src/view/burndown/EventTableView.php
+++ b/src/view/burndown/EventTableView.php
@@ -1,6 +1,6 @@
 ?php
 
-final class EventTableView {
+final class EventTableView extends Phobject{
   private $project;
   private $viewer;
   private $request;
@@ -66,7 +66,7 @@
 ));
 $box = id(new PHUIObjectBoxView())
 -setHeaderText(pht('Events related to this sprint'))
--appendChild($table);
+-setTable($table);
 
 return $box;
   }
diff --git a/src/view/burndown/TasksTableView.php 
b/src/view/burndown/TasksTableView.php
index 51aa305..ba35d7a 100644
--- 

[MediaWiki-commits] [Gerrit] adds Phobject to extend classes - change (phabricator...Sprint)

[Christopher Johnson (WMDE) (Code Review)]

Christopher Johnson (WMDE) has submitted this change and it was merged.

Change subject: adds Phobject to extend classes
..


adds Phobject to extend classes

Change-Id: I7a1f4e05ed9a5b92d2e3af4c7d482171b2af6347
---
M src/util/BurndownDataDate.php
M src/util/SprintBoardCardToken.php
M src/util/SprintPoints.php
M src/util/SprintValidator.php
M src/view/SprintBoardTaskCard.php
M src/view/SprintListTableView.php
M src/view/burndown/BoardDataPieView.php
M src/view/burndown/BoardDataTableView.php
M src/view/burndown/BurndownChartView.php
M src/view/burndown/EventTableView.php
M src/view/burndown/TasksTableView.php
11 files changed, 14 insertions(+), 14 deletions(-)

Approvals:
  Christopher Johnson (WMDE): Verified; Looks good to me, approved



diff --git a/src/util/BurndownDataDate.php b/src/util/BurndownDataDate.php
index 6c736d6..2d6eb7c 100644
--- a/src/util/BurndownDataDate.php
+++ b/src/util/BurndownDataDate.php
@@ -5,7 +5,7 @@
  * @license GPL version 3
  */
 
-final class BurndownDataDate {
+final class BurndownDataDate extends Phobject {
 
   private $date;
   private $tasks_added_today;
diff --git a/src/util/SprintBoardCardToken.php 
b/src/util/SprintBoardCardToken.php
index 0e8a886..ea3e677 100644
--- a/src/util/SprintBoardCardToken.php
+++ b/src/util/SprintBoardCardToken.php
@@ -1,6 +1,6 @@
 ?php
 
-final class SprintBoardCardToken {
+final class SprintBoardCardToken extends Phobject {
   private $viewer;
 
   public function setViewer ($viewer) {
diff --git a/src/util/SprintPoints.php b/src/util/SprintPoints.php
index 6c4f8f2..ea3c7a3 100644
--- a/src/util/SprintPoints.php
+++ b/src/util/SprintPoints.php
@@ -1,6 +1,6 @@
 ?php
 
-final class SprintPoints {
+final class SprintPoints extends Phobject {
 
 private $taskpoints;
 private $task_open_status_sum;
diff --git a/src/util/SprintValidator.php b/src/util/SprintValidator.php
index 863a671..c8fd8ef 100644
--- a/src/util/SprintValidator.php
+++ b/src/util/SprintValidator.php
@@ -1,6 +1,6 @@
 ?php
 
-final class SprintValidator {
+final class SprintValidator extends Phobject {
 
   public function checkForSprint($showfields, $project_phid) {
 $show = $showfields($project_phid);
diff --git a/src/view/SprintBoardTaskCard.php b/src/view/SprintBoardTaskCard.php
index b971dd6..a3614c5 100644
--- a/src/view/SprintBoardTaskCard.php
+++ b/src/view/SprintBoardTaskCard.php
@@ -1,6 +1,6 @@
 ?php
 
-final class SprintBoardTaskCard {
+final class SprintBoardTaskCard extends Phobject {
 
   private $project;
   private $viewer;
diff --git a/src/view/SprintListTableView.php b/src/view/SprintListTableView.php
index 95553cc..b3e250b 100644
--- a/src/view/SprintListTableView.php
+++ b/src/view/SprintListTableView.php
@@ -1,6 +1,6 @@
 ?php
 
-final class SprintListTableView {
+final class SprintListTableView extends Phobject {
 
   private $tableData;
 
diff --git a/src/view/burndown/BoardDataPieView.php 
b/src/view/burndown/BoardDataPieView.php
index a2b5d85..757a4ef 100644
--- a/src/view/burndown/BoardDataPieView.php
+++ b/src/view/burndown/BoardDataPieView.php
@@ -1,6 +1,6 @@
 ?php
 
-final class BoardDataPieView {
+final class BoardDataPieView extends Phobject{
 
   private $boardData;
 
diff --git a/src/view/burndown/BoardDataTableView.php 
b/src/view/burndown/BoardDataTableView.php
index 50f046d..b185f2c 100644
--- a/src/view/burndown/BoardDataTableView.php
+++ b/src/view/burndown/BoardDataTableView.php
@@ -1,6 +1,6 @@
 ?php
 
-final class BoardDataTableView {
+final class BoardDataTableView extends Phobject{
 
   private $boardData;
 
@@ -21,7 +21,7 @@
 
 $box = id(new PHUIObjectBoxView())
 -setHeaderText(pht('Board Column List'))
--appendChild($table);
+-setTable($table);
 return $box;
   }
 }
diff --git a/src/view/burndown/BurndownChartView.php 
b/src/view/burndown/BurndownChartView.php
index eae5047..9d4583e 100644
--- a/src/view/burndown/BurndownChartView.php
+++ b/src/view/burndown/BurndownChartView.php
@@ -1,6 +1,6 @@
 ?php
 
-final class BurndownChartView {
+final class BurndownChartView extends Phobject{
   private $data;
 
   public function setChartData($chart_data) {
diff --git a/src/view/burndown/EventTableView.php 
b/src/view/burndown/EventTableView.php
index d8cabdd..2c036c0 100644
--- a/src/view/burndown/EventTableView.php
+++ b/src/view/burndown/EventTableView.php
@@ -1,6 +1,6 @@
 ?php
 
-final class EventTableView {
+final class EventTableView extends Phobject{
   private $project;
   private $viewer;
   private $request;
@@ -66,7 +66,7 @@
 ));
 $box = id(new PHUIObjectBoxView())
 -setHeaderText(pht('Events related to this sprint'))
--appendChild($table);
+-setTable($table);
 
 return $box;
   }
diff --git a/src/view/burndown/TasksTableView.php 
b/src/view/burndown/TasksTableView.php
index 51aa305..ba35d7a 100644
--- a/src/view/burndown/TasksTableView.php
+++ b/src/view/burndown/TasksTableView.php
@@