[MediaWiki-commits] [Gerrit] analytics...deploy[master]: Use -e instead of -d for checking for deploy dir, in case it...

[Ottomata (Code Review)]

Ottomata has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/395807 )

Change subject: Use -e instead of -d for checking for deploy dir, in case it is 
a symlink
..


Use -e instead of -d for checking for deploy dir, in case it is a symlink

Change-Id: I4793c4c648b78cb120c242efacb2fe3fe14c1e28
---
M create_virtualenv.sh
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Ottomata: Verified; Looks good to me, approved



diff --git a/create_virtualenv.sh b/create_virtualenv.sh
index 6ff9b30..b7c75b1 100755
--- a/create_virtualenv.sh
+++ b/create_virtualenv.sh
@@ -3,7 +3,7 @@
 wheels_dir=$deploy_dir/artifacts/$dist
 
 # Default deploy directory, should exist in production.
-if [ -d /srv/deployment/analytics/superset ]; then
+if [ -e /srv/deployment/analytics/superset ]; then
 venv=/srv/deployment/analytics/superset/venv
 # Else just use ../superset-venv for testing.
 else

-- 
To view, visit https://gerrit.wikimedia.org/r/395807
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4793c4c648b78cb120c242efacb2fe3fe14c1e28
Gerrit-PatchSet: 1
Gerrit-Project: analytics/superset/deploy
Gerrit-Branch: master
Gerrit-Owner: Ottomata 
Gerrit-Reviewer: Ottomata 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] analytics...deploy[master]: Use -e instead of -d for checking for deploy dir, in case it...

[Ottomata (Code Review)]

Ottomata has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/395807 )

Change subject: Use -e instead of -d for checking for deploy dir, in case it is 
a symlink
..

Use -e instead of -d for checking for deploy dir, in case it is a symlink

Change-Id: I4793c4c648b78cb120c242efacb2fe3fe14c1e28
---
M create_virtualenv.sh
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/analytics/superset/deploy 
refs/changes/07/395807/1

diff --git a/create_virtualenv.sh b/create_virtualenv.sh
index 6ff9b30..b7c75b1 100755
--- a/create_virtualenv.sh
+++ b/create_virtualenv.sh
@@ -3,7 +3,7 @@
 wheels_dir=$deploy_dir/artifacts/$dist
 
 # Default deploy directory, should exist in production.
-if [ -d /srv/deployment/analytics/superset ]; then
+if [ -e /srv/deployment/analytics/superset ]; then
 venv=/srv/deployment/analytics/superset/venv
 # Else just use ../superset-venv for testing.
 else

-- 
To view, visit https://gerrit.wikimedia.org/r/395807
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4793c4c648b78cb120c242efacb2fe3fe14c1e28
Gerrit-PatchSet: 1
Gerrit-Project: analytics/superset/deploy
Gerrit-Branch: master
Gerrit-Owner: Ottomata 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits