[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Fix "No results" message overlapping other error messages in...

2017-06-30 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/362422 )

Change subject: Fix "No results" message overlapping other error messages in 
search results view
..


Fix "No results" message overlapping other error messages in search results view

This task fixes the way messages are shown from within error messages 
container, hiding first "No results" message then showing that there is "No 
Internet Connectivity".

Bug: T166432
Change-Id: I059a025f661b5f043a65b323c8f03231197294cf
---
M app/src/main/java/org/wikipedia/search/SearchResultsFragment.java
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Dbrant: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/app/src/main/java/org/wikipedia/search/SearchResultsFragment.java 
b/app/src/main/java/org/wikipedia/search/SearchResultsFragment.java
index e95bff5..27fdca5 100644
--- a/app/src/main/java/org/wikipedia/search/SearchResultsFragment.java
+++ b/app/src/main/java/org/wikipedia/search/SearchResultsFragment.java
@@ -229,6 +229,7 @@
 }
 if (isAdded()) {
 updateProgressBar(false);
+searchEmptyView.setVisibility(View.GONE);
 searchErrorView.setVisibility(View.VISIBLE);
 searchErrorView.setError(caught);
 searchResultsContainer.setVisibility(View.GONE);

-- 
To view, visit https://gerrit.wikimedia.org/r/362422
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I059a025f661b5f043a65b323c8f03231197294cf
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Jcasariego 
Gerrit-Reviewer: Dbrant 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Fix "No results" message overlapping other error messages in...

2017-06-30 Thread Jcasariego (Code Review) 
Jcasariego has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/362422 )

Change subject: Fix "No results" message overlapping other error messages in 
search results view
..

Fix "No results" message overlapping other error messages in search results view

This task fixes the way messages are shown from within error messages 
container, hiding first "No results" message then showing that there is "No 
Internet Connectivity".

Bug: T166432
Change-Id: I059a025f661b5f043a65b323c8f03231197294cf
---
M app/src/main/java/org/wikipedia/search/SearchResultsFragment.java
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia 
refs/changes/22/362422/1

diff --git a/app/src/main/java/org/wikipedia/search/SearchResultsFragment.java 
b/app/src/main/java/org/wikipedia/search/SearchResultsFragment.java
index e95bff5..27fdca5 100644
--- a/app/src/main/java/org/wikipedia/search/SearchResultsFragment.java
+++ b/app/src/main/java/org/wikipedia/search/SearchResultsFragment.java
@@ -229,6 +229,7 @@
 }
 if (isAdded()) {
 updateProgressBar(false);
+searchEmptyView.setVisibility(View.GONE);
 searchErrorView.setVisibility(View.VISIBLE);
 searchErrorView.setError(caught);
 searchResultsContainer.setVisibility(View.GONE);

-- 
To view, visit https://gerrit.wikimedia.org/r/362422
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I059a025f661b5f043a65b323c8f03231197294cf
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Jcasariego 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits