[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Kill upside-down rotation

2017-09-06 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/376432 )

Change subject: Kill upside-down rotation
..


Kill upside-down rotation

Departs from the norm, has no obvious benefit, causes bugs and complaints.

Bug: T171322
Change-Id: I13efdb42e1d3bd1ff4161b76b9f70c6f30c84ab4
---
M app/src/main/java/org/wikipedia/activity/BaseActivity.java
M app/src/main/java/org/wikipedia/activity/ThemedActionBarActivity.java
2 files changed, 0 insertions(+), 11 deletions(-)

Approvals:
  Dbrant: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/app/src/main/java/org/wikipedia/activity/BaseActivity.java 
b/app/src/main/java/org/wikipedia/activity/BaseActivity.java
index a208649..ec0f070 100644
--- a/app/src/main/java/org/wikipedia/activity/BaseActivity.java
+++ b/app/src/main/java/org/wikipedia/activity/BaseActivity.java
@@ -5,7 +5,6 @@
 import android.content.Context;
 import android.content.Intent;
 import android.content.IntentFilter;
-import android.content.pm.ActivityInfo;
 import android.net.ConnectivityManager;
 import android.os.Build;
 import android.os.Bundle;
@@ -51,12 +50,6 @@
 return true;
 default:
 return false;
-}
-}
-
-protected void requestFullUserOrientation() {
-if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.JELLY_BEAN_MR2) {
-setRequestedOrientation(ActivityInfo.SCREEN_ORIENTATION_FULL_USER);
 }
 }
 
diff --git 
a/app/src/main/java/org/wikipedia/activity/ThemedActionBarActivity.java 
b/app/src/main/java/org/wikipedia/activity/ThemedActionBarActivity.java
index e5fd1cf..e1ab755 100644
--- a/app/src/main/java/org/wikipedia/activity/ThemedActionBarActivity.java
+++ b/app/src/main/java/org/wikipedia/activity/ThemedActionBarActivity.java
@@ -28,10 +28,6 @@
 busMethods = new EventBusMethods();
 WikipediaApp.getInstance().getBus().register(busMethods);
 
-// todo: move this down into subclasses or always support all 
orientations and move this up
-//   to BaseActivity
-requestFullUserOrientation();
-
 setTheme();
 removeSplashBackground();
 

-- 
To view, visit https://gerrit.wikimedia.org/r/376432
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I13efdb42e1d3bd1ff4161b76b9f70c6f30c84ab4
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Mholloway 
Gerrit-Reviewer: Brion VIBBER 
Gerrit-Reviewer: Cooltey 
Gerrit-Reviewer: Dbrant 
Gerrit-Reviewer: Sharvaniharan 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Kill upside-down rotation

2017-09-06 Thread Mholloway (Code Review) 
Mholloway has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/376432 )

Change subject: Kill upside-down rotation
..

Kill upside-down rotation

Departs from the norm, has no obvious benefit, causes bugs and complaints.

Bug: T171322
Change-Id: I13efdb42e1d3bd1ff4161b76b9f70c6f30c84ab4
---
M app/src/main/java/org/wikipedia/activity/BaseActivity.java
M app/src/main/java/org/wikipedia/activity/ThemedActionBarActivity.java
2 files changed, 0 insertions(+), 11 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia 
refs/changes/32/376432/1

diff --git a/app/src/main/java/org/wikipedia/activity/BaseActivity.java 
b/app/src/main/java/org/wikipedia/activity/BaseActivity.java
index a208649..ec0f070 100644
--- a/app/src/main/java/org/wikipedia/activity/BaseActivity.java
+++ b/app/src/main/java/org/wikipedia/activity/BaseActivity.java
@@ -5,7 +5,6 @@
 import android.content.Context;
 import android.content.Intent;
 import android.content.IntentFilter;
-import android.content.pm.ActivityInfo;
 import android.net.ConnectivityManager;
 import android.os.Build;
 import android.os.Bundle;
@@ -51,12 +50,6 @@
 return true;
 default:
 return false;
-}
-}
-
-protected void requestFullUserOrientation() {
-if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.JELLY_BEAN_MR2) {
-setRequestedOrientation(ActivityInfo.SCREEN_ORIENTATION_FULL_USER);
 }
 }
 
diff --git 
a/app/src/main/java/org/wikipedia/activity/ThemedActionBarActivity.java 
b/app/src/main/java/org/wikipedia/activity/ThemedActionBarActivity.java
index e5fd1cf..e1ab755 100644
--- a/app/src/main/java/org/wikipedia/activity/ThemedActionBarActivity.java
+++ b/app/src/main/java/org/wikipedia/activity/ThemedActionBarActivity.java
@@ -28,10 +28,6 @@
 busMethods = new EventBusMethods();
 WikipediaApp.getInstance().getBus().register(busMethods);
 
-// todo: move this down into subclasses or always support all 
orientations and move this up
-//   to BaseActivity
-requestFullUserOrientation();
-
 setTheme();
 removeSplashBackground();
 

-- 
To view, visit https://gerrit.wikimedia.org/r/376432
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I13efdb42e1d3bd1ff4161b76b9f70c6f30c84ab4
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Mholloway 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits