[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Make Featured article card translatable

2017-08-21 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/372804 )

Change subject: Make Featured article card translatable
..


Make Featured article card translatable

The "Featured article" card's title and save button was untranslatable
as an "experimental English-only feature". As it's stable and widely
used, it should be translatable.

Change-Id: I325102d6485b49625f60fd9bf06b23df62a90283
---
M app/src/main/res/values-qq/strings.xml
M app/src/main/res/values/strings.xml
M app/src/main/res/values/strings_no_translate.xml
3 files changed, 6 insertions(+), 6 deletions(-)

Approvals:
  Dbrant: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/app/src/main/res/values-qq/strings.xml 
b/app/src/main/res/values-qq/strings.xml
index 18f6e5e..8e65b3c 100644
--- a/app/src/main/res/values-qq/strings.xml
+++ b/app/src/main/res/values-qq/strings.xml
@@ -376,6 +376,9 @@
   Shown on cards in 
the feed when the card has today\'s date.\n{{Identical|Today}}
   Button label that 
allows the user to decline the action that this card is 
requesting.\n{{Identical|No thanks}}
   Message in the feed informing the user 
that additional content cannot be loaded while offline.
+  Title shown in the Featured 
Article card in the Explore feed
+  Button label 
for saving the current featured article to a reading list, if it is not already 
saved.
+  Button label 
for when the current featured article is already saved to a reading list, but 
may now be removed from the list, or saved to a different list.
   Hint text that is shown when the 
description field is empty.
   Hint for the button that is pressed for 
saving the new description.\n{{Identical|Publish}}
   Label that prompts the user 
to add a description to an article that does not yet have one.
diff --git a/app/src/main/res/values/strings.xml 
b/app/src/main/res/values/strings.xml
index 50f4ca9..38839c5 100644
--- a/app/src/main/res/values/strings.xml
+++ b/app/src/main/res/values/strings.xml
@@ -411,6 +411,9 @@
 Today
 No thanks
 Content cannot be loaded when 
offline.
+Featured article
+Save
+Saved
 
 
 
diff --git a/app/src/main/res/values/strings_no_translate.xml 
b/app/src/main/res/values/strings_no_translate.xml
index 35a169a..d2454c1 100644
--- a/app/src/main/res/values/strings_no_translate.xml
+++ b/app/src/main/res/values/strings_no_translate.xml
@@ -43,12 +43,6 @@
 
 @string/feed
 @string/reading_list_item_delete_undo
-
-
-Featured article
-Save
-Saved
-
 
 
 

-- 
To view, visit https://gerrit.wikimedia.org/r/372804
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I325102d6485b49625f60fd9bf06b23df62a90283
Gerrit-PatchSet: 2
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Tacsipacsi 
Gerrit-Reviewer: Brion VIBBER 
Gerrit-Reviewer: Dbrant 
Gerrit-Reviewer: Mholloway 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Make Featured article card translatable

2017-08-20 Thread Tacsipacsi (Code Review)
Tacsipacsi has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/372804 )

Change subject: Make Featured article card translatable
..

Make Featured article card translatable

The "Featured article" card's title and save button was untranslatable
as an "experimental English-only feature". As it's stable and widely
used, it should be translatable.

Change-Id: I325102d6485b49625f60fd9bf06b23df62a90283
---
M app/src/main/res/values/strings.xml
M app/src/main/res/values/strings_no_translate.xml
2 files changed, 3 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia 
refs/changes/04/372804/1

diff --git a/app/src/main/res/values/strings.xml 
b/app/src/main/res/values/strings.xml
index 50f4ca9..38839c5 100644
--- a/app/src/main/res/values/strings.xml
+++ b/app/src/main/res/values/strings.xml
@@ -411,6 +411,9 @@
 Today
 No thanks
 Content cannot be loaded when 
offline.
+Featured article
+Save
+Saved
 
 
 
diff --git a/app/src/main/res/values/strings_no_translate.xml 
b/app/src/main/res/values/strings_no_translate.xml
index 35a169a..d2454c1 100644
--- a/app/src/main/res/values/strings_no_translate.xml
+++ b/app/src/main/res/values/strings_no_translate.xml
@@ -43,12 +43,6 @@
 
 @string/feed
 @string/reading_list_item_delete_undo
-
-
-Featured article
-Save
-Saved
-
 
 
 

-- 
To view, visit https://gerrit.wikimedia.org/r/372804
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I325102d6485b49625f60fd9bf06b23df62a90283
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Tacsipacsi 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits