[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Prevent possible crash in tab view.

2017-10-26 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/386667 )

Change subject: Prevent possible crash in tab view.
..


Prevent possible crash in tab view.

https://rink.hockeyapp.net/manage/apps/226650/app_versions/148/crash_reasons/192586334

Change-Id: I183bcfdef31105cf45df6a563c5e71f0625aa592
---
M app/src/main/java/org/wikipedia/page/tabs/TabsProvider.java
1 file changed, 3 insertions(+), 0 deletions(-)

Approvals:
  jenkins-bot: Verified
  Cooltey: Looks good to me, approved



diff --git a/app/src/main/java/org/wikipedia/page/tabs/TabsProvider.java 
b/app/src/main/java/org/wikipedia/page/tabs/TabsProvider.java
index 3e5f7a6..5ccbc05 100644
--- a/app/src/main/java/org/wikipedia/page/tabs/TabsProvider.java
+++ b/app/src/main/java/org/wikipedia/page/tabs/TabsProvider.java
@@ -194,6 +194,9 @@
 
 @Override
 public void onDestroyActionMode(ActionMode mode) {
+if (!fragment.isAdded() || fragment.getContext() == null) {
+return;
+}
 Animation anim = 
AnimationUtils.loadAnimation(fragment.getContext(), R.anim.tab_list_zoom_exit);
 fragment.getView().startAnimation(anim);
 hideTabList();

-- 
To view, visit https://gerrit.wikimedia.org/r/386667
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I183bcfdef31105cf45df6a563c5e71f0625aa592
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Dbrant 
Gerrit-Reviewer: Brion VIBBER 
Gerrit-Reviewer: Cooltey 
Gerrit-Reviewer: Sharvaniharan 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Prevent possible crash in tab view.

2017-10-26 Thread Dbrant (Code Review) 
Dbrant has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/386667 )

Change subject: Prevent possible crash in tab view.
..

Prevent possible crash in tab view.

https://rink.hockeyapp.net/manage/apps/226650/app_versions/148/crash_reasons/192586334

Change-Id: I183bcfdef31105cf45df6a563c5e71f0625aa592
---
M app/src/main/java/org/wikipedia/page/tabs/TabsProvider.java
1 file changed, 3 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia 
refs/changes/67/386667/1

diff --git a/app/src/main/java/org/wikipedia/page/tabs/TabsProvider.java 
b/app/src/main/java/org/wikipedia/page/tabs/TabsProvider.java
index 3e5f7a6..5ccbc05 100644
--- a/app/src/main/java/org/wikipedia/page/tabs/TabsProvider.java
+++ b/app/src/main/java/org/wikipedia/page/tabs/TabsProvider.java
@@ -194,6 +194,9 @@
 
 @Override
 public void onDestroyActionMode(ActionMode mode) {
+if (!fragment.isAdded() || fragment.getContext() == null) {
+return;
+}
 Animation anim = 
AnimationUtils.loadAnimation(fragment.getContext(), R.anim.tab_list_zoom_exit);
 fragment.getView().startAnimation(anim);
 hideTabList();

-- 
To view, visit https://gerrit.wikimedia.org/r/386667
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I183bcfdef31105cf45df6a563c5e71f0625aa592
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Dbrant 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits