[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Prevent possible crash when fetching remaining sections.

2017-10-26 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/386668 )

Change subject: Prevent possible crash when fetching remaining sections.
..


Prevent possible crash when fetching remaining sections.

The retrofit Response class requires a nonnull "message", otherwise it
crashes.

Change-Id: I614a4a643f95fa5817cf58c439ba6b4faf6083b9
---
M app/src/main/java/org/wikipedia/page/PageFragmentLoadState.java
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  jenkins-bot: Verified
  Cooltey: Looks good to me, approved



diff --git a/app/src/main/java/org/wikipedia/page/PageFragmentLoadState.java 
b/app/src/main/java/org/wikipedia/page/PageFragmentLoadState.java
index f454905..bb05ef7 100644
--- a/app/src/main/java/org/wikipedia/page/PageFragmentLoadState.java
+++ b/app/src/main/java/org/wikipedia/page/PageFragmentLoadState.java
@@ -288,7 +288,7 @@
 int sequence = payload.getInt("sequence");
 int status = payload.getInt("status");
 commonSectionFetchOnCatch(new HttpStatusException(new 
okhttp3.Response.Builder()
-.code(status).protocol(Protocol.HTTP_1_1)
+
.code(status).protocol(Protocol.HTTP_1_1).message("")
 .request(new okhttp3.Request.Builder()
 
.url(model.getTitle().getMobileUri()).build()).build()),
 sequence);

-- 
To view, visit https://gerrit.wikimedia.org/r/386668
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I614a4a643f95fa5817cf58c439ba6b4faf6083b9
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Dbrant 
Gerrit-Reviewer: Brion VIBBER 
Gerrit-Reviewer: Cooltey 
Gerrit-Reviewer: Sharvaniharan 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Prevent possible crash when fetching remaining sections.

2017-10-26 Thread Dbrant (Code Review) 
Dbrant has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/386668 )

Change subject: Prevent possible crash when fetching remaining sections.
..

Prevent possible crash when fetching remaining sections.

The retrofit Response class requires a nonnull "message", otherwise it
crashes.

Change-Id: I614a4a643f95fa5817cf58c439ba6b4faf6083b9
---
M app/src/main/java/org/wikipedia/page/PageFragmentLoadState.java
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia 
refs/changes/68/386668/1

diff --git a/app/src/main/java/org/wikipedia/page/PageFragmentLoadState.java 
b/app/src/main/java/org/wikipedia/page/PageFragmentLoadState.java
index f454905..bb05ef7 100644
--- a/app/src/main/java/org/wikipedia/page/PageFragmentLoadState.java
+++ b/app/src/main/java/org/wikipedia/page/PageFragmentLoadState.java
@@ -288,7 +288,7 @@
 int sequence = payload.getInt("sequence");
 int status = payload.getInt("status");
 commonSectionFetchOnCatch(new HttpStatusException(new 
okhttp3.Response.Builder()
-.code(status).protocol(Protocol.HTTP_1_1)
+
.code(status).protocol(Protocol.HTTP_1_1).message("")
 .request(new okhttp3.Request.Builder()
 
.url(model.getTitle().getMobileUri()).build()).build()),
 sequence);

-- 
To view, visit https://gerrit.wikimedia.org/r/386668
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I614a4a643f95fa5817cf58c439ba6b4faf6083b9
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Dbrant 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits