Jcasariego has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/357752 )
Change subject: Remove pilimit from PageImages API calls
......................................................................
Remove pilimit from PageImages API calls
pilimit will no longer be necessary as a result of T153709. PageImages will
default to returning an image for up to PARAM_MAX (=50, or 500 for bots)
results rather than 1.
Bug: T166080
Change-Id: I6c6fd0ae89c2dfb48b18931811e73beec25460ff
---
M app/src/main/java/org/wikipedia/pageimages/PageImagesClient.java
1 file changed, 2 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia
refs/changes/52/357752/1
diff --git a/app/src/main/java/org/wikipedia/pageimages/PageImagesClient.java
b/app/src/main/java/org/wikipedia/pageimages/PageImagesClient.java
index c30d635..63ade86 100644
--- a/app/src/main/java/org/wikipedia/pageimages/PageImagesClient.java
+++ b/app/src/main/java/org/wikipedia/pageimages/PageImagesClient.java
@@ -43,7 +43,7 @@
@NonNull Service
service,
@NonNull final
List<PageTitle> titles,
@NonNull final
Callback cb) {
- Call<MwQueryResponse<MwQueryResponse.Pages>> call =
service.request(TextUtils.join("|", titles), titles.size());
+ Call<MwQueryResponse<MwQueryResponse.Pages>> call =
service.request(TextUtils.join("|", titles));
call.enqueue(new
retrofit2.Callback<MwQueryResponse<MwQueryResponse.Pages>>() {
@Override public void
onResponse(Call<MwQueryResponse<MwQueryResponse.Pages>> call,
Response<MwQueryResponse<MwQueryResponse.Pages>> response) {
@@ -89,7 +89,6 @@
@VisibleForTesting interface Service {
@GET("w/api.php?action=query&format=json&formatversion=2&prop=pageimages&piprop=thumbnail"
+ "&pilicense=any&pithumbsize=" +
Constants.PREFERRED_THUMB_SIZE)
- Call<MwQueryResponse<MwQueryResponse.Pages>> request(@NonNull
@Query("titles") String titles,
- @Query("pilimit") int
piLimit);
+ Call<MwQueryResponse<MwQueryResponse.Pages>> request(@NonNull
@Query("titles") String titles);
}
}
--
To view, visit https://gerrit.wikimedia.org/r/357752
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6c6fd0ae89c2dfb48b18931811e73beec25460ff
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Jcasariego <jorgek...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
