[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Separate different parts of the message with a new line

2017-08-12 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/370817 )

Change subject: Separate different parts of the message with a new line
..


Separate different parts of the message with a new line

It's better to separate the different parts of the message
with a new line than a space as it could improve improve it's
readability.

Change-Id: I0d8735d0555c89844ae7c012b3b4494304b183ac
---
M app/src/main/java/org/wikipedia/page/linkpreview/LinkPreviewErrorView.java
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Rho: Looks good to me, approved
  jenkins-bot: Verified
  Thiemo Mättig (WMDE): Looks good to me, but someone else must approve
  Mholloway: Looks good to me, but someone else must approve



diff --git 
a/app/src/main/java/org/wikipedia/page/linkpreview/LinkPreviewErrorView.java 
b/app/src/main/java/org/wikipedia/page/linkpreview/LinkPreviewErrorView.java
index 692f8f8..0c7a540 100644
--- a/app/src/main/java/org/wikipedia/page/linkpreview/LinkPreviewErrorView.java
+++ b/app/src/main/java/org/wikipedia/page/linkpreview/LinkPreviewErrorView.java
@@ -61,7 +61,7 @@
 // message and subtitle in the full page view.  Figure out a good way 
to handle this.
 if (errorType == LinkPreviewErrorType.OFFLINE) {
 String message = 
getResources().getString(R.string.page_offline_notice_cannot_load_while_offline)
-+ " " + 
getResources().getString(R.string.page_offline_notice_add_to_reading_list);
++ "\n" + 
getResources().getString(R.string.page_offline_notice_add_to_reading_list);
 textView.setText(message);
 } else {
 
textView.setText(getContext().getResources().getString(errorType.text()));

-- 
To view, visit https://gerrit.wikimedia.org/r/370817
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0d8735d0555c89844ae7c012b3b4494304b183ac
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Kaartic 
Gerrit-Reviewer: Brion VIBBER 
Gerrit-Reviewer: Dbrant 
Gerrit-Reviewer: Mholloway 
Gerrit-Reviewer: Rho 
Gerrit-Reviewer: Thiemo Mättig (WMDE) 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Separate different parts of the message with a new line

2017-08-09 Thread Kaartic (Code Review) 
Kaartic has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/370817 )

Change subject: Separate different parts of the message with a new line
..

Separate different parts of the message with a new line

It's better to separate the different parts of the message
with a new line than a space as it could improve improve it's
readability.

Change-Id: I0d8735d0555c89844ae7c012b3b4494304b183ac
---
M app/src/main/java/org/wikipedia/page/linkpreview/LinkPreviewErrorView.java
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia 
refs/changes/17/370817/1

diff --git 
a/app/src/main/java/org/wikipedia/page/linkpreview/LinkPreviewErrorView.java 
b/app/src/main/java/org/wikipedia/page/linkpreview/LinkPreviewErrorView.java
index 692f8f8..0c7a540 100644
--- a/app/src/main/java/org/wikipedia/page/linkpreview/LinkPreviewErrorView.java
+++ b/app/src/main/java/org/wikipedia/page/linkpreview/LinkPreviewErrorView.java
@@ -61,7 +61,7 @@
 // message and subtitle in the full page view.  Figure out a good way 
to handle this.
 if (errorType == LinkPreviewErrorType.OFFLINE) {
 String message = 
getResources().getString(R.string.page_offline_notice_cannot_load_while_offline)
-+ " " + 
getResources().getString(R.string.page_offline_notice_add_to_reading_list);
++ "\n" + 
getResources().getString(R.string.page_offline_notice_add_to_reading_list);
 textView.setText(message);
 } else {
 
textView.setText(getContext().getResources().getString(errorType.text()));

-- 
To view, visit https://gerrit.wikimedia.org/r/370817
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0d8735d0555c89844ae7c012b3b4494304b183ac
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Kaartic 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits